[INFO] fetching crate kf-protocol-api 2.0.0... [INFO] checking kf-protocol-api-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kf-protocol-api 2.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate kf-protocol-api 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kf-protocol-api 2.0.0 [INFO] finished tweaking crates.io crate kf-protocol-api 2.0.0 [INFO] tweaked toml for crates.io crate kf-protocol-api 2.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 80 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding crc32c v0.5.0 (latest: v0.6.8) [INFO] [stderr] Adding flv-util v0.4.0 (latest: v0.5.2) [INFO] [stderr] Adding matchers v0.0.1 (latest: v0.2.0) [INFO] [stderr] Adding num-derive v0.2.5 (latest: v0.4.2) [INFO] [stderr] Adding paste v0.1.18 (latest: v1.0.15) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tracing-log v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (latest: v0.3.18) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09bac271a9d11f66976fac5b36305c3dc201f223185535eb59f8ba3558f50feb [INFO] running `Command { std: "docker" "start" "-a" "09bac271a9d11f66976fac5b36305c3dc201f223185535eb59f8ba3558f50feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09bac271a9d11f66976fac5b36305c3dc201f223185535eb59f8ba3558f50feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09bac271a9d11f66976fac5b36305c3dc201f223185535eb59f8ba3558f50feb", kill_on_drop: false }` [INFO] [stdout] 09bac271a9d11f66976fac5b36305c3dc201f223185535eb59f8ba3558f50feb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb92007b7b6d3fc1636a00cff97554f376ef553def445b249cf0843e28995822 [INFO] running `Command { std: "docker" "start" "-a" "fb92007b7b6d3fc1636a00cff97554f376ef553def445b249cf0843e28995822", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling crc32c v0.5.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Compiling kf-protocol-derive v0.2.0 [INFO] [stderr] Checking kf-protocol-core v0.1.2 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking flv-util v0.4.0 [INFO] [stderr] Checking kf-protocol-api v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/kf_api.rs:4:3 [INFO] [stdout] | [INFO] [stdout] 4 | #[fluvio_kf(encode_discriminant)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 5 | #[derive(PartialEq, Debug, Clone, Copy, Encode, Decode)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] = note: `#[warn(legacy_derive_helpers)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/error.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 10 | #[fluvio_kf(encode_discriminant)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | #[derive(PartialEq, Debug, Clone, Copy, Serialize, Deserialize, Encode, Decode)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/flv_errors.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 16 | #[fluvio_kf(encode_discriminant)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 17 | #[repr(i16)] [INFO] [stdout] 18 | #[derive(Encode, Decode, PartialEq, Debug, Clone, Copy, Serialize)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/error.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | #[fluvio_kf(default)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 12 | #[repr(i16)] [INFO] [stdout] 13 | #[derive(PartialEq, Debug, Clone, Copy, Serialize, Deserialize, Encode, Decode)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/kf_api.rs:4:3 [INFO] [stdout] | [INFO] [stdout] 4 | #[fluvio_kf(encode_discriminant)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 5 | #[derive(PartialEq, Debug, Clone, Copy, Encode, Decode)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] = note: `#[warn(legacy_derive_helpers)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/error.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 10 | #[fluvio_kf(encode_discriminant)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | #[derive(PartialEq, Debug, Clone, Copy, Serialize, Deserialize, Encode, Decode)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/flv_errors.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 16 | #[fluvio_kf(encode_discriminant)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 17 | #[repr(i16)] [INFO] [stdout] 18 | #[derive(Encode, Decode, PartialEq, Debug, Clone, Copy, Serialize)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/error.rs:11:3 [INFO] [stdout] | [INFO] [stdout] 11 | #[fluvio_kf(default)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 12 | #[repr(i16)] [INFO] [stdout] 13 | #[derive(PartialEq, Debug, Clone, Copy, Serialize, Deserialize, Encode, Decode)] [INFO] [stdout] | ------ the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Records` is never used [INFO] [stdout] --> src/record.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 33 | pub trait Records {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 55 | let response = P::decode_from(src, version)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(ResponseMessage { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | correlation_id, [INFO] [stdout] 58 | | response [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/common.rs:117:32 [INFO] [stdout] | [INFO] [stdout] 117 | format!("{}-{}", topic_name.clone(), idx) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kf-protocol-api` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `Records` is never used [INFO] [stdout] --> src/record.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 33 | pub trait Records {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 55 | let response = P::decode_from(src, version)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(ResponseMessage { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | correlation_id, [INFO] [stdout] 58 | | response [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/common.rs:117:32 [INFO] [stdout] | [INFO] [stdout] 117 | format!("{}-{}", topic_name.clone(), idx) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kf-protocol-api` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fb92007b7b6d3fc1636a00cff97554f376ef553def445b249cf0843e28995822", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb92007b7b6d3fc1636a00cff97554f376ef553def445b249cf0843e28995822", kill_on_drop: false }` [INFO] [stdout] fb92007b7b6d3fc1636a00cff97554f376ef553def445b249cf0843e28995822