[INFO] fetching crate keyvalues-serde 0.2.1... [INFO] checking keyvalues-serde-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate keyvalues-serde 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate keyvalues-serde 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate keyvalues-serde 0.2.1 [INFO] finished tweaking crates.io crate keyvalues-serde 0.2.1 [INFO] tweaked toml for crates.io crate keyvalues-serde 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate keyvalues-serde 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2842ba2c372df696174cc55597a281e406732021c849872a692bbad36986c313 [INFO] running `Command { std: "docker" "start" "-a" "2842ba2c372df696174cc55597a281e406732021c849872a692bbad36986c313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2842ba2c372df696174cc55597a281e406732021c849872a692bbad36986c313", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2842ba2c372df696174cc55597a281e406732021c849872a692bbad36986c313", kill_on_drop: false }` [INFO] [stdout] 2842ba2c372df696174cc55597a281e406732021c849872a692bbad36986c313 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6fc5fb1a9f8b844efb80c807a5d72bb12043cc5eb2ba8b3d8bb2c70afe57e675 [INFO] running `Command { std: "docker" "start" "-a" "6fc5fb1a9f8b844efb80c807a5d72bb12043cc5eb2ba8b3d8bb2c70afe57e675", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking similar v2.3.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.42 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling pest v2.7.5 [INFO] [stderr] Compiling pest_meta v2.7.5 [INFO] [stderr] Compiling pest_generator v2.7.5 [INFO] [stderr] Compiling pest_derive v2.7.5 [INFO] [stderr] Checking keyvalues-parser v0.2.0 [INFO] [stderr] Checking serde_json v1.0.108 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking keyvalues-serde v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/lib.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(fuzzing)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/lib.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg(not(fuzzing))] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn from_reader(rdr: R) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | from_reader_with_key(rdr).map(|(t, _)| t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn from_reader_with_key(mut rdr: R) -> Result<(T, String)> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | from_str_with_key(&buffer).map(|(t, key)| (t, key.into_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:229:13 [INFO] [stdout] | [INFO] [stdout] 227 | fn deserialize_bytes>(self, _visitor: V) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | // It's unclear how `bytes` would be represented in vdf [INFO] [stdout] 229 | Err(Error::Unsupported("Bytes")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 232 | fn deserialize_byte_buf>(self, _visitor: V) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | // It's unclear how `byte buf` would be represented in vdf [INFO] [stdout] 234 | Err(Error::Unsupported("Byte Buf")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 243 | fn deserialize_unit>(self, _visitor: V) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | // It's unclear how a unit type would be represented in vdf (Empty string or obj?) [INFO] [stdout] 245 | Err(Error::Unsupported("Unit")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 251 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Err(Error::Unsupported("Unit Struct")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokens/naive.rs:163:16 [INFO] [stdout] | [INFO] [stdout] 140 | fn process_obj<'a, I>(mut tokens: Peekable) -> Result<(Peekable, Value<'a>)> [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok((tokens, Value::Obj(obj))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keyvalues-serde` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6fc5fb1a9f8b844efb80c807a5d72bb12043cc5eb2ba8b3d8bb2c70afe57e675", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fc5fb1a9f8b844efb80c807a5d72bb12043cc5eb2ba8b3d8bb2c70afe57e675", kill_on_drop: false }` [INFO] [stdout] 6fc5fb1a9f8b844efb80c807a5d72bb12043cc5eb2ba8b3d8bb2c70afe57e675