[INFO] fetching crate keyvaluedb-sqlite 0.1.2... [INFO] checking keyvaluedb-sqlite-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate keyvaluedb-sqlite 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate keyvaluedb-sqlite 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate keyvaluedb-sqlite 0.1.2 [INFO] finished tweaking crates.io crate keyvaluedb-sqlite 0.1.2 [INFO] tweaked toml for crates.io crate keyvaluedb-sqlite 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate keyvaluedb-sqlite 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb653c41d0e2dc227b6f0f01b2ed28e392acd524c649d7057f343341bde15516 [INFO] running `Command { std: "docker" "start" "-a" "eb653c41d0e2dc227b6f0f01b2ed28e392acd524c649d7057f343341bde15516", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb653c41d0e2dc227b6f0f01b2ed28e392acd524c649d7057f343341bde15516", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb653c41d0e2dc227b6f0f01b2ed28e392acd524c649d7057f343341bde15516", kill_on_drop: false }` [INFO] [stdout] eb653c41d0e2dc227b6f0f01b2ed28e392acd524c649d7057f343341bde15516 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0de36767b8f57bee14b2c43dea711f7d6171ecba7343014aa4eca3a6bc7c7812 [INFO] running `Command { std: "docker" "start" "-a" "0de36767b8f57bee14b2c43dea711f7d6171ecba7343014aa4eca3a6bc7c7812", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling cc v1.0.104 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking keyvaluedb v0.1.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking rlp v0.5.2 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking keyvaluedb-shared-tests v0.1.2 [INFO] [stderr] Checking impl-rlp v0.3.0 [INFO] [stderr] Compiling libsqlite3-sys v0.26.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking sysinfo v0.29.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking fixed-hash v0.8.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling alloc_counter_macro v0.0.2 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Checking alloc_counter v0.0.4 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking impl-serde v0.4.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking primitive-types v0.12.2 [INFO] [stderr] Checking ethbloom v0.13.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking rusqlite v0.29.0 [INFO] [stderr] Checking keccak-hash v0.10.0 [INFO] [stderr] Checking ethereum-types v0.14.1 [INFO] [stderr] Checking keyvaluedb-sqlite v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 299 | table: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | / conn.query_row( [INFO] [stdout] 307 | | &format!("SELECT value FROM {} WHERE [key] = ?", table.as_ref()), [INFO] [stdout] 308 | | [key.as_ref()], [INFO] [stdout] 309 | | |row| -> Result> { row.get(0) }, [INFO] [stdout] 310 | | ) [INFO] [stdout] 311 | | .optional() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:460:18 [INFO] [stdout] | [INFO] [stdout] 459 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 460 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 461 | | this.with_inner_mut(|inner| { [INFO] [stdout] 462 | | Self::validate_column(col, inner.config.columns)?; [INFO] [stdout] 463 | | match Self::load_unique_value_blob( [INFO] [stdout] ... | [INFO] [stdout] 477 | | }) [INFO] [stdout] 478 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:488:18 [INFO] [stdout] | [INFO] [stdout] 487 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 489 | | this.with_inner_mut(|inner| { [INFO] [stdout] 490 | | Self::validate_column(col, inner.config.columns)?; [INFO] [stdout] 491 | | let someval = Self::load_unique_value_blob( [INFO] [stdout] ... | [INFO] [stdout] 512 | | }) [INFO] [stdout] 513 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:521:18 [INFO] [stdout] | [INFO] [stdout] 520 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 522 | | this.with_inner_mut(|inner| { [INFO] [stdout] 523 | | Self::stats_transaction(inner, 1); [INFO] [stdout] ... | [INFO] [stdout] 567 | | .map_err(|error| DBTransactionError { error, transaction }) [INFO] [stdout] 568 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:13 [INFO] [stdout] | [INFO] [stdout] 520 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | Box::pin(async move { [INFO] [stdout] 522 | / this.with_inner_mut(|inner| { [INFO] [stdout] 523 | | Self::stats_transaction(inner, 1); [INFO] [stdout] 524 | | [INFO] [stdout] 525 | | let mut sw = 0usize; [INFO] [stdout] ... | [INFO] [stdout] 565 | | out [INFO] [stdout] 566 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:578:18 [INFO] [stdout] | [INFO] [stdout] 575 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | ) -> Pin>> + Send + 'a>> { [INFO] [stdout] 577 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 578 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 579 | | this.with_inner_mut(|inner| { [INFO] [stdout] 580 | | if col >= inner.config.columns { [INFO] [stdout] 581 | | return Err(io::Error::from(io::ErrorKind::NotFound)); [INFO] [stdout] ... | [INFO] [stdout] 690 | | }) [INFO] [stdout] 691 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:701:18 [INFO] [stdout] | [INFO] [stdout] 698 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 699 | ) -> Pin>> + Send + 'a>> { [INFO] [stdout] 700 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 701 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 702 | | this.with_inner_mut(|inner| { [INFO] [stdout] 703 | | if col >= inner.config.columns { [INFO] [stdout] 704 | | return Err(io::Error::from(io::ErrorKind::NotFound)); [INFO] [stdout] ... | [INFO] [stdout] 803 | | }) [INFO] [stdout] 804 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:835:18 [INFO] [stdout] | [INFO] [stdout] 834 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 835 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 836 | | this.with_inner(|inner| { [INFO] [stdout] 837 | | if let Ok(found) = inner.connection.query_row( [INFO] [stdout] 838 | | &format!("SELECT Count(*) FROM {}", get_column_table_name(col)), [INFO] [stdout] ... | [INFO] [stdout] 845 | | }) [INFO] [stdout] 846 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keyvaluedb-sqlite` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0de36767b8f57bee14b2c43dea711f7d6171ecba7343014aa4eca3a6bc7c7812", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0de36767b8f57bee14b2c43dea711f7d6171ecba7343014aa4eca3a6bc7c7812", kill_on_drop: false }` [INFO] [stdout] 0de36767b8f57bee14b2c43dea711f7d6171ecba7343014aa4eca3a6bc7c7812