[INFO] fetching crate keyplace 0.1.1... [INFO] checking keyplace-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate keyplace 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate keyplace 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate keyplace 0.1.1 [INFO] finished tweaking crates.io crate keyplace 0.1.1 [INFO] tweaked toml for crates.io crate keyplace 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding crypto-mac v0.9.1 (latest: v0.11.1) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hmac v0.9.0 (latest: v0.12.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding pbkdf2 v0.5.0 (latest: v0.12.2) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding scrypt v0.4.1 (latest: v0.11.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c91001e85a94664cf9f47ae8b154af7b67df8ae29b0610f5bdd36f91b4d1df2 [INFO] running `Command { std: "docker" "start" "-a" "6c91001e85a94664cf9f47ae8b154af7b67df8ae29b0610f5bdd36f91b4d1df2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c91001e85a94664cf9f47ae8b154af7b67df8ae29b0610f5bdd36f91b4d1df2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c91001e85a94664cf9f47ae8b154af7b67df8ae29b0610f5bdd36f91b4d1df2", kill_on_drop: false }` [INFO] [stdout] 6c91001e85a94664cf9f47ae8b154af7b67df8ae29b0610f5bdd36f91b4d1df2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51a3f0abb1072cee5a4ecc559eec5c5ad6f9edf2be1405df0d4af65b5acfde40 [INFO] running `Command { std: "docker" "start" "-a" "51a3f0abb1072cee5a4ecc559eec5c5ad6f9edf2be1405df0d4af65b5acfde40", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking crypto-mac v0.9.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking hmac v0.9.0 [INFO] [stderr] Checking pbkdf2 v0.5.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking toboggan-kv v0.1.2 [INFO] [stderr] Checking scrypt v0.4.1 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking keyplace v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `TryFromBytes` is never used [INFO] [stdout] --> src/util.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | pub trait TryFromBytes [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_manager.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(store: S) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | agent_keys: store.open_tree("agent_keys")?, [INFO] [stdout] 18 | | agent_id_config: store.open_tree("agent_id_config")?, [INFO] [stdout] 19 | | _store: store, [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys/private.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn from_custodial_key(custodial_key: CustodialAgentKey, passkey: PassKey) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | keypair: Keypair { [INFO] [stdout] 112 | | secret: ed25519_dalek::SecretKey::from_bytes(&secret)?, [INFO] [stdout] 113 | | public: ed25519_dalek::PublicKey::from_bytes(&custodial_key.pubkey)?, [INFO] [stdout] 114 | | }, [INFO] [stdout] 115 | | email: custodial_key.email.clone(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn de_from_base64<'de, D>(deserializer: D) -> Result<[u8; 64], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | match String::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn from_base64_32<'de, D>(deserializer: D) -> Result<[u8; 32], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / String::deserialize(deserializer) [INFO] [stdout] 65 | | .and_then(|string| base64::decode(&string).map_err(|err| Error::custom(err.to_string()))) [INFO] [stdout] 66 | | .map(|bytes| bytes[..].try_into()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `TryFromBytes` is never used [INFO] [stdout] --> src/util.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | pub trait TryFromBytes [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_manager.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(store: S) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | agent_keys: store.open_tree("agent_keys")?, [INFO] [stdout] 18 | | agent_id_config: store.open_tree("agent_id_config")?, [INFO] [stdout] 19 | | _store: store, [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keyplace` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys/private.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn from_custodial_key(custodial_key: CustodialAgentKey, passkey: PassKey) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | keypair: Keypair { [INFO] [stdout] 112 | | secret: ed25519_dalek::SecretKey::from_bytes(&secret)?, [INFO] [stdout] 113 | | public: ed25519_dalek::PublicKey::from_bytes(&custodial_key.pubkey)?, [INFO] [stdout] 114 | | }, [INFO] [stdout] 115 | | email: custodial_key.email.clone(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn de_from_base64<'de, D>(deserializer: D) -> Result<[u8; 64], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | match String::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn from_base64_32<'de, D>(deserializer: D) -> Result<[u8; 32], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / String::deserialize(deserializer) [INFO] [stdout] 65 | | .and_then(|string| base64::decode(&string).map_err(|err| Error::custom(err.to_string()))) [INFO] [stdout] 66 | | .map(|bytes| bytes[..].try_into()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keyplace` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "51a3f0abb1072cee5a4ecc559eec5c5ad6f9edf2be1405df0d4af65b5acfde40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51a3f0abb1072cee5a4ecc559eec5c5ad6f9edf2be1405df0d4af65b5acfde40", kill_on_drop: false }` [INFO] [stdout] 51a3f0abb1072cee5a4ecc559eec5c5ad6f9edf2be1405df0d4af65b5acfde40