[INFO] fetching crate kernal 0.3.0... [INFO] checking kernal-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kernal 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate kernal 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kernal 0.3.0 [INFO] finished tweaking crates.io crate kernal 0.3.0 [INFO] tweaked toml for crates.io crate kernal 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e56c701d1e1b6964985fc653073e0f06650928a14643a20641dbfea1f7ad69e1 [INFO] running `Command { std: "docker" "start" "-a" "e56c701d1e1b6964985fc653073e0f06650928a14643a20641dbfea1f7ad69e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e56c701d1e1b6964985fc653073e0f06650928a14643a20641dbfea1f7ad69e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e56c701d1e1b6964985fc653073e0f06650928a14643a20641dbfea1f7ad69e1", kill_on_drop: false }` [INFO] [stdout] e56c701d1e1b6964985fc653073e0f06650928a14643a20641dbfea1f7ad69e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 680489d6562428eb5f31f429fd86164ba2a6d8aab84da6efd381fd22371d687a [INFO] running `Command { std: "docker" "start" "-a" "680489d6562428eb5f31f429fd86164ba2a6d8aab84da6efd381fd22371d687a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking kernal v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:159:46 [INFO] [stdout] | [INFO] [stdout] 159 | if !self.data.iterator().any(|item| &item.abs_diff(expected) <= offset) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:178:59 [INFO] [stdout] | [INFO] [stdout] 178 | highlight_violating_index(&self.data, |item| &item.abs_diff(expected) <= offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:199:59 [INFO] [stdout] | [INFO] [stdout] 199 | highlight_violating_index(&self.data, |item| &item.abs_diff(expected) > offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:223:14 [INFO] [stdout] | [INFO] [stdout] 223 | &actual_item.abs_diff(expected_item) <= offset; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:380:52 [INFO] [stdout] | [INFO] [stdout] 380 | collection, subsequence, |item_1, item_2| &item_1.abs_diff(item_2) <= offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:391:52 [INFO] [stdout] | [INFO] [stdout] 391 | collection, subsequence, |item_1, item_2| &item_1.abs_diff(item_2) <= offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:402:47 [INFO] [stdout] | [INFO] [stdout] 402 | collection, prefix, |item_1, item_2| &item_1.abs_diff(item_2) <= offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:413:47 [INFO] [stdout] | [INFO] [stdout] 413 | collection, suffix, |item_1, item_2| &item_1.abs_diff(item_2) <= offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/abs_diff.rs:577:33 [INFO] [stdout] | [INFO] [stdout] 577 | |expected, actual| &actual.abs_diff(expected) <= offset, &expected_it_suffix) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collections/partial_ord.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 191 | fn find_sorting_counter_example_index<'collection, C, F>(collection: &C, are_correctly_ordered: F) [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | / collection.iterator() [INFO] [stdout] 198 | | .zip(collection.iterator().skip(1)) [INFO] [stdout] 199 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maps/mod.rs:630:19 [INFO] [stdout] | [INFO] [stdout] 628 | fn to_keys(self) -> AssertThat> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 629 | AssertThat { [INFO] [stdout] 630 | data: MapKeys { [INFO] [stdout] | ___________________^ [INFO] [stdout] 631 | | _lifetime: PhantomData, [INFO] [stdout] 632 | | map: self.data, [INFO] [stdout] 633 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maps/mod.rs:640:19 [INFO] [stdout] | [INFO] [stdout] 638 | fn to_values(self) -> AssertThat> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 639 | AssertThat { [INFO] [stdout] 640 | data: MapValues { [INFO] [stdout] | ___________________^ [INFO] [stdout] 641 | | _lifetime: PhantomData, [INFO] [stdout] 642 | | map: self.data, [INFO] [stdout] 643 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:68:11 [INFO] [stdout] | [INFO] [stdout] 59 | assert_that: AssertThat, expected_it: S, predicate: P) [INFO] [stdout] | -------------------------- -------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match catch_unwind(assert_that.data).map_err(to_message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:143:19 [INFO] [stdout] | [INFO] [stdout] 139 | fn to_value(self) -> AssertThat { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | data: self.data.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 148 | fn to_error(self) -> AssertThat { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | data: self.data.unwrap_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] error: could not compile `kernal` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "680489d6562428eb5f31f429fd86164ba2a6d8aab84da6efd381fd22371d687a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "680489d6562428eb5f31f429fd86164ba2a6d8aab84da6efd381fd22371d687a", kill_on_drop: false }` [INFO] [stdout] 680489d6562428eb5f31f429fd86164ba2a6d8aab84da6efd381fd22371d687a