[INFO] fetching crate keeshond_datapack 0.13.0... [INFO] checking keeshond_datapack-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate keeshond_datapack 0.13.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate keeshond_datapack 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate keeshond_datapack 0.13.0 [INFO] finished tweaking crates.io crate keeshond_datapack 0.13.0 [INFO] tweaked toml for crates.io crate keeshond_datapack 0.13.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate keeshond_datapack 0.13.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe9b609380cbe350735b06275b3174567684145a5611502f9a422ea754f59b36 [INFO] running `Command { std: "docker" "start" "-a" "fe9b609380cbe350735b06275b3174567684145a5611502f9a422ea754f59b36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe9b609380cbe350735b06275b3174567684145a5611502f9a422ea754f59b36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe9b609380cbe350735b06275b3174567684145a5611502f9a422ea754f59b36", kill_on_drop: false }` [INFO] [stdout] fe9b609380cbe350735b06275b3174567684145a5611502f9a422ea754f59b36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e12edf86b9301d353beb62b629732d612faf8fcf80257220ae8d4c1274b69337 [INFO] running `Command { std: "docker" "start" "-a" "e12edf86b9301d353beb62b629732d612faf8fcf80257220ae8d4c1274b69337", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling backtrace v0.3.64 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking bzip2 v0.4.3 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking keeshond_datapack v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:617:25 [INFO] [stdout] | [INFO] [stdout] 611 | pub fn new(source_manager : Rc>) -> DataStore [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 617 | data_list : Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1130:115 [INFO] [stdout] | [INFO] [stdout] 1130 | ...eBase>>, DataStoreTypeMax>::generate(|_| RefCell::new(Box::new(NullDataStore {}))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1154:47 [INFO] [stdout] | [INFO] [stdout] 1152 | let store = DataStore::::new(self.source_manager.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1153 | [INFO] [stdout] 1154 | self.register_boxed_type(wanted_type, Box::new(store)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1378:12 [INFO] [stdout] | [INFO] [stdout] 1368 | pub fn new(data_store : &mut DataStore, data_preparer : Box>) -> Result, PreparedStoreE... [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1378 | Ok(PreparedStore:: [INFO] [stdout] | ____________^ [INFO] [stdout] 1379 | | { [INFO] [stdout] 1380 | | data_list : Vec::new(), [INFO] [stdout] 1381 | | data_preparer, [INFO] [stdout] 1382 | | prepare_info [INFO] [stdout] 1383 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:197:23 [INFO] [stdout] | [INFO] [stdout] 190 | fn new

>(basepath : P) -> FilesystemIter [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | walkdir : WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 338 | let file = BufReader::new(File::open(path).map_err( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | Ok(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 358 | let file = BufWriter::new(File::create(path).map_err( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keeshond_datapack` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:617:25 [INFO] [stdout] | [INFO] [stdout] 611 | pub fn new(source_manager : Rc>) -> DataStore [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 617 | data_list : Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1130:115 [INFO] [stdout] | [INFO] [stdout] 1130 | ...eBase>>, DataStoreTypeMax>::generate(|_| RefCell::new(Box::new(NullDataStore {}))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1154:47 [INFO] [stdout] | [INFO] [stdout] 1152 | let store = DataStore::::new(self.source_manager.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1153 | [INFO] [stdout] 1154 | self.register_boxed_type(wanted_type, Box::new(store)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1378:12 [INFO] [stdout] | [INFO] [stdout] 1368 | pub fn new(data_store : &mut DataStore, data_preparer : Box>) -> Result, PreparedStoreE... [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1378 | Ok(PreparedStore:: [INFO] [stdout] | ____________^ [INFO] [stdout] 1379 | | { [INFO] [stdout] 1380 | | data_list : Vec::new(), [INFO] [stdout] 1381 | | data_preparer, [INFO] [stdout] 1382 | | prepare_info [INFO] [stdout] 1383 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:197:23 [INFO] [stdout] | [INFO] [stdout] 190 | fn new

>(basepath : P) -> FilesystemIter [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | walkdir : WalkDir::new(path).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 338 | let file = BufReader::new(File::open(path).map_err( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | Ok(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 358 | let file = BufWriter::new(File::create(path).map_err( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keeshond_datapack` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "e12edf86b9301d353beb62b629732d612faf8fcf80257220ae8d4c1274b69337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e12edf86b9301d353beb62b629732d612faf8fcf80257220ae8d4c1274b69337", kill_on_drop: false }` [INFO] [stdout] e12edf86b9301d353beb62b629732d612faf8fcf80257220ae8d4c1274b69337