[INFO] fetching crate keep 0.1.0... [INFO] checking keep-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate keep 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate keep 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate keep 0.1.0 [INFO] finished tweaking crates.io crate keep 0.1.0 [INFO] tweaked toml for crates.io crate keep 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding error-chain v0.11.0 (latest: v0.12.4) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding git2 v0.7.5 (latest: v0.19.0) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding libgit2-sys v0.7.11 (latest: v0.17.0+1.8.1) [INFO] [stderr] Adding libssh2-sys v0.2.23 (latest: v0.3.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b6b547a8dcac2d8ee0ab8a787de89079d9964388a1ac6afdc47e1dee70ca12f [INFO] running `Command { std: "docker" "start" "-a" "7b6b547a8dcac2d8ee0ab8a787de89079d9964388a1ac6afdc47e1dee70ca12f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b6b547a8dcac2d8ee0ab8a787de89079d9964388a1ac6afdc47e1dee70ca12f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b6b547a8dcac2d8ee0ab8a787de89079d9964388a1ac6afdc47e1dee70ca12f", kill_on_drop: false }` [INFO] [stdout] 7b6b547a8dcac2d8ee0ab8a787de89079d9964388a1ac6afdc47e1dee70ca12f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7162a61e694c4a5a5d0f89186b0319d02c8f93870248489698a5adb0551ffc1 [INFO] running `Command { std: "docker" "start" "-a" "b7162a61e694c4a5a5d0f89186b0319d02c8f93870248489698a5adb0551ffc1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling curl-sys v0.4.74+curl-8.9.0 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking keep v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / error_chain!{ [INFO] [stdout] 11 | | foreign_links{ [INFO] [stdout] 12 | | Git(::git2::Error); [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / error_chain!{ [INFO] [stdout] 11 | | foreign_links{ [INFO] [stdout] 12 | | Git(::git2::Error); [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / error_chain!{ [INFO] [stdout] 11 | | foreign_links{ [INFO] [stdout] 12 | | Git(::git2::Error); [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | / error_chain!{ [INFO] [stdout] 11 | | foreign_links{ [INFO] [stdout] 12 | | Git(::git2::Error); [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference` [INFO] [stdout] --> src/lib.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | let reference = Some("HEAD"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 26 | let repo = match Repository::open(path) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | { [INFO] [stdout] 28 | Ok(repo) => repo, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(Backup { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | repo: repo, [INFO] [stdout] 39 | | last_commit: None, [INFO] [stdout] 40 | | previous_commit: None, [INFO] [stdout] 41 | | new: new [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 142 | let obj = self.repo.head()?.resolve()?.peel(ObjectType::Commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Ok(obj.into_commit().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference` [INFO] [stdout] --> src/lib.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | let reference = Some("HEAD"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | let src = Path::new("samples"); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keep` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 26 | let repo = match Repository::open(path) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | { [INFO] [stdout] 28 | Ok(repo) => repo, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(Backup { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | repo: repo, [INFO] [stdout] 39 | | last_commit: None, [INFO] [stdout] 40 | | previous_commit: None, [INFO] [stdout] 41 | | new: new [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 142 | let obj = self.repo.head()?.resolve()?.peel(ObjectType::Commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Ok(obj.into_commit().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 200 | let git_dir = tempdir::TempDir::new("git_dirty").unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut backup = Backup::new(&dst).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | match backup.merge_files() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:244:15 [INFO] [stdout] | [INFO] [stdout] 224 | let git_dir = tempdir::TempDir::new("git_dirty").unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let mut backup = Backup::new(&dst).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | match backup.merge_files() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:15 [INFO] [stdout] | [INFO] [stdout] 252 | let git_dir = tempdir::TempDir::new("git_dirty").unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let mut backup = Backup::new(&dst).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | match backup.merge_files() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `keep` (lib test) due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b7162a61e694c4a5a5d0f89186b0319d02c8f93870248489698a5adb0551ffc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7162a61e694c4a5a5d0f89186b0319d02c8f93870248489698a5adb0551ffc1", kill_on_drop: false }` [INFO] [stdout] b7162a61e694c4a5a5d0f89186b0319d02c8f93870248489698a5adb0551ffc1