[INFO] fetching crate kdd 0.1.9... [INFO] checking kdd-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kdd 0.1.9 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate kdd 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kdd 0.1.9 [INFO] finished tweaking crates.io crate kdd 0.1.9 [INFO] tweaked toml for crates.io crate kdd 0.1.9 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate kdd 0.1.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 15e7d06e5cd6523ba83b117036e69d00e5d2bdaa1a4c4265ba33f79fd1457122 [INFO] running `Command { std: "docker" "start" "-a" "15e7d06e5cd6523ba83b117036e69d00e5d2bdaa1a4c4265ba33f79fd1457122", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "15e7d06e5cd6523ba83b117036e69d00e5d2bdaa1a4c4265ba33f79fd1457122", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15e7d06e5cd6523ba83b117036e69d00e5d2bdaa1a4c4265ba33f79fd1457122", kill_on_drop: false }` [INFO] [stdout] 15e7d06e5cd6523ba83b117036e69d00e5d2bdaa1a4c4265ba33f79fd1457122 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bf7b549c4ab9377f6435b615f04c7f351c44f6ae85dd1ef3403f2a7b22e168f [INFO] running `Command { std: "docker" "start" "-a" "5bf7b549c4ab9377f6435b615f04c7f351c44f6ae85dd1ef3403f2a7b22e168f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling ucd-trie v0.1.4 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling serde v1.0.139 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling rustversion v1.0.8 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling tokio v1.20.0 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking clap v3.2.12 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling strum_macros v0.24.2 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking handlebars v4.3.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking kdd v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdd/builder.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 195 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | match proc.spawn() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdd/loader.rs:99:6 [INFO] [stdout] | [INFO] [stdout] 24 | let hbs: Handlebars = Handlebars::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let kdd_part = parse_kdd_part(&dir, &kdd_yaml_txt, &mut root_vars, &hbs, &None)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | kdd_yaml, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | blocks, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | realm_base, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut realms = kdd_part.realms; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let kdd_config = KddConfig { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(Kdd::from(kdd_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdd/loader.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 174 | Err(e) => return Err(KddError::KdevFailToParseInvalid(e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | }; [INFO] [stdout] 176 | let mut kdd_yaml = YamlLoader::load_from_str(&rendered_yaml)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | [INFO] [stdout] 178 | let kdd_yaml = kdd_yaml.remove(0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let blocks = parse_blocks(&kdd_yaml["blocks"]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let (realm_base, realms) = parse_realms(dir, &kdd_yaml["realms"], realm_root_base); [INFO] [stdout] | ---------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | Ok(KddPart { [INFO] [stdout] | ________^ [INFO] [stdout] 205 | | system, [INFO] [stdout] 206 | | blocks, [INFO] [stdout] 207 | | realms, [INFO] [stdout] ... | [INFO] [stdout] 211 | | kdd_yaml, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 46 | let mut proc = Command::new(cmd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match exec_proc(&mut proc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 70 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | match proc.stdout(Stdio::piped()).output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdd/builder.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 195 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | match proc.spawn() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdd/loader.rs:99:6 [INFO] [stdout] | [INFO] [stdout] 24 | let hbs: Handlebars = Handlebars::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let kdd_part = parse_kdd_part(&dir, &kdd_yaml_txt, &mut root_vars, &hbs, &None)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | kdd_yaml, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | blocks, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | realm_base, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut realms = kdd_part.realms; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let kdd_config = KddConfig { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(Kdd::from(kdd_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdd/loader.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 174 | Err(e) => return Err(KddError::KdevFailToParseInvalid(e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | }; [INFO] [stdout] 176 | let mut kdd_yaml = YamlLoader::load_from_str(&rendered_yaml)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | [INFO] [stdout] 178 | let kdd_yaml = kdd_yaml.remove(0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let blocks = parse_blocks(&kdd_yaml["blocks"]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let (realm_base, realms) = parse_realms(dir, &kdd_yaml["realms"], realm_root_base); [INFO] [stdout] | ---------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | Ok(KddPart { [INFO] [stdout] | ________^ [INFO] [stdout] 205 | | system, [INFO] [stdout] 206 | | blocks, [INFO] [stdout] 207 | | realms, [INFO] [stdout] ... | [INFO] [stdout] 211 | | kdd_yaml, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 46 | let mut proc = Command::new(cmd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match exec_proc(&mut proc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 70 | let mut proc = Command::new(&cmd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | match proc.stdout(Stdio::piped()).output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kdd` (bin "kdd") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kdd` (bin "kdd" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "5bf7b549c4ab9377f6435b615f04c7f351c44f6ae85dd1ef3403f2a7b22e168f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bf7b549c4ab9377f6435b615f04c7f351c44f6ae85dd1ef3403f2a7b22e168f", kill_on_drop: false }` [INFO] [stdout] 5bf7b549c4ab9377f6435b615f04c7f351c44f6ae85dd1ef3403f2a7b22e168f