[INFO] fetching crate kcapi 0.1.6... [INFO] checking kcapi-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kcapi 0.1.6 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate kcapi 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kcapi 0.1.6 [INFO] finished tweaking crates.io crate kcapi 0.1.6 [INFO] tweaked toml for crates.io crate kcapi 0.1.6 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.53.3 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cexpr v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clang-sys v0.29.3 (latest: v1.8.1) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding libloading v0.5.2 (latest: v0.8.5) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding which v3.1.1 (latest: v6.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af27e57df6cc8d1bbd55ae784fe637b12e8184650488406de9eee514de53bc93 [INFO] running `Command { std: "docker" "start" "-a" "af27e57df6cc8d1bbd55ae784fe637b12e8184650488406de9eee514de53bc93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af27e57df6cc8d1bbd55ae784fe637b12e8184650488406de9eee514de53bc93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af27e57df6cc8d1bbd55ae784fe637b12e8184650488406de9eee514de53bc93", kill_on_drop: false }` [INFO] [stdout] af27e57df6cc8d1bbd55ae784fe637b12e8184650488406de9eee514de53bc93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6edc178c0397553c422f23b69e4ffa0fecdaeae02858c43ec90afa7693e8bf9d [INFO] running `Command { std: "docker" "start" "-a" "6edc178c0397553c422f23b69e4ffa0fecdaeae02858c43ec90afa7693e8bf9d", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling clang-sys v0.29.3 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling bindgen v0.53.3 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling autotools v0.2.7 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Compiling kcapi-sys v1.4.1 [INFO] [stderr] Checking kcapi v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aead.rs:404:12 [INFO] [stdout] | [INFO] [stdout] 363 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | Ok(KcapiAEAD { [INFO] [stdout] | ____________^ [INFO] [stdout] 405 | | handle, [INFO] [stdout] 406 | | iv: Vec::new(), [INFO] [stdout] 407 | | key: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 416 | | outbuflen: 0, [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/akcipher.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 123 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(KcapiAKCipher { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | algorithm: algorithm.to_string(), [INFO] [stdout] 139 | | handle, [INFO] [stdout] 140 | | modsize: 0, [INFO] [stdout] 141 | | pubkey, [INFO] [stdout] 142 | | privkey, [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdf.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 114 | let alg = CString::new(algorithm).expect("Failed to allocate Cstring"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(KcapiKDF { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | digestsize, [INFO] [stdout] 143 | | handle, [INFO] [stdout] 144 | | iteration_count, [INFO] [stdout] 145 | | key, [INFO] [stdout] 146 | | algorithm: algorithm.to_string(), [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/md.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 134 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | Ok(KcapiHash { [INFO] [stdout] | ____________^ [INFO] [stdout] 172 | | handle, [INFO] [stdout] 173 | | key, [INFO] [stdout] 174 | | algorithm: algorithm.to_string(), [INFO] [stdout] 175 | | blocksize, [INFO] [stdout] 176 | | digestsize, [INFO] [stdout] 177 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rng.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 112 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(KcapiRNG { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | handle, [INFO] [stdout] 134 | | algorithm: algorithm.to_string(), [INFO] [stdout] 135 | | seedsize, [INFO] [stdout] 136 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/skcipher.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 146 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(KcapiSKCipher { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | handle, [INFO] [stdout] 179 | | key, [INFO] [stdout] 180 | | iv, [INFO] [stdout] ... | [INFO] [stdout] 186 | | invec, [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kcapi` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aead.rs:404:12 [INFO] [stdout] | [INFO] [stdout] 363 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | Ok(KcapiAEAD { [INFO] [stdout] | ____________^ [INFO] [stdout] 405 | | handle, [INFO] [stdout] 406 | | iv: Vec::new(), [INFO] [stdout] 407 | | key: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 416 | | outbuflen: 0, [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/akcipher.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 123 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(KcapiAKCipher { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | algorithm: algorithm.to_string(), [INFO] [stdout] 139 | | handle, [INFO] [stdout] 140 | | modsize: 0, [INFO] [stdout] 141 | | pubkey, [INFO] [stdout] 142 | | privkey, [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kdf.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 114 | let alg = CString::new(algorithm).expect("Failed to allocate Cstring"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(KcapiKDF { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | digestsize, [INFO] [stdout] 143 | | handle, [INFO] [stdout] 144 | | iteration_count, [INFO] [stdout] 145 | | key, [INFO] [stdout] 146 | | algorithm: algorithm.to_string(), [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/md.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 134 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | Ok(KcapiHash { [INFO] [stdout] | ____________^ [INFO] [stdout] 172 | | handle, [INFO] [stdout] 173 | | key, [INFO] [stdout] 174 | | algorithm: algorithm.to_string(), [INFO] [stdout] 175 | | blocksize, [INFO] [stdout] 176 | | digestsize, [INFO] [stdout] 177 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rng.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 112 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(KcapiRNG { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | handle, [INFO] [stdout] 134 | | algorithm: algorithm.to_string(), [INFO] [stdout] 135 | | seedsize, [INFO] [stdout] 136 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/skcipher.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 146 | let alg = CString::new(algorithm).expect("Failed to create CString"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(KcapiSKCipher { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | handle, [INFO] [stdout] 179 | | key, [INFO] [stdout] 180 | | iv, [INFO] [stdout] ... | [INFO] [stdout] 186 | | invec, [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kcapi` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "6edc178c0397553c422f23b69e4ffa0fecdaeae02858c43ec90afa7693e8bf9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6edc178c0397553c422f23b69e4ffa0fecdaeae02858c43ec90afa7693e8bf9d", kill_on_drop: false }` [INFO] [stdout] 6edc178c0397553c422f23b69e4ffa0fecdaeae02858c43ec90afa7693e8bf9d