[INFO] fetching crate kbs2 0.7.3-rc.1... [INFO] checking kbs2-0.7.3-rc.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kbs2 0.7.3-rc.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate kbs2 0.7.3-rc.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kbs2 0.7.3-rc.1 [INFO] finished tweaking crates.io crate kbs2 0.7.3-rc.1 [INFO] tweaked toml for crates.io crate kbs2 0.7.3-rc.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate kbs2 0.7.3-rc.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18ab7a9604203b51c9f0e678b1de091beae7c54ad80b4cd05d6e1657c35baf30 [INFO] running `Command { std: "docker" "start" "-a" "18ab7a9604203b51c9f0e678b1de091beae7c54ad80b4cd05d6e1657c35baf30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18ab7a9604203b51c9f0e678b1de091beae7c54ad80b4cd05d6e1657c35baf30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18ab7a9604203b51c9f0e678b1de091beae7c54ad80b4cd05d6e1657c35baf30", kill_on_drop: false }` [INFO] [stdout] 18ab7a9604203b51c9f0e678b1de091beae7c54ad80b4cd05d6e1657c35baf30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7d4fd496aadbbe79c203bb81296e99d59b365d9bf02eac134641cb10c73a385 [INFO] running `Command { std: "docker" "start" "-a" "a7d4fd496aadbbe79c203bb81296e99d59b365d9bf02eac134641cb10c73a385", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling syn v1.0.104 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.179 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling serde_derive v1.0.179 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling tinystr v0.3.4 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling opaque-debug v0.3.0 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking unic-langid-impl v0.9.0 [INFO] [stderr] Compiling walkdir v2.3.2 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking unic-langid v0.9.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling type-map v0.4.0 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Compiling block-buffer v0.9.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Compiling sha2 v0.9.9 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling rust-embed-utils v7.2.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling self_cell v0.10.2 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking intl-memoizer v0.5.1 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking universal-hash v0.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking intl_pluralrules v7.0.1 [INFO] [stderr] Checking fluent-langneg v0.13.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstream v0.3.1 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Compiling find-crate v0.6.3 [INFO] [stderr] Checking aead v0.5.1 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking equivalent v1.0.0 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling hashbrown v0.12.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking clap_builder v4.3.12 [INFO] [stderr] Checking png v0.17.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling dashmap v5.3.4 [INFO] [stderr] Checking hkdf v0.12.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking gethostname v0.2.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking winnow v0.4.6 [INFO] [stderr] Checking bytemuck v1.12.2 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling zeroize_derive v1.3.2 [INFO] [stderr] Compiling rust-embed-impl v6.2.0 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Compiling rust-embed v6.4.0 [INFO] [stderr] Checking cipher v0.4.3 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking io_tee v0.1.1 [INFO] [stderr] Checking chacha20 v0.9.0 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking cookie-factory v0.3.2 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking x11rb-protocol v0.10.0 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking x25519-dalek v1.1.1 [INFO] [stderr] Checking age-core v0.9.0 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Compiling fluent-syntax v0.11.0 [INFO] [stderr] Compiling i18n-config v0.4.2 [INFO] [stderr] Checking toml_edit v0.19.12 [INFO] [stderr] Checking image v0.24.4 [INFO] [stderr] Compiling fluent-bundle v0.15.2 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking fluent v0.16.0 [INFO] [stderr] Checking clap v4.3.12 [INFO] [stderr] Checking scrypt v0.10.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling i18n-embed-impl v0.8.0 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling i18n-embed v0.13.4 [INFO] [stderr] Checking which v4.2.5 [INFO] [stderr] Compiling kbs2 v0.7.3-rc.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking dyn-clone v1.0.9 [INFO] [stderr] Checking newline-converter v0.2.0 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking anstyle v0.3.5 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling i18n-embed-fl v0.6.4 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking termtree v0.2.4 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking predicates-tree v1.0.5 [INFO] [stderr] Checking tempfile v3.7.0 [INFO] [stderr] Checking bstr v1.0.1 [INFO] [stderr] Checking predicates v3.0.1 [INFO] [stderr] Checking inquire v0.6.2 [INFO] [stderr] Checking pinentry v0.5.0 [INFO] [stderr] Checking age v0.9.2 [INFO] [stderr] Checking toml v0.7.6 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking clap_complete v4.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rpassword v7.1.0 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking whoami v1.4.1 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking x11rb v0.10.1 [INFO] [stderr] Checking arboard v3.2.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:430:11 [INFO] [stdout] | [INFO] [stdout] 400 | let mut app = app(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | let matches = app.clone().get_matches(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | match run(&matches, &config) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/agent.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 401 | let stream = UnixStream::connect(Agent::path()) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | .with_context(|| "failed to connect to agent; is it running?")?; [INFO] [stdout] 403 | Ok(Self { stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 66 | let identities = if config.wrapped { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let client = agent::Client::new().with_context(|| "failed to connect to kbs2 agent")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let identities = identities [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(RageLib { pubkey, identities }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 128 | fn unwrap_keyfile>(keyfile: P, password: SecretString) -> Result { [INFO] [stdout] | ---------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let decryptor = match Decryptor::new(ArmoredReader::new(wrapped_key.as_slice())) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | Ok(Decryptor::Passphrase(d)) => d, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(_) => { [INFO] [stdout] 135 | return Err(anyhow!( [INFO] [stdout] | ____________________________- [INFO] [stdout] 136 | | "key unwrap failed; not a password-wrapped keyfile?" [INFO] [stdout] 137 | | )); [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | } [INFO] [stdout] 139 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(SecretString::new(unwrapped_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 157 | .and_then(|mut r| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | r.read_to_string(&mut unwrapped_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 224 | .and_then(|mut r| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | r.read_to_string(&mut decrypted) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/session.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 93 | match self.backend.decrypt(&record_contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:430:11 [INFO] [stdout] | [INFO] [stdout] 400 | let mut app = app(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | let matches = app.clone().get_matches(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | match run(&matches, &config) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/agent.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 401 | let stream = UnixStream::connect(Agent::path()) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | .with_context(|| "failed to connect to agent; is it running?")?; [INFO] [stdout] 403 | Ok(Self { stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kbs2` (bin "kbs2") due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 66 | let identities = if config.wrapped { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let client = agent::Client::new().with_context(|| "failed to connect to kbs2 agent")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let identities = identities [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(RageLib { pubkey, identities }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 128 | fn unwrap_keyfile>(keyfile: P, password: SecretString) -> Result { [INFO] [stdout] | ---------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let decryptor = match Decryptor::new(ArmoredReader::new(wrapped_key.as_slice())) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | Ok(Decryptor::Passphrase(d)) => d, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(_) => { [INFO] [stdout] 135 | return Err(anyhow!( [INFO] [stdout] | ____________________________- [INFO] [stdout] 136 | | "key unwrap failed; not a password-wrapped keyfile?" [INFO] [stdout] 137 | | )); [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | } [INFO] [stdout] 139 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(SecretString::new(unwrapped_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 157 | .and_then(|mut r| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | r.read_to_string(&mut unwrapped_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/backend.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 224 | .and_then(|mut r| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | r.read_to_string(&mut decrypted) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbs2/session.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 93 | match self.backend.decrypt(&record_contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kbs2` (bin "kbs2" test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "a7d4fd496aadbbe79c203bb81296e99d59b365d9bf02eac134641cb10c73a385", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7d4fd496aadbbe79c203bb81296e99d59b365d9bf02eac134641cb10c73a385", kill_on_drop: false }` [INFO] [stdout] a7d4fd496aadbbe79c203bb81296e99d59b365d9bf02eac134641cb10c73a385