[INFO] fetching crate kaspa-core 0.13.4... [INFO] checking kaspa-core-0.13.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kaspa-core 0.13.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate kaspa-core 0.13.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kaspa-core 0.13.4 [INFO] finished tweaking crates.io crate kaspa-core 0.13.4 [INFO] tweaked toml for crates.io crate kaspa-core 0.13.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 124 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding destructure_traitobject v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding js-sys v0.3.64 (latest: v0.3.70) [INFO] [stderr] Adding linkme v0.2.10 (latest: v0.3.28) [INFO] [stderr] Adding linkme-impl v0.2.10 (latest: v0.3.28) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasm-bindgen v0.2.87 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-backend v0.2.87 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro v0.2.87 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro-support v0.2.87 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-shared v0.2.87 (latest: v0.2.93) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding workflow-log v0.10.3 (latest: v0.17.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 681c971a0d9ab3be86c3eb34bf66ae4f4f7c6227d34d7cb13dd04932be258e16 [INFO] running `Command { std: "docker" "start" "-a" "681c971a0d9ab3be86c3eb34bf66ae4f4f7c6227d34d7cb13dd04932be258e16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "681c971a0d9ab3be86c3eb34bf66ae4f4f7c6227d34d7cb13dd04932be258e16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "681c971a0d9ab3be86c3eb34bf66ae4f4f7c6227d34d7cb13dd04932be258e16", kill_on_drop: false }` [INFO] [stdout] 681c971a0d9ab3be86c3eb34bf66ae4f4f7c6227d34d7cb13dd04932be258e16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3eb3c278994a749317e963f94ffbbc73a0fb71943a950ee253533e14d68bee96 [INFO] running `Command { std: "docker" "start" "-a" "3eb3c278994a749317e963f94ffbbc73a0fb71943a950ee253533e14d68bee96", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.87 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.87 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling linkme-impl v0.2.10 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking hexplay v0.3.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.87 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking triggered v0.1.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking linkme v0.2.10 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Compiling uuid v0.8.2 [INFO] [stderr] Compiling intertrait-macros v0.2.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.87 [INFO] [stderr] Checking intertrait v0.2.2 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.87 [INFO] [stderr] Checking workflow-log v0.10.3 [INFO] [stderr] Checking kaspa-core v0.13.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/appender.rs:60:37 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(name: &'static str, level: Option, append: Box) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { name, level, append: Some(append) } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/appender.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 65 | .filters(self.level.map(|x| Box::new(ThresholdFilter::new(x)) as Box)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:31:55 [INFO] [stdout] | [INFO] [stdout] 31 | self.services.lock().unwrap().iter().find(|s| (*s).clone().ident() == ident).cloned() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/runtime.rs:56:54 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn worker(self: &Arc, core: Arc) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .block_on(async { self.worker_impl(core).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/runtime.rs:78:35 [INFO] [stdout] | [INFO] [stdout] 78 | .map(|x| tokio::spawn(x.clone().start())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/runtime.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|x| tokio::spawn(x.clone().stop())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/tick.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 54 | fn start(self: Arc) -> AsyncServiceFuture { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Box::pin(async move { Ok(()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/tick.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 62 | fn stop(self: Arc) -> AsyncServiceFuture { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Box::pin(async move { Ok(()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kaspa-core` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/appender.rs:60:37 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(name: &'static str, level: Option, append: Box) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { name, level, append: Some(append) } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/appender.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 65 | .filters(self.level.map(|x| Box::new(ThresholdFilter::new(x)) as Box)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:31:55 [INFO] [stdout] | [INFO] [stdout] 31 | self.services.lock().unwrap().iter().find(|s| (*s).clone().ident() == ident).cloned() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/runtime.rs:56:54 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn worker(self: &Arc, core: Arc) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .block_on(async { self.worker_impl(core).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/runtime.rs:78:35 [INFO] [stdout] | [INFO] [stdout] 78 | .map(|x| tokio::spawn(x.clone().start())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/runtime.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|x| tokio::spawn(x.clone().stop())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/tick.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 54 | fn start(self: Arc) -> AsyncServiceFuture { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Box::pin(async move { Ok(()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/tick.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 62 | fn stop(self: Arc) -> AsyncServiceFuture { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Box::pin(async move { Ok(()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kaspa-core` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "3eb3c278994a749317e963f94ffbbc73a0fb71943a950ee253533e14d68bee96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3eb3c278994a749317e963f94ffbbc73a0fb71943a950ee253533e14d68bee96", kill_on_drop: false }` [INFO] [stdout] 3eb3c278994a749317e963f94ffbbc73a0fb71943a950ee253533e14d68bee96