[INFO] fetching crate karsher 0.9.0... [INFO] checking karsher-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate karsher 0.9.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate karsher 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate karsher 0.9.0 [INFO] finished tweaking crates.io crate karsher 0.9.0 [INFO] tweaked toml for crates.io crate karsher 0.9.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate karsher 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d052c25215d7b268e6a6ae26b36a786157c810dcad82eb1b2c80772ba0212f9d [INFO] running `Command { std: "docker" "start" "-a" "d052c25215d7b268e6a6ae26b36a786157c810dcad82eb1b2c80772ba0212f9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d052c25215d7b268e6a6ae26b36a786157c810dcad82eb1b2c80772ba0212f9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d052c25215d7b268e6a6ae26b36a786157c810dcad82eb1b2c80772ba0212f9d", kill_on_drop: false }` [INFO] [stdout] d052c25215d7b268e6a6ae26b36a786157c810dcad82eb1b2c80772ba0212f9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ef35d17b5d69cc45dd8c39c2259d088dc6af84e3bb97f6012ad8827d1667a69 [INFO] running `Command { std: "docker" "start" "-a" "7ef35d17b5d69cc45dd8c39c2259d088dc6af84e3bb97f6012ad8827d1667a69", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling io-lifetimes v0.6.1 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling rustversion v1.0.7 [INFO] [stderr] Compiling rustix v0.34.7 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking slab_tree v0.3.2 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.24.1 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking ctrlc v3.2.2 [INFO] [stderr] Checking fd-lock v3.0.5 [INFO] [stderr] Compiling strum_macros v0.24.0 [INFO] [stderr] Compiling rustyline-derive v0.6.0 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking rustyline v9.1.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking karsher v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `eof` and `none_of` [INFO] [stdout] --> src/prelude.rs:8:72 [INFO] [stdout] | [INFO] [stdout] 8 | alpha1, alphanumeric1, i128 as I128, multispace0, multispace1, none_of, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 11 | combinator::{all_consuming, cut, eof, map, map_parser, opt, rest, verify}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::stdout` [INFO] [stdout] --> src/prelude.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use std::io::stdout; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicBool`, `Ordering`, `path::PathBuf`, and `process::ExitCode` [INFO] [stdout] --> src/prelude.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 39 | process::ExitCode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | sync::atomic::{AtomicBool, Ordering}, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `eof` and `none_of` [INFO] [stdout] --> src/prelude.rs:8:72 [INFO] [stdout] | [INFO] [stdout] 8 | alpha1, alphanumeric1, i128 as I128, multispace0, multispace1, none_of, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 11 | combinator::{all_consuming, cut, eof, map, map_parser, opt, rest, verify}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::stdout` [INFO] [stdout] --> src/prelude.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use std::io::stdout; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/prelude.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicBool`, `Ordering`, `path::PathBuf`, and `process::ExitCode` [INFO] [stdout] --> src/prelude.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 39 | process::ExitCode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | sync::atomic::{AtomicBool, Ordering}, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `open_tree_and_apply` is never used [INFO] [stdout] --> src/db/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub trait DbOp: Op { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 79 | fn open_tree_and_apply( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MyString` is never constructed [INFO] [stdout] --> src/db/database.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 137 | struct MyString(String); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:11 [INFO] [stdout] | [INFO] [stdout] 34 | let config = if args.is_empty() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | match Db::open(config) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | |s| alt((tag_no_case(BACKUP_ALT), tag_no_case(BACKUP)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | |s| alt((tag_no_case(DESCRIBE), tag_no_case(DESCRIBE_ALT)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | |s| alt((tag_no_case(CURR_CACHE_ALT), tag_no_case(CURR_CACHE)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | |s| alt((tag_no_case(CLEAR), tag_no_case(CLEAR_ALT)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | |s| alt((tag_no_case(LIST_CACHE), tag_no_case(LIST_CACHE_ALT)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 192 | parser: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | mapper: M, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | / map( [INFO] [stdout] 201 | | preceded( [INFO] [stdout] 202 | | &parser, [INFO] [stdout] 203 | | verify(rest, |s: &str| s.trim().is_empty() || s == "\n"), [INFO] [stdout] 204 | | ), [INFO] [stdout] 205 | | &mapper, [INFO] [stdout] 206 | | )(s) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 209 | fn extract_key<'a, F>(parser: F) -> impl Fn(&'a str) -> Res<&'a str> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | / preceded( [INFO] [stdout] 215 | | &parser, [INFO] [stdout] 216 | | preceded( [INFO] [stdout] 217 | | multispace1, [INFO] [stdout] ... | [INFO] [stdout] 221 | | ), [INFO] [stdout] 222 | | )(s) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/compute.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 90 | let (rest, value) = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | std::panic::catch_unwind(AssertUnwindSafe(|| compute_recur(root, ctx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/number.rs:11:52 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, PartialEq, Clone, Copy, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | move |s: &str| delimited(multispace0, tag(t), multispace0)(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | move |s: &str| delimited(multispace0, tag_no_case(t), multispace0)(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:73:57 [INFO] [stdout] | [INFO] [stdout] 72 | map(preceded(tag_no_space_no_case(fn_name), parse_paren), |expr| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Value::BuiltInFunction { fn_type, expr: Box::new(expr) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | move |s| map(tag_no_space(sep), |_| Value::Operation(operation))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:161:31 [INFO] [stdout] | [INFO] [stdout] 160 | |(name, expr)| Value::VariableExpr { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | name: Box::new(name), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:162:31 [INFO] [stdout] | [INFO] [stdout] 160 | |(name, expr)| Value::VariableExpr { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | name: Box::new(name), [INFO] [stdout] 162 | expr: Box::new(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:30:31 [INFO] [stdout] | [INFO] [stdout] 30 | self.read(k, |v| Some(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 36 | k: impl Into, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | r: impl Fn(&V) -> Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Option { [INFO] [stdout] 39 | self.read(k.into(), |v| { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/database.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn in_memory_fallback(e: anyhow::Error) -> anyhow::Result> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(Db::InMemory(Default::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_db.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 122 | fn apply_batch(&mut self, batch: super::Batch) -> Option<()> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | self.update(|mut guard| guard.apply_batch(batch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_db.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 141 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.update(move |mut guard| guard.insert(k, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_db.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 145 | fn remove(&mut self, k: impl Into) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | self.update(move |mut guard| guard.remove(k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_lock.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(FileLock { _lock_p, inner_p }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 37 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | self.apply_to_current_tree(move |tree| tree.insert(k, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:42:36 [INFO] [stdout] | [INFO] [stdout] 41 | fn remove(&mut self, k: impl Into) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.apply_to_current_tree(move |tree| tree.remove(k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:150:49 [INFO] [stdout] | [INFO] [stdout] 150 | dest.extend(source.iter().map(|(k, v)| (k.clone(), v.clone()))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:150:60 [INFO] [stdout] | [INFO] [stdout] 150 | dest.extend(source.iter().map(|(k, v)| (k.clone(), v.clone()))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:217:46 [INFO] [stdout] | [INFO] [stdout] 217 | let value = db.read("baba", |v| Some(v.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/tree.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 40 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.0.insert(k.into(), v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/tree.rs:41:33 [INFO] [stdout] | [INFO] [stdout] 40 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.0.insert(k.into(), v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/tree.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 44 | fn remove(&mut self, k: impl Into) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | self.0.remove(&k.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 23 | history_path: Option>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | ) -> anyhow::Result<()> { [INFO] [stdout] 25 | let history_path = history_path [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | rl.save_history(history_path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `karsher` (bin "karsher" test) due to 33 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `read_no_op` is never used [INFO] [stdout] --> src/db/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub trait Op { [INFO] [stdout] | -- method in this trait [INFO] [stdout] ... [INFO] [stdout] 34 | fn read_no_op( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `open_tree_and_apply` is never used [INFO] [stdout] --> src/db/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub trait DbOp: Op { [INFO] [stdout] | ---- method in this trait [INFO] [stdout] ... [INFO] [stdout] 79 | fn open_tree_and_apply( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:11 [INFO] [stdout] | [INFO] [stdout] 34 | let config = if args.is_empty() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | match Db::open(config) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | |s| alt((tag_no_case(BACKUP_ALT), tag_no_case(BACKUP)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | |s| alt((tag_no_case(DESCRIBE), tag_no_case(DESCRIBE_ALT)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | |s| alt((tag_no_case(CURR_CACHE_ALT), tag_no_case(CURR_CACHE)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | |s| alt((tag_no_case(CLEAR), tag_no_case(CLEAR_ALT)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | |s| alt((tag_no_case(LIST_CACHE), tag_no_case(LIST_CACHE_ALT)))(s), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 192 | parser: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | mapper: M, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | / map( [INFO] [stdout] 201 | | preceded( [INFO] [stdout] 202 | | &parser, [INFO] [stdout] 203 | | verify(rest, |s: &str| s.trim().is_empty() || s == "\n"), [INFO] [stdout] 204 | | ), [INFO] [stdout] 205 | | &mapper, [INFO] [stdout] 206 | | )(s) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_command/parser.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 209 | fn extract_key<'a, F>(parser: F) -> impl Fn(&'a str) -> Res<&'a str> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | / preceded( [INFO] [stdout] 215 | | &parser, [INFO] [stdout] 216 | | preceded( [INFO] [stdout] 217 | | multispace1, [INFO] [stdout] ... | [INFO] [stdout] 221 | | ), [INFO] [stdout] 222 | | )(s) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/compute.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 90 | let (rest, value) = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | std::panic::catch_unwind(AssertUnwindSafe(|| compute_recur(root, ctx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/number.rs:11:52 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, PartialEq, Clone, Copy, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | move |s: &str| delimited(multispace0, tag(t), multispace0)(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | move |s: &str| delimited(multispace0, tag_no_case(t), multispace0)(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:73:57 [INFO] [stdout] | [INFO] [stdout] 72 | map(preceded(tag_no_space_no_case(fn_name), parse_paren), |expr| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Value::BuiltInFunction { fn_type, expr: Box::new(expr) } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | move |s| map(tag_no_space(sep), |_| Value::Operation(operation))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:161:31 [INFO] [stdout] | [INFO] [stdout] 160 | |(name, expr)| Value::VariableExpr { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | name: Box::new(name), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/calculator/parser.rs:162:31 [INFO] [stdout] | [INFO] [stdout] 160 | |(name, expr)| Value::VariableExpr { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | name: Box::new(name), [INFO] [stdout] 162 | expr: Box::new(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:30:31 [INFO] [stdout] | [INFO] [stdout] 30 | self.read(k, |v| Some(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 36 | k: impl Into, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | r: impl Fn(&V) -> Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Option { [INFO] [stdout] 39 | self.read(k.into(), |v| { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/database.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn in_memory_fallback(e: anyhow::Error) -> anyhow::Result> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(Db::InMemory(Default::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_db.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 122 | fn apply_batch(&mut self, batch: super::Batch) -> Option<()> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | self.update(|mut guard| guard.apply_batch(batch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_db.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 141 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.update(move |mut guard| guard.insert(k, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_db.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 145 | fn remove(&mut self, k: impl Into) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | self.update(move |mut guard| guard.remove(k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/file_lock.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(FileLock { _lock_p, inner_p }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 37 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | self.apply_to_current_tree(move |tree| tree.insert(k, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:42:36 [INFO] [stdout] | [INFO] [stdout] 41 | fn remove(&mut self, k: impl Into) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.apply_to_current_tree(move |tree| tree.remove(k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:150:49 [INFO] [stdout] | [INFO] [stdout] 150 | dest.extend(source.iter().map(|(k, v)| (k.clone(), v.clone()))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/in_memory.rs:150:60 [INFO] [stdout] | [INFO] [stdout] 150 | dest.extend(source.iter().map(|(k, v)| (k.clone(), v.clone()))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/tree.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 40 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.0.insert(k.into(), v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/tree.rs:41:33 [INFO] [stdout] | [INFO] [stdout] 40 | fn insert(&mut self, k: impl Into, v: impl Into) -> Option { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | self.0.insert(k.into(), v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/tree.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 44 | fn remove(&mut self, k: impl Into) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | self.0.remove(&k.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 23 | history_path: Option>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | ) -> anyhow::Result<()> { [INFO] [stdout] 25 | let history_path = history_path [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | rl.save_history(history_path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `karsher` (bin "karsher") due to 32 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7ef35d17b5d69cc45dd8c39c2259d088dc6af84e3bb97f6012ad8827d1667a69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ef35d17b5d69cc45dd8c39c2259d088dc6af84e3bb97f6012ad8827d1667a69", kill_on_drop: false }` [INFO] [stdout] 7ef35d17b5d69cc45dd8c39c2259d088dc6af84e3bb97f6012ad8827d1667a69