[INFO] fetching crate kafka 0.10.0... [INFO] checking kafka-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kafka 0.10.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate kafka 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kafka 0.10.0 [INFO] finished tweaking crates.io crate kafka 0.10.0 [INFO] tweaked toml for crates.io crate kafka 0.10.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate kafka 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60e6da040410e5888a7f381e5bb7b635658e42375e96ad6b0ee1d264f88e1e9a [INFO] running `Command { std: "docker" "start" "-a" "60e6da040410e5888a7f381e5bb7b635658e42375e96ad6b0ee1d264f88e1e9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60e6da040410e5888a7f381e5bb7b635658e42375e96ad6b0ee1d264f88e1e9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60e6da040410e5888a7f381e5bb7b635658e42375e96ad6b0ee1d264f88e1e9a", kill_on_drop: false }` [INFO] [stdout] 60e6da040410e5888a7f381e5bb7b635658e42375e96ad6b0ee1d264f88e1e9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d6cefe9eeee0fc4b5648f4541ace4f9df863f99ef529747fb8e5d983a3abee23 [INFO] running `Command { std: "docker" "start" "-a" "d6cefe9eeee0fc4b5648f4541ace4f9df863f99ef529747fb8e5d983a3abee23", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling snap v1.1.0 [INFO] [stderr] Compiling thiserror v1.0.48 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking crc-catalog v2.2.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling kafka v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking deranged v0.3.8 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking ref_slice v1.2.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking time v0.3.29 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.48 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/consumer/mod.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 255 | let mut fetch_state = self [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/consumer/mod.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 255 | let mut fetch_state = self [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:461:38 [INFO] [stdout] | [INFO] [stdout] 455 | pub fn new_secure(hosts: Vec, security: SecurityConfig) -> KafkaClient { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 461 | fetch_max_wait_time: protocol::to_millis_i32(Duration::from_millis( [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 462 | | DEFAULT_FETCH_MAX_WAIT_TIME_MILLIS, [INFO] [stdout] 463 | | )) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 455 | pub fn new_secure(hosts: Vec, security: SecurityConfig) -> KafkaClient { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | conn_pool: network::Connections::new_with_security( [INFO] [stdout] | ________________________^ [INFO] [stdout] 473 | | default_conn_rw_timeout(), [INFO] [stdout] 474 | | Duration::from_millis(DEFAULT_CONNECTION_IDLE_TIMEOUT_MILLIS), [INFO] [stdout] 475 | | Some(security), [INFO] [stdout] 476 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | .map(|c| (c.connector.clone(), c.verify_hostname)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 165 | security: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | conns: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:170:21 [INFO] [stdout] | [INFO] [stdout] 165 | security: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | config: Config { [INFO] [stdout] | _____________________^ [INFO] [stdout] 171 | | rw_timeout, [INFO] [stdout] 172 | | idle_timeout, [INFO] [stdout] 173 | | security_config: security, [INFO] [stdout] 174 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 370 | stream: KafkaStream, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | Ok(KafkaConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 378 | | id, [INFO] [stdout] 379 | | host: host.to_owned(), [INFO] [stdout] 380 | | stream, [INFO] [stdout] 381 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codecs.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 125 | let mut temp: Self::R = Default::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | match temp.decode(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression/gzip.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn uncompress(src: T) -> Result> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let mut d = GzDecoder::new(src); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | match d.read_to_end(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/mod.rs:104:22 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn from_client(client: KafkaClient) -> Builder { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | builder::new(Some(client), Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/mod.rs:158:41 [INFO] [stdout] | [INFO] [stdout] 157 | let (n, resps) = self.fetch_messages(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | self.process_fetch_responses(n, resps?) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/mod.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 225 | resps: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | Ok(MessageSets { [INFO] [stdout] | ____________^ [INFO] [stdout] 342 | | responses: resps, [INFO] [stdout] 343 | | empty, [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/builder.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn create(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let (mut client, need_metadata) = match self.client { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Some(client) => (client, false), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Consumer { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | client, [INFO] [stdout] 262 | | state, [INFO] [stdout] 263 | | config, [INFO] [stdout] 264 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 229 | pub fn from_client(client: KafkaClient) -> Builder { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Builder::new(Some(client), Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:337:12 [INFO] [stdout] | [INFO] [stdout] 324 | fn new(client: &mut KafkaClient, partitioner: P) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Ok(State { [INFO] [stdout] | ____________^ [INFO] [stdout] 338 | | partitions: ids, [INFO] [stdout] 339 | | partitioner, [INFO] [stdout] 340 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:443:30 [INFO] [stdout] | [INFO] [stdout] 434 | pub fn with_partitioner(self, partitioner: Q) -> Builder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 443 | security_config: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:489:12 [INFO] [stdout] | [INFO] [stdout] 464 | pub fn create(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | // ~ create the client if necessary [INFO] [stdout] 466 | let (mut client, need_metadata) = match self.client { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | Some(client) => (client, false), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let state = State::new(&mut client, self.partitioner)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | Ok(Producer { [INFO] [stdout] | ____________^ [INFO] [stdout] 490 | | client, [INFO] [stdout] 491 | | state, [INFO] [stdout] 492 | | config: producer_config, [INFO] [stdout] 493 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/fetch.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 156 | let mut array = Vec::with_capacity(n_elems); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let topics = array_of!(r, Topic::read(&mut r, reqs, validate_crc)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | Ok(Response { [INFO] [stdout] | ____________^ [INFO] [stdout] 196 | | raw_data: response, [INFO] [stdout] 197 | | correlation_id, [INFO] [stdout] 198 | | topics, [INFO] [stdout] 199 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/fetch.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 156 | let mut array = Vec::with_capacity(n_elems); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let partitions = array_of!(r, Partition::read(r, preqs, validate_crc)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | Ok(Topic { [INFO] [stdout] | ____________^ [INFO] [stdout] 237 | | topic: name, [INFO] [stdout] 238 | | partitions, [INFO] [stdout] 239 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/fetch.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 284 | let err = Error::from_protocol(r.read_i16()?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | Ok(Partition { [INFO] [stdout] | ____________^ [INFO] [stdout] 291 | | partition, [INFO] [stdout] 292 | | data: match err { [INFO] [stdout] 293 | | Some(err) => Err(Arc::new(err)), [INFO] [stdout] ... | [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kafka` (lib) due to 20 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:461:38 [INFO] [stdout] | [INFO] [stdout] 455 | pub fn new_secure(hosts: Vec, security: SecurityConfig) -> KafkaClient { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 461 | fetch_max_wait_time: protocol::to_millis_i32(Duration::from_millis( [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 462 | | DEFAULT_FETCH_MAX_WAIT_TIME_MILLIS, [INFO] [stdout] 463 | | )) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 455 | pub fn new_secure(hosts: Vec, security: SecurityConfig) -> KafkaClient { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | conn_pool: network::Connections::new_with_security( [INFO] [stdout] | ________________________^ [INFO] [stdout] 473 | | default_conn_rw_timeout(), [INFO] [stdout] 474 | | Duration::from_millis(DEFAULT_CONNECTION_IDLE_TIMEOUT_MILLIS), [INFO] [stdout] 475 | | Some(security), [INFO] [stdout] 476 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | .map(|c| (c.connector.clone(), c.verify_hostname)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 165 | security: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | conns: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:170:21 [INFO] [stdout] | [INFO] [stdout] 165 | security: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | config: Config { [INFO] [stdout] | _____________________^ [INFO] [stdout] 171 | | rw_timeout, [INFO] [stdout] 172 | | idle_timeout, [INFO] [stdout] 173 | | security_config: security, [INFO] [stdout] 174 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/network.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 370 | stream: KafkaStream, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | Ok(KafkaConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 378 | | id, [INFO] [stdout] 379 | | host: host.to_owned(), [INFO] [stdout] 380 | | stream, [INFO] [stdout] 381 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codecs.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 125 | let mut temp: Self::R = Default::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | match temp.decode(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression/gzip.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn uncompress(src: T) -> Result> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let mut d = GzDecoder::new(src); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | match d.read_to_end(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/mod.rs:104:22 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn from_client(client: KafkaClient) -> Builder { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | builder::new(Some(client), Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/mod.rs:158:41 [INFO] [stdout] | [INFO] [stdout] 157 | let (n, resps) = self.fetch_messages(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | self.process_fetch_responses(n, resps?) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/mod.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 225 | resps: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | Ok(MessageSets { [INFO] [stdout] | ____________^ [INFO] [stdout] 342 | | responses: resps, [INFO] [stdout] 343 | | empty, [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consumer/builder.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn create(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let (mut client, need_metadata) = match self.client { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Some(client) => (client, false), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Consumer { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | client, [INFO] [stdout] 262 | | state, [INFO] [stdout] 263 | | config, [INFO] [stdout] 264 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 229 | pub fn from_client(client: KafkaClient) -> Builder { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Builder::new(Some(client), Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:337:12 [INFO] [stdout] | [INFO] [stdout] 324 | fn new(client: &mut KafkaClient, partitioner: P) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Ok(State { [INFO] [stdout] | ____________^ [INFO] [stdout] 338 | | partitions: ids, [INFO] [stdout] 339 | | partitioner, [INFO] [stdout] 340 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:443:30 [INFO] [stdout] | [INFO] [stdout] 434 | pub fn with_partitioner(self, partitioner: Q) -> Builder { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 443 | security_config: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:489:12 [INFO] [stdout] | [INFO] [stdout] 464 | pub fn create(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | // ~ create the client if necessary [INFO] [stdout] 466 | let (mut client, need_metadata) = match self.client { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | Some(client) => (client, false), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let state = State::new(&mut client, self.partitioner)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | Ok(Producer { [INFO] [stdout] | ____________^ [INFO] [stdout] 490 | | client, [INFO] [stdout] 491 | | state, [INFO] [stdout] 492 | | config: producer_config, [INFO] [stdout] 493 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/fetch.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 156 | let mut array = Vec::with_capacity(n_elems); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let topics = array_of!(r, Topic::read(&mut r, reqs, validate_crc)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | Ok(Response { [INFO] [stdout] | ____________^ [INFO] [stdout] 196 | | raw_data: response, [INFO] [stdout] 197 | | correlation_id, [INFO] [stdout] 198 | | topics, [INFO] [stdout] 199 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/fetch.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 156 | let mut array = Vec::with_capacity(n_elems); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let partitions = array_of!(r, Partition::read(r, preqs, validate_crc)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | Ok(Topic { [INFO] [stdout] | ____________^ [INFO] [stdout] 237 | | topic: name, [INFO] [stdout] 238 | | partitions, [INFO] [stdout] 239 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/fetch.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 284 | let err = Error::from_protocol(r.read_i16()?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | Ok(Partition { [INFO] [stdout] | ____________^ [INFO] [stdout] 291 | | partition, [INFO] [stdout] 292 | | data: match err { [INFO] [stdout] 293 | | Some(err) => Err(Arc::new(err)), [INFO] [stdout] ... | [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kafka` (lib test) due to 20 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d6cefe9eeee0fc4b5648f4541ace4f9df863f99ef529747fb8e5d983a3abee23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6cefe9eeee0fc4b5648f4541ace4f9df863f99ef529747fb8e5d983a3abee23", kill_on_drop: false }` [INFO] [stdout] d6cefe9eeee0fc4b5648f4541ace4f9df863f99ef529747fb8e5d983a3abee23