[INFO] fetching crate kaffix 0.0.1... [INFO] checking kaffix-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kaffix 0.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate kaffix 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kaffix 0.0.1 [INFO] finished tweaking crates.io crate kaffix 0.0.1 [INFO] tweaked toml for crates.io crate kaffix 0.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate kaffix 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13bd22094af20b197faa753f81f98e44ef318b705d3205cfd61221401f698505 [INFO] running `Command { std: "docker" "start" "-a" "13bd22094af20b197faa753f81f98e44ef318b705d3205cfd61221401f698505", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13bd22094af20b197faa753f81f98e44ef318b705d3205cfd61221401f698505", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13bd22094af20b197faa753f81f98e44ef318b705d3205cfd61221401f698505", kill_on_drop: false }` [INFO] [stdout] 13bd22094af20b197faa753f81f98e44ef318b705d3205cfd61221401f698505 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dae16400eefd185073f398897615189dc7b5c0f4df50e62a1116cd57ad9d1cac [INFO] running `Command { std: "docker" "start" "-a" "dae16400eefd185073f398897615189dc7b5c0f4df50e62a1116cd57ad9d1cac", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Compiling tokio v1.4.0 [INFO] [stderr] Checking futures-sink v0.3.13 [INFO] [stderr] Compiling httparse v1.3.6 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Checking futures-task v0.3.13 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking futures-channel v0.3.13 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking futures-util v0.3.13 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking utf-8 v0.7.5 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking futures-io v0.3.13 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking tracing v0.1.25 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking input_buffer v0.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Checking getrandom v0.2.2 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking idna v0.2.2 [INFO] [stderr] Checking url v2.2.1 [INFO] [stderr] Checking futures v0.3.13 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking http-body v0.4.1 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking sha-1 v0.9.4 [INFO] [stderr] Checking headers v0.3.4 [INFO] [stderr] Checking tungstenite v0.12.0 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking multipart v0.17.1 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Compiling pin-project-internal v1.0.6 [INFO] [stderr] Checking pin-project v1.0.6 [INFO] [stderr] Checking tokio-util v0.6.5 [INFO] [stderr] Checking tokio-tungstenite v0.13.0 [INFO] [stderr] Checking tokio-stream v0.1.5 [INFO] [stderr] Checking h2 v0.3.2 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking hyper v0.14.5 [INFO] [stderr] Checking warp v0.3.1 [INFO] [stderr] Checking kaffix v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 42 | let services = Arc::new(self.services); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let echo = warp::path!("service" / String).and(warp::ws()).map( [INFO] [stdout] 44 | move |service_name: String, ws: Ws| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let f = services.get(&service_name).unwrap().clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | println!(" {} New connection on {}", "=-=".green(), service_name); [INFO] [stdout] 47 | ws.on_upgrade(move |websocket| async move { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 48 | | let (mut tx, mut rx) = websocket.split(); [INFO] [stdout] 49 | | while let Some(result) = rx.next().await { [INFO] [stdout] 50 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/app.rs:54:79 [INFO] [stdout] | [INFO] [stdout] 54 | ... tx.send(warp::ws::Message::text("Received".clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kaffix` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 42 | let services = Arc::new(self.services); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let echo = warp::path!("service" / String).and(warp::ws()).map( [INFO] [stdout] 44 | move |service_name: String, ws: Ws| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let f = services.get(&service_name).unwrap().clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | println!(" {} New connection on {}", "=-=".green(), service_name); [INFO] [stdout] 47 | ws.on_upgrade(move |websocket| async move { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 48 | | let (mut tx, mut rx) = websocket.split(); [INFO] [stdout] 49 | | while let Some(result) = rx.next().await { [INFO] [stdout] 50 | | match result { [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/app.rs:54:79 [INFO] [stdout] | [INFO] [stdout] 54 | ... tx.send(warp::ws::Message::text("Received".clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kaffix` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "dae16400eefd185073f398897615189dc7b5c0f4df50e62a1116cd57ad9d1cac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dae16400eefd185073f398897615189dc7b5c0f4df50e62a1116cd57ad9d1cac", kill_on_drop: false }` [INFO] [stdout] dae16400eefd185073f398897615189dc7b5c0f4df50e62a1116cd57ad9d1cac