[INFO] fetching crate kadcast 0.7.0-rc.4... [INFO] checking kadcast-0.7.0-rc.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kadcast 0.7.0-rc.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate kadcast 0.7.0-rc.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate kadcast 0.7.0-rc.4 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate kadcast 0.7.0-rc.4 [INFO] tweaked toml for crates.io crate kadcast 0.7.0-rc.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate kadcast 0.7.0-rc.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12c12572bd87ada4c027397201eb6226011e7bd9cf1e0d06f8e4a8358ee80b6f [INFO] running `Command { std: "docker" "start" "-a" "12c12572bd87ada4c027397201eb6226011e7bd9cf1e0d06f8e4a8358ee80b6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12c12572bd87ada4c027397201eb6226011e7bd9cf1e0d06f8e4a8358ee80b6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12c12572bd87ada4c027397201eb6226011e7bd9cf1e0d06f8e4a8358ee80b6f", kill_on_drop: false }` [INFO] [stdout] 12c12572bd87ada4c027397201eb6226011e7bd9cf1e0d06f8e4a8358ee80b6f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 424fbe10f9e3ced3e9d43cd8f97528f5b55cd9ba1b72a10fa4388a4013332a69 [INFO] running `Command { std: "docker" "start" "-a" "424fbe10f9e3ced3e9d43cd8f97528f5b55cd9ba1b72a10fa4388a4013332a69", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking konst_macro_rules v0.2.19 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.31 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling konst_proc_macros v0.2.11 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chrono v0.4.28 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking konst v0.2.19 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking raptorq v2.0.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking rustc_tools_util v0.2.1 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking kadcast v0.7.0-rc.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `NodeInsertOk` [INFO] [stdout] --> src/kbucket.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | pub use bucket::{NodeInsertError, NodeInsertOk}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BinaryNonce` [INFO] [stdout] --> src/kbucket.rs:14:36 [INFO] [stdout] | [INFO] [stdout] 14 | pub use key::{BinaryID, BinaryKey, BinaryNonce}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbucket.rs:66:47 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|(&height, bucket)| (height, bucket.pick::())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbucket.rs:96:47 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|(&height, bucket)| (height, bucket.peers())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbucket.rs:117:47 [INFO] [stdout] | [INFO] [stdout] 117 | .map(|(&height, bucket)| (height, bucket.pick::())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbucket.rs:168:22 [INFO] [stdout] | [INFO] [stdout] 159 | pub(crate) fn new(root: Node, config: BucketConfig) -> Tree { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | buckets: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kbucket/bucket.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 148 | node: Node, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | match self.nodes.try_push(node) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:177:45 [INFO] [stdout] | [INFO] [stdout] 177 | ... .filter_map(|m| m.bytes().ok()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kadcast` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "424fbe10f9e3ced3e9d43cd8f97528f5b55cd9ba1b72a10fa4388a4013332a69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "424fbe10f9e3ced3e9d43cd8f97528f5b55cd9ba1b72a10fa4388a4013332a69", kill_on_drop: false }` [INFO] [stdout] 424fbe10f9e3ced3e9d43cd8f97528f5b55cd9ba1b72a10fa4388a4013332a69