[INFO] fetching crate jxl-frame 0.9.0... [INFO] checking jxl-frame-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jxl-frame 0.9.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate jxl-frame 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jxl-frame 0.9.0 [INFO] finished tweaking crates.io crate jxl-frame 0.9.0 [INFO] tweaked toml for crates.io crate jxl-frame 0.9.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed9eaffb238457fa408427a584348668b6618a39e442d04badfa1838c6c3fc02 [INFO] running `Command { std: "docker" "start" "-a" "ed9eaffb238457fa408427a584348668b6618a39e442d04badfa1838c6c3fc02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed9eaffb238457fa408427a584348668b6618a39e442d04badfa1838c6c3fc02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed9eaffb238457fa408427a584348668b6618a39e442d04badfa1838c6c3fc02", kill_on_drop: false }` [INFO] [stdout] ed9eaffb238457fa408427a584348668b6618a39e442d04badfa1838c6c3fc02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3790fe663c62619b3961ad72340a0251a71d5c1080f34b2f55b86cdd10dcf8f [INFO] running `Command { std: "docker" "start" "-a" "f3790fe663c62619b3961ad72340a0251a71d5c1080f34b2f55b86cdd10dcf8f", kill_on_drop: false }` [INFO] [stderr] Checking jxl-bitstream v0.4.0 [INFO] [stderr] Checking jxl-grid v0.4.2 [INFO] [stderr] Checking jxl-threadpool v0.1.1 [INFO] [stderr] Checking jxl-coding v0.4.0 [INFO] [stderr] Checking jxl-modular v0.7.1 [INFO] [stderr] Checking jxl-color v0.7.1 [INFO] [stderr] Checking jxl-image v0.9.0 [INFO] [stderr] Checking jxl-vardct v0.7.0 [INFO] [stderr] Checking jxl-frame v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 91 | fn parse(bitstream: &mut Bitstream, ctx: FrameContext) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let FrameContext { [INFO] [stdout] 93 | image_header, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let tracker = tracker.cloned(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 207 | | pool, [INFO] [stdout] 208 | | tracker, [INFO] [stdout] 209 | | image_header, [INFO] [stdout] ... | [INFO] [stdout] 216 | | lz77_mode: bitstream.lz77_mode(), [INFO] [stdout] 217 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/hf_global.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | let hf_passes = std::iter::repeat_with(|| HfPass::parse(bitstream, hf_pass_params)) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | dequant_matrices, [INFO] [stdout] 82 | | num_hf_presets, [INFO] [stdout] 83 | | hf_passes, [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/lf_global.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 142 | let gmodular = read_bits!(bitstream, Bundle(GlobalModular::), params)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | patches, [INFO] [stdout] 146 | | splines, [INFO] [stdout] 147 | | noise, [INFO] [stdout] ... | [INFO] [stdout] 150 | | gmodular, [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/lf_global.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 199 | let span = tracing::span!(tracing::Level::TRACE, "Decode GlobalModular"); [INFO] [stdout] | ---- ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let _guard = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let ma_config = bitstream [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let mut modular = read_bits!(bitstream, Bundle(Modular::), modular_params)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 283 | | ma_config, [INFO] [stdout] 284 | | modular, [INFO] [stdout] 285 | | extra_channel_from, [INFO] [stdout] 286 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 91 | fn parse(bitstream: &mut Bitstream, ctx: FrameContext) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let FrameContext { [INFO] [stdout] 93 | image_header, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let tracker = tracker.cloned(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 207 | | pool, [INFO] [stdout] 208 | | tracker, [INFO] [stdout] 209 | | image_header, [INFO] [stdout] ... | [INFO] [stdout] 216 | | lz77_mode: bitstream.lz77_mode(), [INFO] [stdout] 217 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/hf_global.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | let hf_passes = std::iter::repeat_with(|| HfPass::parse(bitstream, hf_pass_params)) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | dequant_matrices, [INFO] [stdout] 82 | | num_hf_presets, [INFO] [stdout] 83 | | hf_passes, [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/lf_global.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 142 | let gmodular = read_bits!(bitstream, Bundle(GlobalModular::), params)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | patches, [INFO] [stdout] 146 | | splines, [INFO] [stdout] 147 | | noise, [INFO] [stdout] ... | [INFO] [stdout] 150 | | gmodular, [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/lf_global.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 199 | let span = tracing::span!(tracing::Level::TRACE, "Decode GlobalModular"); [INFO] [stdout] | ---- ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let _guard = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let ma_config = bitstream [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let mut modular = read_bits!(bitstream, Bundle(Modular::), modular_params)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 283 | | ma_config, [INFO] [stdout] 284 | | modular, [INFO] [stdout] 285 | | extra_channel_from, [INFO] [stdout] 286 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jxl-frame` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jxl-frame` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f3790fe663c62619b3961ad72340a0251a71d5c1080f34b2f55b86cdd10dcf8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3790fe663c62619b3961ad72340a0251a71d5c1080f34b2f55b86cdd10dcf8f", kill_on_drop: false }` [INFO] [stdout] f3790fe663c62619b3961ad72340a0251a71d5c1080f34b2f55b86cdd10dcf8f