[INFO] fetching crate justone 0.3.0... [INFO] checking justone-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate justone 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate justone 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate justone 0.3.0 [INFO] finished tweaking crates.io crate justone 0.3.0 [INFO] tweaked toml for crates.io crate justone 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate justone 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92c749ed9e1ef58e93f57f9908b50cc336c63135bfb9aa320e1c14234e811b2a [INFO] running `Command { std: "docker" "start" "-a" "92c749ed9e1ef58e93f57f9908b50cc336c63135bfb9aa320e1c14234e811b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92c749ed9e1ef58e93f57f9908b50cc336c63135bfb9aa320e1c14234e811b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92c749ed9e1ef58e93f57f9908b50cc336c63135bfb9aa320e1c14234e811b2a", kill_on_drop: false }` [INFO] [stdout] 92c749ed9e1ef58e93f57f9908b50cc336c63135bfb9aa320e1c14234e811b2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb373a1774f96869428c9d05222d459193e3744b2c7540d9a0513d7d6b9cdc11 [INFO] running `Command { std: "docker" "start" "-a" "fb373a1774f96869428c9d05222d459193e3744b2c7540d9a0513d7d6b9cdc11", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking filecmp v0.2.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking terminal_size v0.1.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking console v0.13.0 [INFO] [stderr] Checking twox-hash v1.6.0 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking justone v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | let mut file_info = self.file_info.get_mut(file_index).unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | let mut file_info = self.file_info.get_mut(file_index).unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 502 | let mut file_info = self.file_info.get_mut(file_index).unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:502:13 [INFO] [stdout] | [INFO] [stdout] 502 | let mut file_info = self.file_info.get_mut(file_index).unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `size` are never read [INFO] [stdout] --> src/lib.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 142 | struct FileInfo { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 143 | id: FileIndex, [INFO] [stdout] | ^^ [INFO] [stdout] 144 | path: PathBuf, [INFO] [stdout] 145 | size: FileSize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:15 [INFO] [stdout] | [INFO] [stdout] 210 | hasher_creator: Box Box>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | ..JustOne::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `justone` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `id` and `size` are never read [INFO] [stdout] --> src/lib.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 142 | struct FileInfo { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 143 | id: FileIndex, [INFO] [stdout] | ^^ [INFO] [stdout] 144 | path: PathBuf, [INFO] [stdout] 145 | size: FileSize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:15 [INFO] [stdout] | [INFO] [stdout] 210 | hasher_creator: Box Box>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | ..JustOne::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `justone` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fb373a1774f96869428c9d05222d459193e3744b2c7540d9a0513d7d6b9cdc11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb373a1774f96869428c9d05222d459193e3744b2c7540d9a0513d7d6b9cdc11", kill_on_drop: false }` [INFO] [stdout] fb373a1774f96869428c9d05222d459193e3744b2c7540d9a0513d7d6b9cdc11