[INFO] fetching crate jujube-lib 0.1.1... [INFO] checking jujube-lib-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jujube-lib 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate jujube-lib 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jujube-lib 0.1.1 [INFO] finished tweaking crates.io crate jujube-lib 0.1.1 [INFO] tweaked toml for crates.io crate jujube-lib 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 138 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding backoff v0.2.1 (latest: v0.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2 v0.9.2 (latest: v0.10.6) [INFO] [stderr] Adding config v0.10.1 (latest: v0.14.0) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding dirs v3.0.2 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding git2 v0.13.25 (latest: v0.19.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding libgit2-sys v0.12.26+1.3.0 (latest: v0.17.0+1.8.1) [INFO] [stderr] Adding libssh2-sys v0.2.23 (latest: v0.3.0) [INFO] [stderr] Adding linked-hash-map v0.3.0 (latest: v0.5.6) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding protobuf v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding protobuf-codegen v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding rust-ini v0.13.0 (latest: v0.21.1) [INFO] [stderr] Adding serde v0.8.23 (latest: v1.0.209) [INFO] [stderr] Adding serde-hjson v0.9.1 (latest: v1.0.0) [INFO] [stderr] Adding serde_test v0.8.23 (latest: v1.0.177) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding test-case v1.2.3 (latest: v3.3.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zstd v0.6.1+zstd.1.4.9 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v3.0.1+zstd.1.4.9 (latest: v7.2.1) [INFO] [stderr] Adding zstd-sys v1.4.20+zstd.1.4.9 (latest: v2.0.13+zstd.1.5.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0f9fd86e3559611934690f180dbc63170415570edb36b82c6b170a37230ff2f [INFO] running `Command { std: "docker" "start" "-a" "a0f9fd86e3559611934690f180dbc63170415570edb36b82c6b170a37230ff2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0f9fd86e3559611934690f180dbc63170415570edb36b82c6b170a37230ff2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0f9fd86e3559611934690f180dbc63170415570edb36b82c6b170a37230ff2f", kill_on_drop: false }` [INFO] [stdout] a0f9fd86e3559611934690f180dbc63170415570edb36b82c6b170a37230ff2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df36024066362c5f4243c9dff639b9ced94ee8c5f85590a2f6c0a93a8ac83514 [INFO] running `Command { std: "docker" "start" "-a" "df36024066362c5f4243c9dff639b9ced94ee8c5f85590a2f6c0a93a8ac83514", kill_on_drop: false }` [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling zstd-safe v3.0.1+zstd.1.4.9 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Compiling test-case v1.2.3 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking rust-ini v0.13.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking serde_test v0.8.23 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling zstd-sys v1.4.20+zstd.1.4.9 [INFO] [stderr] Compiling libgit2-sys v0.12.26+1.3.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking backoff v0.2.1 [INFO] [stderr] Compiling protobuf-codegen v2.28.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking serde-hjson v0.9.1 [INFO] [stderr] Checking config v0.10.1 [INFO] [stderr] Compiling protobuf-codegen-pure v2.28.0 [INFO] [stderr] Compiling jujube-lib v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking git2 v0.13.25 [INFO] [stderr] Checking zstd v0.6.1+zstd.1.4.9 [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/jujube-lib-853432bab172e02e/out/protos/op_store.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/jujube-lib-853432bab172e02e/out/protos/store.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/jujube-lib-853432bab172e02e/out/protos/working_copy.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/jujube-lib-853432bab172e02e/out/protos/op_store.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/jujube-lib-853432bab172e02e/out/protos/store.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/jujube-lib-853432bab172e02e/out/protos/working_copy.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/git_store.rs:103:57 [INFO] [stdout] | [INFO] [stdout] 103 | let proto: crate::protos::store::Commit = protobuf::parse_from_reader(&mut cursor).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/local_store.rs:175:59 [INFO] [stdout] | [INFO] [stdout] 175 | let proto: crate::protos::store::Tree = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/local_store.rs:198:61 [INFO] [stdout] | [INFO] [stdout] 198 | let proto: crate::protos::store::Commit = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/local_store.rs:221:63 [INFO] [stdout] | [INFO] [stdout] 221 | let proto: crate::protos::store::Conflict = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `whoami::hostname`: use `fallible::hostname()` instead [INFO] [stdout] --> src/op_store.rs:103:32 [INFO] [stdout] | [INFO] [stdout] 103 | let hostname = whoami::hostname(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/simple_op_store.rs:87:62 [INFO] [stdout] | [INFO] [stdout] 87 | let proto: crate::protos::op_store::View = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/simple_op_store.rs:110:67 [INFO] [stdout] | [INFO] [stdout] 110 | let proto: crate::protos::op_store::Operation = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/working_copy.rs:213:23 [INFO] [stdout] | [INFO] [stdout] 213 | protobuf::parse_from_reader(&mut file).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/working_copy.rs:574:19 [INFO] [stdout] | [INFO] [stdout] 574 | protobuf::parse_from_reader(&mut file).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/git_store.rs:103:57 [INFO] [stdout] | [INFO] [stdout] 103 | let proto: crate::protos::store::Commit = protobuf::parse_from_reader(&mut cursor).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/local_store.rs:175:59 [INFO] [stdout] | [INFO] [stdout] 175 | let proto: crate::protos::store::Tree = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/local_store.rs:198:61 [INFO] [stdout] | [INFO] [stdout] 198 | let proto: crate::protos::store::Commit = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/local_store.rs:221:63 [INFO] [stdout] | [INFO] [stdout] 221 | let proto: crate::protos::store::Conflict = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `whoami::hostname`: use `fallible::hostname()` instead [INFO] [stdout] --> src/op_store.rs:103:32 [INFO] [stdout] | [INFO] [stdout] 103 | let hostname = whoami::hostname(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/simple_op_store.rs:87:62 [INFO] [stdout] | [INFO] [stdout] 87 | let proto: crate::protos::op_store::View = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/simple_op_store.rs:110:67 [INFO] [stdout] | [INFO] [stdout] 110 | let proto: crate::protos::op_store::Operation = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/working_copy.rs:213:23 [INFO] [stdout] | [INFO] [stdout] 213 | protobuf::parse_from_reader(&mut file).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `protobuf::parse_from_reader`: Use Message::parse_from_reader instead [INFO] [stdout] --> src/working_copy.rs:574:19 [INFO] [stdout] | [INFO] [stdout] 574 | protobuf::parse_from_reader(&mut file).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/repo.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | let mut repo_ref_mut = Arc::get_mut(&mut repo).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/store_wrapper.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut ref_mut = unsafe { Arc::get_mut_unchecked(&mut wrapper) }; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/settings.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct RepoSettings { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 24 | config: config::Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RepoSettings` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit.rs:134:31 [INFO] [stdout] | [INFO] [stdout] 132 | let parents = self.parents(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | // TODO: Perhaps the root commit should also be considered empty. [INFO] [stdout] 134 | parents.len() == 1 && parents[0].tree().id() == self.tree().id() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit.rs:134:57 [INFO] [stdout] | [INFO] [stdout] 132 | let parents = self.parents(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | // TODO: Perhaps the root commit should also be considered empty. [INFO] [stdout] 134 | parents.len() == 1 && parents[0].tree().id() == self.tree().id() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dag_walk.rs:90:15 [INFO] [stdout] | [INFO] [stdout] 78 | start: II, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | id_fn: Box ID + 'id_fn>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | neighbors_fn: Box NI + 'neighbors_fn>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | work: start.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dag_walk.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 78 | start: II, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | id_fn: Box ID + 'id_fn>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | neighbors_fn: Box NI + 'neighbors_fn>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | visited: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dag_walk.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn common_ancestor<'a, I1, I2>(set1: I1, set2: I2) -> Commit [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let set1: Vec = set1.into_iter().cloned().collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let set2: Vec = set2.into_iter().cloned().collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | / closest_common_node(set1, set2, &|commit| commit.parents(), &|commit| { [INFO] [stdout] 243 | | commit.id().clone() [INFO] [stdout] 244 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:239:27 [INFO] [stdout] | [INFO] [stdout] 239 | .map(|id| store.get_commit(id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:466:23 [INFO] [stdout] | [INFO] [stdout] 466 | .map(|id| store.get_commit(&id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:479:19 [INFO] [stdout] | [INFO] [stdout] 479 | .map(|id| store.get_commit(&id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 582 | let new_parents = commit1.parents(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 583 | let rebased_tree2 = if commit2.parents() == new_parents { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 586 | let old_base_tree = merge_commit_trees(store, &commit2.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 591 | let rebased_predecessor_tree = if common_predecessor.parents() == new_parents { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | let old_base_tree = merge_commit_trees(store, &common_predecessor.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 595 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | / CommitBuilder::for_rewrite_from(user_settings, store, &commit1) [INFO] [stdout] 608 | | .set_tree(resolved_tree) [INFO] [stdout] 609 | | .set_predecessors(vec![commit1.id().clone(), commit2.id().clone()]) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_store.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 167 | let locked_repo = self.repo.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let blob = locked_repo [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Box::new(Cursor::new(content))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:285:26 [INFO] [stdout] | [INFO] [stdout] 281 | fn incremental(parent_file: Arc) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | parent_file: Some(parent_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:971:12 [INFO] [stdout] | [INFO] [stdout] 942 | let maybe_parent_file; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 971 | Ok(IndexFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 972 | | parent_file: maybe_parent_file, [INFO] [stdout] 973 | | num_parent_commits, [INFO] [stdout] 974 | | name, [INFO] [stdout] ... | [INFO] [stdout] 981 | | overflow_parent, [INFO] [stdout] 982 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_store.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 119 | let file = File::open(path).map_err(not_found_to_store_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Box::new(zstd::Decoder::new(file)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:30:48 [INFO] [stdout] | [INFO] [stdout] 30 | let mut try_write_lock_file = || match options.open(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operation.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 90 | let data = self.op_store.read_view(&self.data.view_id).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | View::new(self.op_store.clone(), self.data.view_id.clone(), data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrite.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 49 | let old_base_tree = merge_commit_trees(store, &old_commit.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | / CommitBuilder::for_rewrite_from(settings, store, &old_commit) [INFO] [stdout] 58 | | .set_parents(new_parent_ids) [INFO] [stdout] 59 | | .set_tree(new_tree_id) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrite.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 70 | let old_base_tree = merge_commit_trees(store, &old_commit.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / CommitBuilder::for_new_commit(settings, store, new_tree_id) [INFO] [stdout] 80 | | .set_parents(new_parent_ids) [INFO] [stdout] 81 | | .set_description(format!( [INFO] [stdout] 82 | | "backout of commit {}", [INFO] [stdout] 83 | | hex::encode(&old_commit.id().0) [INFO] [stdout] 84 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 33 | let mut config = config::Config::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(UserSettings { config }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut config = self.config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(RepoSettings { config }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_op_store.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 85 | let mut file = File::open(path).map_err(not_found_to_store_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let proto: crate::protos::op_store::View = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ok(view_from_proto(&proto)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_wrapper.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 79 | let data = self.get_store_commit(id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Ok(Commit::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | self.weak_self.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 82 | | id.clone(), [INFO] [stdout] 83 | | data, [INFO] [stdout] 84 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_wrapper.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 145 | let data = self.get_store_tree(dir, id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(Tree::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | self.weak_self.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 148 | | dir.clone(), [INFO] [stdout] 149 | | id.clone(), [INFO] [stdout] 150 | | data, [INFO] [stdout] 151 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutils.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 88 | let mut tree_builder = store.tree_builder(store.empty_tree_id().clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | store.get_tree(&DirRepoPath::root(), &id).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn null(store: Arc, dir: DirRepoPath) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | data: Arc::new(store::Tree::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_builder.rs:132:55 [INFO] [stdout] | [INFO] [stdout] 132 | .unwrap_or_else(|| Tree::null(self.store.clone(), next_dir.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 186 | let _lock = FileLock::lock(op_heads_dir.join("lock")); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let (merge_operation_id, merge_operation, merged_view) = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok((merge_operation_id, merge_operation, merged_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view.rs:259:8 [INFO] [stdout] | [INFO] [stdout] 222 | let op_heads = dag_walk::unreachable( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let mut merged_view = op_store.read_view(&first_op_head.view_id).unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Ok((merge_operation_id, merge_operation, merged_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:177:32 [INFO] [stdout] | [INFO] [stdout] 168 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | working_copy_path: working_copy_path.canonicalize().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:265:42 [INFO] [stdout] | [INFO] [stdout] 264 | let file = File::open(disk_path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | self.store.write_file(path, &mut Box::new(file)).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:546:25 [INFO] [stdout] | [INFO] [stdout] 528 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | let proto = crate::protos::working_copy::Checkout::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | tree_state: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 528 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | let proto = crate::protos::working_copy::Checkout::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | commit: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:561:25 [INFO] [stdout] | [INFO] [stdout] 552 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | tree_state: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:562:21 [INFO] [stdout] | [INFO] [stdout] 552 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 562 | commit: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:574:9 [INFO] [stdout] | [INFO] [stdout] 573 | let mut file = File::open(self.state_path.join("checkout")).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | protobuf::parse_from_reader(&mut file).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:701:9 [INFO] [stdout] | [INFO] [stdout] 676 | let _lock = FileLock::lock(lock_path); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 682 | let current_proto = self.read_proto(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 685 | let current_commit = self.current_commit(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 701 | self.commit.borrow().as_ref().unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/repo.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | let mut repo_ref_mut = Arc::get_mut(&mut repo).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 35 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jujube-lib` (lib) due to 36 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/store_wrapper.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut ref_mut = unsafe { Arc::get_mut_unchecked(&mut wrapper) }; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/settings.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct RepoSettings { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 24 | config: config::Config, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RepoSettings` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit.rs:134:31 [INFO] [stdout] | [INFO] [stdout] 132 | let parents = self.parents(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | // TODO: Perhaps the root commit should also be considered empty. [INFO] [stdout] 134 | parents.len() == 1 && parents[0].tree().id() == self.tree().id() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit.rs:134:57 [INFO] [stdout] | [INFO] [stdout] 132 | let parents = self.parents(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | // TODO: Perhaps the root commit should also be considered empty. [INFO] [stdout] 134 | parents.len() == 1 && parents[0].tree().id() == self.tree().id() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dag_walk.rs:90:15 [INFO] [stdout] | [INFO] [stdout] 78 | start: II, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | id_fn: Box ID + 'id_fn>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | neighbors_fn: Box NI + 'neighbors_fn>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | work: start.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dag_walk.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 78 | start: II, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | id_fn: Box ID + 'id_fn>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | neighbors_fn: Box NI + 'neighbors_fn>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | visited: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dag_walk.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn common_ancestor<'a, I1, I2>(set1: I1, set2: I2) -> Commit [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let set1: Vec = set1.into_iter().cloned().collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let set2: Vec = set2.into_iter().cloned().collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | / closest_common_node(set1, set2, &|commit| commit.parents(), &|commit| { [INFO] [stdout] 243 | | commit.id().clone() [INFO] [stdout] 244 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:239:27 [INFO] [stdout] | [INFO] [stdout] 239 | .map(|id| store.get_commit(id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:466:23 [INFO] [stdout] | [INFO] [stdout] 466 | .map(|id| store.get_commit(&id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:479:19 [INFO] [stdout] | [INFO] [stdout] 479 | .map(|id| store.get_commit(&id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evolution.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 582 | let new_parents = commit1.parents(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 583 | let rebased_tree2 = if commit2.parents() == new_parents { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 586 | let old_base_tree = merge_commit_trees(store, &commit2.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 591 | let rebased_predecessor_tree = if common_predecessor.parents() == new_parents { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | let old_base_tree = merge_commit_trees(store, &common_predecessor.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 595 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | / CommitBuilder::for_rewrite_from(user_settings, store, &commit1) [INFO] [stdout] 608 | | .set_tree(resolved_tree) [INFO] [stdout] 609 | | .set_predecessors(vec![commit1.id().clone(), commit2.id().clone()]) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_store.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 167 | let locked_repo = self.repo.lock().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let blob = locked_repo [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Box::new(Cursor::new(content))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/git_store.rs:493:60 [INFO] [stdout] | [INFO] [stdout] 493 | let git_repo = git2::Repository::init(git_repo_path.clone()).unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 493 - let git_repo = git2::Repository::init(git_repo_path.clone()).unwrap(); [INFO] [stdout] 493 + let git_repo = git2::Repository::init(git_repo_path).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/git_store.rs:603:45 [INFO] [stdout] | [INFO] [stdout] 603 | git2::Repository::init(git_repo_path.clone()).unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 603 - git2::Repository::init(git_repo_path.clone()).unwrap(); [INFO] [stdout] 603 + git2::Repository::init(git_repo_path).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:285:26 [INFO] [stdout] | [INFO] [stdout] 281 | fn incremental(parent_file: Arc) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | parent_file: Some(parent_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:971:12 [INFO] [stdout] | [INFO] [stdout] 942 | let maybe_parent_file; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 971 | Ok(IndexFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 972 | | parent_file: maybe_parent_file, [INFO] [stdout] 973 | | num_parent_commits, [INFO] [stdout] 974 | | name, [INFO] [stdout] ... | [INFO] [stdout] 981 | | overflow_parent, [INFO] [stdout] 982 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_store.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 119 | let file = File::open(path).map_err(not_found_to_store_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Ok(Box::new(zstd::Decoder::new(file)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:30:48 [INFO] [stdout] | [INFO] [stdout] 30 | let mut try_write_lock_file = || match options.open(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operation.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 90 | let data = self.op_store.read_view(&self.data.view_id).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | View::new(self.op_store.clone(), self.data.view_id.clone(), data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrite.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 49 | let old_base_tree = merge_commit_trees(store, &old_commit.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | / CommitBuilder::for_rewrite_from(settings, store, &old_commit) [INFO] [stdout] 58 | | .set_parents(new_parent_ids) [INFO] [stdout] 59 | | .set_tree(new_tree_id) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rewrite.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 70 | let old_base_tree = merge_commit_trees(store, &old_commit.parents()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let new_base_tree = merge_commit_trees(store, &new_parents); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / CommitBuilder::for_new_commit(settings, store, new_tree_id) [INFO] [stdout] 80 | | .set_parents(new_parent_ids) [INFO] [stdout] 81 | | .set_description(format!( [INFO] [stdout] 82 | | "backout of commit {}", [INFO] [stdout] 83 | | hex::encode(&old_commit.id().0) [INFO] [stdout] 84 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 33 | let mut config = config::Config::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(UserSettings { config }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut config = self.config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(RepoSettings { config }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_op_store.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 85 | let mut file = File::open(path).map_err(not_found_to_store_error)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let proto: crate::protos::op_store::View = protobuf::parse_from_reader(&mut file)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ok(view_from_proto(&proto)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_wrapper.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 79 | let data = self.get_store_commit(id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Ok(Commit::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | self.weak_self.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 82 | | id.clone(), [INFO] [stdout] 83 | | data, [INFO] [stdout] 84 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_wrapper.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 145 | let data = self.get_store_tree(dir, id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(Tree::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | self.weak_self.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 148 | | dir.clone(), [INFO] [stdout] 149 | | id.clone(), [INFO] [stdout] 150 | | data, [INFO] [stdout] 151 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutils.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 88 | let mut tree_builder = store.tree_builder(store.empty_tree_id().clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | store.get_tree(&DirRepoPath::root(), &id).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn null(store: Arc, dir: DirRepoPath) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | data: Arc::new(store::Tree::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree_builder.rs:132:55 [INFO] [stdout] | [INFO] [stdout] 132 | .unwrap_or_else(|| Tree::null(self.store.clone(), next_dir.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 186 | let _lock = FileLock::lock(op_heads_dir.join("lock")); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let (merge_operation_id, merge_operation, merged_view) = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok((merge_operation_id, merge_operation, merged_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view.rs:259:8 [INFO] [stdout] | [INFO] [stdout] 222 | let op_heads = dag_walk::unreachable( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let mut merged_view = op_store.read_view(&first_op_head.view_id).unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Ok((merge_operation_id, merge_operation, merged_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:177:32 [INFO] [stdout] | [INFO] [stdout] 168 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | working_copy_path: working_copy_path.canonicalize().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:265:42 [INFO] [stdout] | [INFO] [stdout] 264 | let file = File::open(disk_path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | self.store.write_file(path, &mut Box::new(file)).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:546:25 [INFO] [stdout] | [INFO] [stdout] 528 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | let proto = crate::protos::working_copy::Checkout::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 546 | tree_state: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:547:21 [INFO] [stdout] | [INFO] [stdout] 528 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | let proto = crate::protos::working_copy::Checkout::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 535 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | commit: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:561:25 [INFO] [stdout] | [INFO] [stdout] 552 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | tree_state: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:562:21 [INFO] [stdout] | [INFO] [stdout] 552 | store: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 562 | commit: RefCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:574:9 [INFO] [stdout] | [INFO] [stdout] 573 | let mut file = File::open(self.state_path.join("checkout")).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | protobuf::parse_from_reader(&mut file).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/working_copy.rs:701:9 [INFO] [stdout] | [INFO] [stdout] 676 | let _lock = FileLock::lock(lock_path); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 682 | let current_proto = self.read_proto(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 685 | let current_commit = self.current_commit(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 701 | self.commit.borrow().as_ref().unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 35 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jujube-lib` (lib test) due to 36 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "df36024066362c5f4243c9dff639b9ced94ee8c5f85590a2f6c0a93a8ac83514", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df36024066362c5f4243c9dff639b9ced94ee8c5f85590a2f6c0a93a8ac83514", kill_on_drop: false }` [INFO] [stdout] df36024066362c5f4243c9dff639b9ced94ee8c5f85590a2f6c0a93a8ac83514