[INFO] fetching crate jt808 0.1.1... [INFO] checking jt808-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jt808 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate jt808 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jt808 0.1.1 [INFO] finished tweaking crates.io crate jt808 0.1.1 [INFO] tweaked toml for crates.io crate jt808 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab379d951a46513c0a65de655acde114df69c316933ae354d00d009acbf3088b [INFO] running `Command { std: "docker" "start" "-a" "ab379d951a46513c0a65de655acde114df69c316933ae354d00d009acbf3088b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab379d951a46513c0a65de655acde114df69c316933ae354d00d009acbf3088b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab379d951a46513c0a65de655acde114df69c316933ae354d00d009acbf3088b", kill_on_drop: false }` [INFO] [stdout] ab379d951a46513c0a65de655acde114df69c316933ae354d00d009acbf3088b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 399f0ad9d7fc436752449dea68c568662d186d61f18533f960e9b8bb8fd250d9 [INFO] running `Command { std: "docker" "start" "-a" "399f0ad9d7fc436752449dea68c568662d186d61f18533f960e9b8bb8fd250d9", kill_on_drop: false }` [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking jt_util v0.1.1 [INFO] [stderr] Checking jt808 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/models/jt0x0100.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | Ver808::V2013 => (37 + self.name.bytes_len()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - Ver808::V2013 => (37 + self.name.bytes_len()), [INFO] [stdout] 57 + Ver808::V2013 => 37 + self.name.bytes_len(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/models/jt0x0100.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 58 | Ver808::V2019 => (76 + self.name.bytes_len()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - Ver808::V2019 => (76 + self.name.bytes_len()), [INFO] [stdout] 58 + Ver808::V2019 => 76 + self.name.bytes_len(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/models/jt0x0100.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | Ver808::V2013 => (37 + self.name.bytes_len()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - Ver808::V2013 => (37 + self.name.bytes_len()), [INFO] [stdout] 57 + Ver808::V2013 => 37 + self.name.bytes_len(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/models/jt0x0100.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 58 | Ver808::V2019 => (76 + self.name.bytes_len()), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - Ver808::V2019 => (76 + self.name.bytes_len()), [INFO] [stdout] 58 + Ver808::V2019 => 76 + self.name.bytes_len(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ver` is never read [INFO] [stdout] --> src/models/location/jt0x0704.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Jt0x0704 { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | ver: Ver808, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Jt0x0704` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add` and `remove` are never used [INFO] [stdout] --> src/models/location/jt0x0704.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Jt0x0704 { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 20 | pub fn add(&mut self, jt0200: Jt0x0200) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn remove(&mut self, jt0200: Jt0x0200) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package/mod.rs:198:39 [INFO] [stdout] | [INFO] [stdout] 186 | let buf = match self.package_total { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut bufmut = BytesMut::with_capacity(self.total_len); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | for i in 0..self.package_total { [INFO] [stdout] 192 | let body = self.data.get(&i).unwrap().get_body(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Jt808BodyTrans::fill_new(&mut JtBytes::from(buf), self.get_first_jt().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ver` is never read [INFO] [stdout] --> src/models/location/jt0x0704.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Jt0x0704 { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | ver: Ver808, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Jt0x0704` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add` and `remove` are never used [INFO] [stdout] --> src/models/location/jt0x0704.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Jt0x0704 { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 20 | pub fn add(&mut self, jt0200: Jt0x0200) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn remove(&mut self, jt0200: Jt0x0200) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jt808` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package/mod.rs:198:39 [INFO] [stdout] | [INFO] [stdout] 186 | let buf = match self.package_total { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut bufmut = BytesMut::with_capacity(self.total_len); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | for i in 0..self.package_total { [INFO] [stdout] 192 | let body = self.data.get(&i).unwrap().get_body(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Jt808BodyTrans::fill_new(&mut JtBytes::from(buf), self.get_first_jt().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jt808` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "399f0ad9d7fc436752449dea68c568662d186d61f18533f960e9b8bb8fd250d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "399f0ad9d7fc436752449dea68c568662d186d61f18533f960e9b8bb8fd250d9", kill_on_drop: false }` [INFO] [stdout] 399f0ad9d7fc436752449dea68c568662d186d61f18533f960e9b8bb8fd250d9