[INFO] fetching crate jsonrpc-ipc-server 18.0.0... [INFO] checking jsonrpc-ipc-server-18.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jsonrpc-ipc-server 18.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate jsonrpc-ipc-server 18.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jsonrpc-ipc-server 18.0.0 [INFO] finished tweaking crates.io crate jsonrpc-ipc-server 18.0.0 [INFO] tweaked toml for crates.io crate jsonrpc-ipc-server 18.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate jsonrpc-ipc-server 18.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53f10d55bd23eac684383bacf6c4649fcbf3e12691221c784f28e14fa827ce4f [INFO] running `Command { std: "docker" "start" "-a" "53f10d55bd23eac684383bacf6c4649fcbf3e12691221c784f28e14fa827ce4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53f10d55bd23eac684383bacf6c4649fcbf3e12691221c784f28e14fa827ce4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53f10d55bd23eac684383bacf6c4649fcbf3e12691221c784f28e14fa827ce4f", kill_on_drop: false }` [INFO] [stdout] 53f10d55bd23eac684383bacf6c4649fcbf3e12691221c784f28e14fa827ce4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ed4ea8be4b35fe0103af8e54235d0cc34cde5397f6c6fac8b79d89c8dd20df8 [INFO] running `Command { std: "docker" "start" "-a" "3ed4ea8be4b35fe0103af8e54235d0cc34cde5397f6c6fac8b79d89c8dd20df8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling tokio v1.8.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking tokio-stream v0.1.7 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking jsonrpc-core v18.0.0 [INFO] [stderr] Checking parity-tokio-ipc v0.9.0 [INFO] [stderr] Checking jsonrpc-server-utils v18.0.0 [INFO] [stderr] Checking jsonrpc-ipc-server v18.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/select_with_weak.rs:63:7 [INFO] [stdout] | [INFO] [stdout] 63 | let mut this = Pin::into_inner(self); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/select_with_weak.rs:63:7 [INFO] [stdout] | [INFO] [stdout] 63 | let mut this = Pin::into_inner(self); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select_with_weak.rs:49:11 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(stream1: S1, stream2: S2) -> SelectWithWeak [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | strong: stream1.fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select_with_weak.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(stream1: S1, stream2: S2) -> SelectWithWeak [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | weak: stream2.fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | handler: Arc::new(io_handler.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | meta_extractor: Arc::new(extractor), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:19 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | session_stats: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | executor: reactor::UninitializedExecutor::Unspawned, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn start(self, path: &str) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let executor = self.executor.initialize()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let rpc_handler = self.handler; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let endpoint_addr = path.to_owned(); [INFO] [stdout] 148 | let meta_extractor = self.meta_extractor; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let session_stats = self.session_stats; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let (stop_signal, stop_receiver) = oneshot::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | // NOTE: These channels are only waited upon in synchronous fashion [INFO] [stdout] 154 | let (start_signal, start_receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let (wait_signal, wait_receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let fut = async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let fut = Box::pin(fut.map(drop)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let handle = InnerHandles { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | match start_receiver.recv().expect("Message should always be sent") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 146 | let rpc_handler = self.handler; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let endpoint_addr = path.to_owned(); [INFO] [stdout] 148 | let meta_extractor = self.meta_extractor; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let session_stats = self.session_stats; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let server = connections.map_ok(move |io_stream| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let session_stats = session_stats.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let (sender, receiver) = mpsc::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let meta = meta_extractor.extract(&RequestContext { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut service = Service::new(rpc_handler.clone(), meta); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let codec = codecs::StreamCodec::new(incoming_separator.clone(), outgoing_separator.clone()); [INFO] [stdout] 201 | let framed = tokio_util::codec::Decoder::framed(codec, io_stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let (writer, reader) = futures::StreamExt::split(framed); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let responses = reader [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | responses.forward(writer).then(move |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:218:36 [INFO] [stdout] | [INFO] [stdout] 146 | let rpc_handler = self.handler; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let endpoint_addr = path.to_owned(); [INFO] [stdout] 148 | let meta_extractor = self.meta_extractor; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let session_stats = self.session_stats; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let server = connections.map_ok(move |io_stream| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let session_stats = session_stats.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let (sender, receiver) = mpsc::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let meta = meta_extractor.extract(&RequestContext { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut service = Service::new(rpc_handler.clone(), meta); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let codec = codecs::StreamCodec::new(incoming_separator.clone(), outgoing_separator.clone()); [INFO] [stdout] 201 | let framed = tokio_util::codec::Decoder::framed(codec, io_stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let (writer, reader) = futures::StreamExt::split(framed); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let responses = reader [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | responses.forward(writer).then(move |_| { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 219 | | trace!(target: "ipc", "Peer: service finished"); [INFO] [stdout] 220 | | if let Some(stats) = session_stats.as_ref() { [INFO] [stdout] 221 | | stats.close_session(session_id) [INFO] [stdout] ... | [INFO] [stdout] 224 | | async { Ok(()) } [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:206:7 [INFO] [stdout] | [INFO] [stdout] 199 | let mut service = Service::new(rpc_handler.clone(), meta); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | / service [INFO] [stdout] 207 | | .call(req) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jsonrpc-ipc-server` (lib) due to 11 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select_with_weak.rs:49:11 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(stream1: S1, stream2: S2) -> SelectWithWeak [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | strong: stream1.fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select_with_weak.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(stream1: S1, stream2: S2) -> SelectWithWeak [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | weak: stream2.fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | handler: Arc::new(io_handler.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | meta_extractor: Arc::new(extractor), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:19 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | session_stats: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn with_meta_extractor(io_handler: T, extractor: E) -> ServerBuilder [INFO] [stdout] | ------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | executor: reactor::UninitializedExecutor::Unspawned, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn start(self, path: &str) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let executor = self.executor.initialize()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let rpc_handler = self.handler; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let endpoint_addr = path.to_owned(); [INFO] [stdout] 148 | let meta_extractor = self.meta_extractor; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let session_stats = self.session_stats; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let (stop_signal, stop_receiver) = oneshot::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | // NOTE: These channels are only waited upon in synchronous fashion [INFO] [stdout] 154 | let (start_signal, start_receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let (wait_signal, wait_receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let fut = async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let fut = Box::pin(fut.map(drop)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let handle = InnerHandles { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | match start_receiver.recv().expect("Message should always be sent") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 146 | let rpc_handler = self.handler; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let endpoint_addr = path.to_owned(); [INFO] [stdout] 148 | let meta_extractor = self.meta_extractor; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let session_stats = self.session_stats; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let server = connections.map_ok(move |io_stream| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let session_stats = session_stats.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let (sender, receiver) = mpsc::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let meta = meta_extractor.extract(&RequestContext { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut service = Service::new(rpc_handler.clone(), meta); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let codec = codecs::StreamCodec::new(incoming_separator.clone(), outgoing_separator.clone()); [INFO] [stdout] 201 | let framed = tokio_util::codec::Decoder::framed(codec, io_stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let (writer, reader) = futures::StreamExt::split(framed); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let responses = reader [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | responses.forward(writer).then(move |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:218:36 [INFO] [stdout] | [INFO] [stdout] 146 | let rpc_handler = self.handler; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let endpoint_addr = path.to_owned(); [INFO] [stdout] 148 | let meta_extractor = self.meta_extractor; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let session_stats = self.session_stats; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let server = connections.map_ok(move |io_stream| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let session_stats = session_stats.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let (sender, receiver) = mpsc::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let meta = meta_extractor.extract(&RequestContext { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut service = Service::new(rpc_handler.clone(), meta); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let codec = codecs::StreamCodec::new(incoming_separator.clone(), outgoing_separator.clone()); [INFO] [stdout] 201 | let framed = tokio_util::codec::Decoder::framed(codec, io_stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let (writer, reader) = futures::StreamExt::split(framed); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let responses = reader [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | responses.forward(writer).then(move |_| { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 219 | | trace!(target: "ipc", "Peer: service finished"); [INFO] [stdout] 220 | | if let Some(stats) = session_stats.as_ref() { [INFO] [stdout] 221 | | stats.close_session(session_id) [INFO] [stdout] ... | [INFO] [stdout] 224 | | async { Ok(()) } [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:206:7 [INFO] [stdout] | [INFO] [stdout] 199 | let mut service = Service::new(rpc_handler.clone(), meta); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | / service [INFO] [stdout] 207 | | .call(req) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:364:3 [INFO] [stdout] | [INFO] [stdout] 351 | let reply = async move { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | let rt = tokio::runtime::Runtime::new().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | rt.block_on(reply).expect("wait for reply") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/server.rs:423:19 [INFO] [stdout] | [INFO] [stdout] 423 | let path = path.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:617:10 [INFO] [stdout] | [INFO] [stdout] 601 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 614 | let timeout = tokio::time::sleep(Duration::from_millis(500)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | futures::pin_mut!(timeout); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 616 | [INFO] [stdout] 617 | match futures::future::select(rx, timeout).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jsonrpc-ipc-server` (lib test) due to 13 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3ed4ea8be4b35fe0103af8e54235d0cc34cde5397f6c6fac8b79d89c8dd20df8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ed4ea8be4b35fe0103af8e54235d0cc34cde5397f6c6fac8b79d89c8dd20df8", kill_on_drop: false }` [INFO] [stdout] 3ed4ea8be4b35fe0103af8e54235d0cc34cde5397f6c6fac8b79d89c8dd20df8