[INFO] fetching crate jsonpath-rust 0.7.0... [INFO] checking jsonpath-rust-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jsonpath-rust 0.7.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate jsonpath-rust 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jsonpath-rust 0.7.0 [INFO] finished tweaking crates.io crate jsonpath-rust 0.7.0 [INFO] tweaked toml for crates.io crate jsonpath-rust 0.7.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate jsonpath-rust 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebb0aac4e6c54a2890bf3d8882ca8304b05449b1208017dc23f38fb824b1352c [INFO] running `Command { std: "docker" "start" "-a" "ebb0aac4e6c54a2890bf3d8882ca8304b05449b1208017dc23f38fb824b1352c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebb0aac4e6c54a2890bf3d8882ca8304b05449b1208017dc23f38fb824b1352c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebb0aac4e6c54a2890bf3d8882ca8304b05449b1208017dc23f38fb824b1352c", kill_on_drop: false }` [INFO] [stdout] ebb0aac4e6c54a2890bf3d8882ca8304b05449b1208017dc23f38fb824b1352c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7273547679b4432661a86576ed8d00dd3ea89f635940fc24dab20f487c85b905 [INFO] running `Command { std: "docker" "start" "-a" "7273547679b4432661a86576ed8d00dd3ea89f635940fc24dab20f487c85b905", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking clap_builder v4.5.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.10 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking jsonpath-rust v0.7.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 351 | pub fn vec_as_data(input: Vec>) -> Vec<&'a Data> { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | / input [INFO] [stdout] 353 | | .into_iter() [INFO] [stdout] 354 | | .filter_map(|v| match v { [INFO] [stdout] 355 | | Slice(el, _) => Some(el), [INFO] [stdout] 356 | | _ => None, [INFO] [stdout] 357 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:361:9 [INFO] [stdout] | [INFO] [stdout] 360 | pub fn vec_as_pair(input: Vec>) -> Vec<(&'a Data, JsPathStr)> { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | / input [INFO] [stdout] 362 | | .into_iter() [INFO] [stdout] 363 | | .filter_map(|v| match v { [INFO] [stdout] 364 | | Slice(el, v) => Some((el, v)), [INFO] [stdout] 365 | | _ => None, [INFO] [stdout] 366 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/model.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn exists(op: Operand) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Operand::Dynamic(Box::new(JsonPath::Empty)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 160 | let mut expr: Option = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Ok(expr.expect("unreachable: above len() == 0 check should have catched this")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 179 | let mut expr: Option = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(expr.expect("unreachable: above len() == 0 check should have catched this")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:203:36 [INFO] [stdout] | [INFO] [stdout] 203 | .map(|expr|Not(Box::new(expr))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/path/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 28 | input: Vec>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | input.into_iter().flat_map(|d| self.find(d)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/path/index.rs:136:25 [INFO] [stdout] | [INFO] [stdout] 135 | pub(crate) fn new(tail: PathInstance<'a>) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Current { tail: Some(tail) } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jsonpath-rust` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7273547679b4432661a86576ed8d00dd3ea89f635940fc24dab20f487c85b905", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7273547679b4432661a86576ed8d00dd3ea89f635940fc24dab20f487c85b905", kill_on_drop: false }` [INFO] [stdout] 7273547679b4432661a86576ed8d00dd3ea89f635940fc24dab20f487c85b905