[INFO] fetching crate jsonbb 0.2.0... [INFO] checking jsonbb-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jsonbb 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate jsonbb 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jsonbb 0.2.0 [INFO] finished tweaking crates.io crate jsonbb 0.2.0 [INFO] tweaked toml for crates.io crate jsonbb 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding jsonb v0.3.0 (latest: v0.4.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5673b24a9c0de91b3ec633ad6ba5dbc5165f582a25a949c00a0143dbb7769465 [INFO] running `Command { std: "docker" "start" "-a" "5673b24a9c0de91b3ec633ad6ba5dbc5165f582a25a949c00a0143dbb7769465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5673b24a9c0de91b3ec633ad6ba5dbc5165f582a25a949c00a0143dbb7769465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5673b24a9c0de91b3ec633ad6ba5dbc5165f582a25a949c00a0143dbb7769465", kill_on_drop: false }` [INFO] [stdout] 5673b24a9c0de91b3ec633ad6ba5dbc5165f582a25a949c00a0143dbb7769465 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc5388ba177128d3fed47a68c634238eebac758d07a64462143bec26f1a3592a [INFO] running `Command { std: "docker" "start" "-a" "dc5388ba177128d3fed47a68c634238eebac758d07a64462143bec26f1a3592a", kill_on_drop: false }` [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking value-trait v0.8.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking jsonb v0.3.0 [INFO] [stderr] Checking simd-json v0.13.10 [INFO] [stderr] Checking jsonbb v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 393 | pub fn finish(self) -> Value { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | Value { [INFO] [stdout] 395 | buffer: self.finish_internal().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn to_value(value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut builder = Builder::>::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | value.serialize(&mut builder)?; [INFO] [stdout] 28 | Ok(builder.finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn array<'a>(iter: impl IntoIterator>) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self::from_builder(0, |b| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 38 | | b.begin_array(); [INFO] [stdout] 39 | | for v in iter { [INFO] [stdout] 40 | | b.add_value(v); [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | b.end_array(); [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:48:31 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn object<'a>(iter: impl IntoIterator)>) -> Self { [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Self::from_builder(0, |b| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 49 | | b.begin_object(); [INFO] [stdout] 50 | | for (k, v) in iter { [INFO] [stdout] 51 | | b.add_string(k); [INFO] [stdout] ... | [INFO] [stdout] 54 | | b.end_object(); [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 62 | let mut builder = Builder::with_capacity(json.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(builder.finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_ref.rs:299:50 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|(k, v)| (k.to_owned(), Self::from(v))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jsonbb` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dc5388ba177128d3fed47a68c634238eebac758d07a64462143bec26f1a3592a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc5388ba177128d3fed47a68c634238eebac758d07a64462143bec26f1a3592a", kill_on_drop: false }` [INFO] [stdout] dc5388ba177128d3fed47a68c634238eebac758d07a64462143bec26f1a3592a