[INFO] fetching crate jsonapi 0.7.0... [INFO] checking jsonapi-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jsonapi 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate jsonapi 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jsonapi 0.7.0 [INFO] finished tweaking crates.io crate jsonapi 0.7.0 [INFO] tweaked toml for crates.io crate jsonapi 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding queryst v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b653d979b615abdc2f6689e30883175351336e853e3ebbe5529dd488168e04a4 [INFO] running `Command { std: "docker" "start" "-a" "b653d979b615abdc2f6689e30883175351336e853e3ebbe5529dd488168e04a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b653d979b615abdc2f6689e30883175351336e853e3ebbe5529dd488168e04a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b653d979b615abdc2f6689e30883175351336e853e3ebbe5529dd488168e04a4", kill_on_drop: false }` [INFO] [stdout] b653d979b615abdc2f6689e30883175351336e853e3ebbe5529dd488168e04a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9c406dea341a011943ceaab3cae6ea7487c3c618d12faa647581794f3af3fbc [INFO] running `Command { std: "docker" "start" "-a" "c9c406dea341a011943ceaab3cae6ea7487c3c618d12faa647581794f3af3fbc", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking queryst v2.1.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking jsonapi v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/model.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 82 - panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] 82 + panic!("{} is not a Value::Object", self.jsonapi_type()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 246 | fn from_serializable(s: S) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | from_value(to_value(s)?).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 306 | pub fn vec_to_jsonapi_document(objects: Vec) -> JsonApiDocument { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | / DocumentData { [INFO] [stdout] 310 | | data: Some(PrimaryData::Multiple(resources)), [INFO] [stdout] 311 | | included, [INFO] [stdout] 312 | | ..Default::default() [INFO] [stdout] 313 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/model.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 82 - panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] 82 + panic!("{} is not a Value::Object", self.jsonapi_type()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 246 | fn from_serializable(s: S) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | from_value(to_value(s)?).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 306 | pub fn vec_to_jsonapi_document(objects: Vec) -> JsonApiDocument { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | / DocumentData { [INFO] [stdout] 310 | | data: Some(PrimaryData::Multiple(resources)), [INFO] [stdout] 311 | | included, [INFO] [stdout] 312 | | ..Default::default() [INFO] [stdout] 313 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jsonapi` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `jsonapi` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c9c406dea341a011943ceaab3cae6ea7487c3c618d12faa647581794f3af3fbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9c406dea341a011943ceaab3cae6ea7487c3c618d12faa647581794f3af3fbc", kill_on_drop: false }` [INFO] [stdout] c9c406dea341a011943ceaab3cae6ea7487c3c618d12faa647581794f3af3fbc