[INFO] fetching crate json_diff_ng 0.6.0... [INFO] checking json_diff_ng-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate json_diff_ng 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate json_diff_ng 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate json_diff_ng 0.6.0 [INFO] finished tweaking crates.io crate json_diff_ng 0.6.0 [INFO] tweaked toml for crates.io crate json_diff_ng 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate json_diff_ng 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d075a9cde8befe76fd57def8eb6bbd983945c5106c4e3a9b7820fdcb7c51611c [INFO] running `Command { std: "docker" "start" "-a" "d075a9cde8befe76fd57def8eb6bbd983945c5106c4e3a9b7820fdcb7c51611c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d075a9cde8befe76fd57def8eb6bbd983945c5106c4e3a9b7820fdcb7c51611c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d075a9cde8befe76fd57def8eb6bbd983945c5106c4e3a9b7820fdcb7c51611c", kill_on_drop: false }` [INFO] [stdout] d075a9cde8befe76fd57def8eb6bbd983945c5106c4e3a9b7820fdcb7c51611c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1cd0d845f6e3697d7f9791ee8c5d4dcf74187db8f62cdfcf5edbecf1f6ef20ec [INFO] running `Command { std: "docker" "start" "-a" "1cd0d845f6e3697d7f9791ee8c5d4dcf74187db8f62cdfcf5edbecf1f6ef20ec", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking diffs v0.5.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking vg_errortools v0.1.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking json_diff_ng v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|(l, v)| (l, DiffTreeNode::Value(v.clone(), v.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 124 | let diff = intersect_maps(a, b, ignore_keys); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let mut left_only_keys = get_map_of_keys(diff.left_only); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut right_only_keys = get_map_of_keys(diff.right_only); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let intersection_keys = diff.intersection; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | let mut unequal_keys = DiffTreeNode::Null; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(Mismatch::new(left_only_keys, right_only_keys, unequal_keys)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 156 | let a = preprocess_array(sort_arrays, a, ignore_keys); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let b = preprocess_array(sort_arrays, b, ignore_keys); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let mut left_only_nodes = values_to_node(left_only_values); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut right_only_nodes = values_to_node(right_only_values); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let mut diff = DiffTreeNode::Null; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(Mismatch::new(left_only_nodes, right_only_nodes, diff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:217:48 [INFO] [stdout] | [INFO] [stdout] 217 | .map(|key| (String::from(key), DiffTreeNode::Null)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | .map(|(k, v)| (k.clone(), sort_value(v, ignore_keys))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json_diff_ng` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|(l, v)| (l, DiffTreeNode::Value(v.clone(), v.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 124 | let diff = intersect_maps(a, b, ignore_keys); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let mut left_only_keys = get_map_of_keys(diff.left_only); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut right_only_keys = get_map_of_keys(diff.right_only); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let intersection_keys = diff.intersection; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | let mut unequal_keys = DiffTreeNode::Null; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(Mismatch::new(left_only_keys, right_only_keys, unequal_keys)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 156 | let a = preprocess_array(sort_arrays, a, ignore_keys); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let b = preprocess_array(sort_arrays, b, ignore_keys); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let mut left_only_nodes = values_to_node(left_only_values); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut right_only_nodes = values_to_node(right_only_values); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let mut diff = DiffTreeNode::Null; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(Mismatch::new(left_only_nodes, right_only_nodes, diff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:217:48 [INFO] [stdout] | [INFO] [stdout] 217 | .map(|key| (String::from(key), DiffTreeNode::Null)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | .map(|(k, v)| (k.clone(), sort_value(v, ignore_keys))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json_diff_ng` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "1cd0d845f6e3697d7f9791ee8c5d4dcf74187db8f62cdfcf5edbecf1f6ef20ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cd0d845f6e3697d7f9791ee8c5d4dcf74187db8f62cdfcf5edbecf1f6ef20ec", kill_on_drop: false }` [INFO] [stdout] 1cd0d845f6e3697d7f9791ee8c5d4dcf74187db8f62cdfcf5edbecf1f6ef20ec