[INFO] fetching crate json-subscriber 0.1.2... [INFO] checking json-subscriber-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate json-subscriber 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate json-subscriber 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate json-subscriber 0.1.2 [INFO] finished tweaking crates.io crate json-subscriber 0.1.2 [INFO] tweaked toml for crates.io crate json-subscriber 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate json-subscriber 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47396101ea72a4ab9f2c7e1dd7dc2f3430d5df2e7deb64b6572ead1164a510ff [INFO] running `Command { std: "docker" "start" "-a" "47396101ea72a4ab9f2c7e1dd7dc2f3430d5df2e7deb64b6572ead1164a510ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47396101ea72a4ab9f2c7e1dd7dc2f3430d5df2e7deb64b6572ead1164a510ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47396101ea72a4ab9f2c7e1dd7dc2f3430d5df2e7deb64b6572ead1164a510ff", kill_on_drop: false }` [INFO] [stdout] 47396101ea72a4ab9f2c7e1dd7dc2f3430d5df2e7deb64b6572ead1164a510ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f08ea012273da2dd7208159acaaf066a18f3c3f6b651115e031502256bd162dd [INFO] running `Command { std: "docker" "start" "-a" "f08ea012273da2dd7208159acaaf066a18f3c3f6b651115e031502256bd162dd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking opentelemetry v0.23.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking opentelemetry_sdk v0.23.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking opentelemetry-stdout v0.4.0 [INFO] [stderr] Checking json-subscriber v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/mod.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 159 | let subscriber = builder.finish(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | #[cfg(not(feature = "env-filter"))] [INFO] [stdout] 161 | let subscriber = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let targets = match env::var("RUST_LOG") { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | subscriber.try_init().map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/builder.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn finish(self) -> Layered, Registry>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let (json_layer, filter_layer) = self.layers(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | / tracing_subscriber::registry() [INFO] [stdout] 168 | | .with(json_layer) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/builder.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn init(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | self.try_init() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/builder.rs:358:26 [INFO] [stdout] | [INFO] [stdout] 353 | pub fn map_writer(self, f: impl FnOnce(W) -> W2) -> SubscriberBuilder [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | make_writer: f(self.make_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/layer.rs:195:20 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn with_writer(self, make_writer: W2) -> Layer [INFO] [stdout] | ---- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | inner: self.inner.with_writer(make_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/layer.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn map_writer(self, f: impl FnOnce(W) -> W2) -> Layer [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | inner: self.inner.map_writer(f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/layer.rs:251:20 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn with_test_writer(self) -> Layer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Layer:: { [INFO] [stdout] 251 | inner: self.inner.with_test_writer(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/mod.rs:210:21 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn new(make_writer: W) -> JsonLayer [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | schema: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/mod.rs:356:26 [INFO] [stdout] | [INFO] [stdout] 351 | pub fn map_writer(self, f: impl FnOnce(W) -> W2) -> JsonLayer [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | make_writer: f(self.make_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/mod.rs:530:28 [INFO] [stdout] | [INFO] [stdout] 517 | mapper: Fun, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | let extensions = span.extensions(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | value: serde_json::to_value(mapper(extension)).ok()?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/mod.rs:599:28 [INFO] [stdout] | [INFO] [stdout] 586 | mapper: Fun, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | let extensions = span.extensions(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 599 | value: serde_json::to_value(mapper(extension)).ok()?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/mod.rs:633:51 [INFO] [stdout] | [INFO] [stdout] 633 | .map(|fields| Cached::Raw(fields.serialized.as_ref().unwrap().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/mod.rs:653:33 [INFO] [stdout] | [INFO] [stdout] 652 | ... .flat_map(|span| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 653 | ... span.extensions() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json-subscriber` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f08ea012273da2dd7208159acaaf066a18f3c3f6b651115e031502256bd162dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f08ea012273da2dd7208159acaaf066a18f3c3f6b651115e031502256bd162dd", kill_on_drop: false }` [INFO] [stdout] f08ea012273da2dd7208159acaaf066a18f3c3f6b651115e031502256bd162dd