[INFO] fetching crate jrpc2 0.2.4... [INFO] checking jrpc2-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jrpc2 0.2.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate jrpc2 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jrpc2 0.2.4 [INFO] finished tweaking crates.io crate jrpc2 0.2.4 [INFO] tweaked toml for crates.io crate jrpc2 0.2.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 92 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding tokio-tungstenite v0.17.2 (latest: v0.23.1) [INFO] [stderr] Adding tungstenite v0.17.3 (latest: v0.24.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 722cb403c8dfcbf95cba4b376df4c05b94913e0598e1a5daa700e8f2e1a832ca [INFO] running `Command { std: "docker" "start" "-a" "722cb403c8dfcbf95cba4b376df4c05b94913e0598e1a5daa700e8f2e1a832ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "722cb403c8dfcbf95cba4b376df4c05b94913e0598e1a5daa700e8f2e1a832ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "722cb403c8dfcbf95cba4b376df4c05b94913e0598e1a5daa700e8f2e1a832ca", kill_on_drop: false }` [INFO] [stdout] 722cb403c8dfcbf95cba4b376df4c05b94913e0598e1a5daa700e8f2e1a832ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d35f88891f83d9c123dfe286d536f2601e77a4946e28794c385197a10d60e033 [INFO] running `Command { std: "docker" "start" "-a" "d35f88891f83d9c123dfe286d536f2601e77a4946e28794c385197a10d60e033", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tungstenite v0.17.3 [INFO] [stderr] Checking tokio-tungstenite v0.17.2 [INFO] [stderr] Checking jrpc2 v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonrpc2.rs:269:85 [INFO] [stdout] | [INFO] [stdout] 269 | async fn call(&self, method: &str, params: Option) -> Result> { [INFO] [stdout] | ________________________________________-----------------____________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | | let (sender, mut receiver) = mpsc::unbounded_channel(); [INFO] [stdout] 271 | | [INFO] [stdout] 272 | | let id_num = self.seq.fetch_add(1, Ordering::Relaxed); [INFO] [stdout] ... | [INFO] [stdout] 289 | | Err(JsonError::ErrNoResponseGenerated) [INFO] [stdout] 290 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jrpc2` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonrpc2.rs:269:85 [INFO] [stdout] | [INFO] [stdout] 269 | async fn call(&self, method: &str, params: Option) -> Result> { [INFO] [stdout] | ________________________________________-----------------____________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | | let (sender, mut receiver) = mpsc::unbounded_channel(); [INFO] [stdout] 271 | | [INFO] [stdout] 272 | | let id_num = self.seq.fetch_add(1, Ordering::Relaxed); [INFO] [stdout] ... | [INFO] [stdout] 289 | | Err(JsonError::ErrNoResponseGenerated) [INFO] [stdout] 290 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jsonrpc2.rs:385:11 [INFO] [stdout] | [INFO] [stdout] 383 | json_rpc2: Arc>, [INFO] [stdout] | ------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | request: Request, [INFO] [stdout] 385 | ) { [INFO] [stdout] | ___________^ [INFO] [stdout] 386 | | match request.method.as_str() { [INFO] [stdout] 387 | | "add" => { [INFO] [stdout] 388 | | let params = request.params.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 397 | | } [INFO] [stdout] 398 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jrpc2` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "d35f88891f83d9c123dfe286d536f2601e77a4946e28794c385197a10d60e033", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d35f88891f83d9c123dfe286d536f2601e77a4946e28794c385197a10d60e033", kill_on_drop: false }` [INFO] [stdout] d35f88891f83d9c123dfe286d536f2601e77a4946e28794c385197a10d60e033