[INFO] fetching crate jpholiday 0.1.4... [INFO] checking jpholiday-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jpholiday 0.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate jpholiday 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jpholiday 0.1.4 [INFO] finished tweaking crates.io crate jpholiday 0.1.4 [INFO] tweaked toml for crates.io crate jpholiday 0.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 301ec2da429cba86bdd283701baa45c145a05bb964dc62b1827a566ab339ca41 [INFO] running `Command { std: "docker" "start" "-a" "301ec2da429cba86bdd283701baa45c145a05bb964dc62b1827a566ab339ca41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "301ec2da429cba86bdd283701baa45c145a05bb964dc62b1827a566ab339ca41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "301ec2da429cba86bdd283701baa45c145a05bb964dc62b1827a566ab339ca41", kill_on_drop: false }` [INFO] [stdout] 301ec2da429cba86bdd283701baa45c145a05bb964dc62b1827a566ab339ca41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2cad463655751b4ff043c69769ec69460bbbd5876ec1c2b835ab981a2ffcf91 [INFO] running `Command { std: "docker" "start" "-a" "a2cad463655751b4ff043c69769ec69460bbbd5876ec1c2b835ab981a2ffcf91", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking jpholiday v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/jpholiday.rs:181:46 [INFO] [stdout] | [INFO] [stdout] 181 | let mut date: NaiveDate = NaiveDate::from_ymd(year.clone(), 1, 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/jpholiday.rs:181:46 [INFO] [stdout] | [INFO] [stdout] 181 | let mut date: NaiveDate = NaiveDate::from_ymd(year.clone(), 1, 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/jpholiday.rs:218:46 [INFO] [stdout] | [INFO] [stdout] 218 | let mut date: NaiveDate = NaiveDate::from_ymd(year.clone(), month.clone(), 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:242:31 [INFO] [stdout] | [INFO] [stdout] 242 | if date == NaiveDate::from_ymd(2020, 7, 23).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/jpholiday.rs:218:46 [INFO] [stdout] | [INFO] [stdout] 218 | let mut date: NaiveDate = NaiveDate::from_ymd(year.clone(), month.clone(), 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:266:31 [INFO] [stdout] | [INFO] [stdout] 266 | if date == NaiveDate::from_ymd(2020, 8, 10).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:372:31 [INFO] [stdout] | [INFO] [stdout] 372 | if date == NaiveDate::from_ymd(2020, 7, 24).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:423:31 [INFO] [stdout] | [INFO] [stdout] 423 | if date == NaiveDate::from_ymd(1959, 4, 10).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:425:38 [INFO] [stdout] | [INFO] [stdout] 425 | } else if date == NaiveDate::from_ymd(1989, 2, 24).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:427:38 [INFO] [stdout] | [INFO] [stdout] 427 | } else if date == NaiveDate::from_ymd(1990, 11, 12).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:429:38 [INFO] [stdout] | [INFO] [stdout] 429 | } else if date == NaiveDate::from_ymd(1993, 6, 9).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:431:38 [INFO] [stdout] | [INFO] [stdout] 431 | } else if date == NaiveDate::from_ymd(2019, 5, 1).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:435:36 [INFO] [stdout] | [INFO] [stdout] 435 | else if date == NaiveDate::from_ymd(2019, 10, 22).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:242:31 [INFO] [stdout] | [INFO] [stdout] 242 | if date == NaiveDate::from_ymd(2020, 7, 23).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:266:31 [INFO] [stdout] | [INFO] [stdout] 266 | if date == NaiveDate::from_ymd(2020, 8, 10).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:372:31 [INFO] [stdout] | [INFO] [stdout] 372 | if date == NaiveDate::from_ymd(2020, 7, 24).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:423:31 [INFO] [stdout] | [INFO] [stdout] 423 | if date == NaiveDate::from_ymd(1959, 4, 10).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/utils.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | return Ok(NaiveDate::from_ymd(date.year(), date.month(), days[(week-1) as usize] as u32)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:425:38 [INFO] [stdout] | [INFO] [stdout] 425 | } else if date == NaiveDate::from_ymd(1989, 2, 24).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:427:38 [INFO] [stdout] | [INFO] [stdout] 427 | } else if date == NaiveDate::from_ymd(1990, 11, 12).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:429:38 [INFO] [stdout] | [INFO] [stdout] 429 | } else if date == NaiveDate::from_ymd(1993, 6, 9).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:431:38 [INFO] [stdout] | [INFO] [stdout] 431 | } else if date == NaiveDate::from_ymd(2019, 5, 1).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/holidays.rs:435:36 [INFO] [stdout] | [INFO] [stdout] 435 | else if date == NaiveDate::from_ymd(2019, 10, 22).borrow() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/utils.rs:26:42 [INFO] [stdout] | [INFO] [stdout] 26 | let mut date: NaiveDate = NaiveDate::from_ymd(year, month, 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/utils.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | return Ok(NaiveDate::from_ymd(date.year(), date.month(), days[(week-1) as usize] as u32)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/utils.rs:26:42 [INFO] [stdout] | [INFO] [stdout] 26 | let mut date: NaiveDate = NaiveDate::from_ymd(year, month, 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:20:28 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn register(&mut self, holiday: T) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | self.registry.push(Box::new(holiday)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jpholiday` (lib test) due to 2 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:20:28 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn register(&mut self, holiday: T) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | self.registry.push(Box::new(holiday)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jpholiday` (lib) due to 2 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a2cad463655751b4ff043c69769ec69460bbbd5876ec1c2b835ab981a2ffcf91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2cad463655751b4ff043c69769ec69460bbbd5876ec1c2b835ab981a2ffcf91", kill_on_drop: false }` [INFO] [stdout] a2cad463655751b4ff043c69769ec69460bbbd5876ec1c2b835ab981a2ffcf91