[INFO] fetching crate josh 22.4.15... [INFO] checking josh-22.4.15 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate josh 22.4.15 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate josh 22.4.15 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate josh 22.4.15 [INFO] finished tweaking crates.io crate josh 22.4.15 [INFO] tweaked toml for crates.io crate josh 22.4.15 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate josh 22.4.15 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e2b2b344e4b2d8f481968332abd0b1c2cfe7e578ba7f7e1a5200855eaf0cf35 [INFO] running `Command { std: "docker" "start" "-a" "5e2b2b344e4b2d8f481968332abd0b1c2cfe7e578ba7f7e1a5200855eaf0cf35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e2b2b344e4b2d8f481968332abd0b1c2cfe7e578ba7f7e1a5200855eaf0cf35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e2b2b344e4b2d8f481968332abd0b1c2cfe7e578ba7f7e1a5200855eaf0cf35", kill_on_drop: false }` [INFO] [stdout] 5e2b2b344e4b2d8f481968332abd0b1c2cfe7e578ba7f7e1a5200855eaf0cf35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cea5278034edc8a7aaa53fc86d2f7498098984a7eb5d73e878ce9a55275d433 [INFO] running `Command { std: "docker" "start" "-a" "2cea5278034edc8a7aaa53fc86d2f7498098984a7eb5d73e878ce9a55275d433", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.77 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling pkg-config v0.3.20 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking tinyvec v1.5.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling rayon-core v1.9.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking tracing-core v0.1.22 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking ascii v0.9.3 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking combine v3.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling rayon v1.5.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking smartstring v0.2.9 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking wyz v0.5.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Compiling unindent v0.1.8 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking defer v0.1.0 [INFO] [stderr] Checking strfmt v0.1.6 [INFO] [stderr] Compiling indoc v1.0.4 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling libgit2-sys v0.13.2+1.4.2 [INFO] [stderr] Checking tracing-subscriber v0.3.11 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking bitvec v1.0.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling derive_utils v0.11.2 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Checking git2 v0.14.2 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling futures-enum v0.1.17 [INFO] [stderr] Compiling juniper_codegen v0.15.7 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking graphql-parser v0.3.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking clap v3.0.14 [INFO] [stderr] Checking serde_yaml v0.8.23 [INFO] [stderr] Checking bson v1.2.3 [INFO] [stderr] Checking rs_tracing v1.0.1 [INFO] [stderr] Checking handlebars v4.2.2 [INFO] [stderr] Checking juniper v0.15.7 [INFO] [stderr] Checking josh v22.4.15 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(repo: git2::Repository, ref_prefix: Option<&str>) -> Transaction { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | log::debug!("new transaction"); [INFO] [stdout] 93 | let path_tree = DB [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let invert_tree = DB [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let trigram_index_tree = DB [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | t2: std::cell::RefCell::new(Transaction2 { [INFO] [stdout] | _________________^ [INFO] [stdout] 116 | | commit_map: HashMap::new(), [INFO] [stdout] 117 | | apply_map: HashMap::new(), [INFO] [stdout] 118 | | subtract_map: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | walks: 0, [INFO] [stdout] 127 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/mod.rs:300:35 [INFO] [stdout] | [INFO] [stdout] 300 | .map(|(f, id)| Ok((f, repo.find_commit(id)?.tree()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/mod.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 367 | .map(|x| Ok(repo.find_commit(*x)?.tree_id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/mod.rs:527:49 [INFO] [stdout] | [INFO] [stdout] 527 | .map(|f| apply(transaction, *f, tree.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:408:39 [INFO] [stdout] | [INFO] [stdout] 408 | .and_then(|x| serde_json::from_str::(x).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:433:22 [INFO] [stdout] | [INFO] [stdout] 433 | .map(|p| transaction.repo().find_tree(p.id()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:484:42 [INFO] [stdout] | [INFO] [stdout] 482 | str_to_value: impl FnOnce(&str) -> Result, [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | ) -> FieldResult { [INFO] [stdout] 484 | self.internal_serialize(context, |transaction, id| { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 485 | | let blob = transaction.repo().find_blob(id)?; [INFO] [stdout] 486 | | let value = str_to_value(std::str::from_utf8(blob.content())?).unwrap_or(json!({})); [INFO] [stdout] 487 | | Ok(Document { id, value }) [INFO] [stdout] 488 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:487:16 [INFO] [stdout] | [INFO] [stdout] 482 | str_to_value: impl FnOnce(&str) -> Result, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | let blob = transaction.repo().find_blob(id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | let value = str_to_value(std::str::from_utf8(blob.content())?).unwrap_or(json!({})); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | Ok(Document { id, value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:620:20 [INFO] [stdout] | [INFO] [stdout] 620 | value: x.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:870:22 [INFO] [stdout] | [INFO] [stdout] 868 | pub fn context(transaction: cache::Transaction) -> Context { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 869 | Context { [INFO] [stdout] 870 | transaction: std::sync::Arc::new(std::sync::Mutex::new(transaction)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:177:11 [INFO] [stdout] | [INFO] [stdout] 106 | let reference = repo.find_reference(headref)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let tree = reference.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | [INFO] [stdout] 109 | let obj = ok_or!( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let template = if let Ok(blob) = obj.peel_to_blob() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let transaction = cache::Transaction::open(repo.path(), None)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let (res, _errors) = juniper::execute_sync( [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut handlebars = handlebars::Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | match handlebars.render(path, &json!(params)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(x) = $e { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(repo: git2::Repository, ref_prefix: Option<&str>) -> Transaction { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | log::debug!("new transaction"); [INFO] [stdout] 93 | let path_tree = DB [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let invert_tree = DB [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let trigram_index_tree = DB [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | t2: std::cell::RefCell::new(Transaction2 { [INFO] [stdout] | _________________^ [INFO] [stdout] 116 | | commit_map: HashMap::new(), [INFO] [stdout] 117 | | apply_map: HashMap::new(), [INFO] [stdout] 118 | | subtract_map: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | walks: 0, [INFO] [stdout] 127 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/mod.rs:300:35 [INFO] [stdout] | [INFO] [stdout] 300 | .map(|(f, id)| Ok((f, repo.find_commit(id)?.tree()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/mod.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 367 | .map(|x| Ok(repo.find_commit(*x)?.tree_id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/mod.rs:527:49 [INFO] [stdout] | [INFO] [stdout] 527 | .map(|f| apply(transaction, *f, tree.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:408:39 [INFO] [stdout] | [INFO] [stdout] 408 | .and_then(|x| serde_json::from_str::(x).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:433:22 [INFO] [stdout] | [INFO] [stdout] 433 | .map(|p| transaction.repo().find_tree(p.id()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:484:42 [INFO] [stdout] | [INFO] [stdout] 482 | str_to_value: impl FnOnce(&str) -> Result, [INFO] [stdout] | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | ) -> FieldResult { [INFO] [stdout] 484 | self.internal_serialize(context, |transaction, id| { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 485 | | let blob = transaction.repo().find_blob(id)?; [INFO] [stdout] 486 | | let value = str_to_value(std::str::from_utf8(blob.content())?).unwrap_or(json!({})); [INFO] [stdout] 487 | | Ok(Document { id, value }) [INFO] [stdout] 488 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:487:16 [INFO] [stdout] | [INFO] [stdout] 482 | str_to_value: impl FnOnce(&str) -> Result, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | let blob = transaction.repo().find_blob(id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | let value = str_to_value(std::str::from_utf8(blob.content())?).unwrap_or(json!({})); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | Ok(Document { id, value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:620:20 [INFO] [stdout] | [INFO] [stdout] 620 | value: x.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphql.rs:870:22 [INFO] [stdout] | [INFO] [stdout] 868 | pub fn context(transaction: cache::Transaction) -> Context { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 869 | Context { [INFO] [stdout] 870 | transaction: std::sync::Arc::new(std::sync::Mutex::new(transaction)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:177:11 [INFO] [stdout] | [INFO] [stdout] 106 | let reference = repo.find_reference(headref)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let tree = reference.peel_to_tree()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | [INFO] [stdout] 109 | let obj = ok_or!( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let template = if let Ok(blob) = obj.peel_to_blob() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let transaction = cache::Transaction::open(repo.path(), None)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let (res, _errors) = juniper::execute_sync( [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut handlebars = handlebars::Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | match handlebars.render(path, &json!(params)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(x) = $e { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `josh` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `josh` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "2cea5278034edc8a7aaa53fc86d2f7498098984a7eb5d73e878ce9a55275d433", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cea5278034edc8a7aaa53fc86d2f7498098984a7eb5d73e878ce9a55275d433", kill_on_drop: false }` [INFO] [stdout] 2cea5278034edc8a7aaa53fc86d2f7498098984a7eb5d73e878ce9a55275d433