[INFO] fetching crate jobsys 0.2.0... [INFO] checking jobsys-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jobsys 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate jobsys 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jobsys 0.2.0 [INFO] finished tweaking crates.io crate jobsys 0.2.0 [INFO] tweaked toml for crates.io crate jobsys 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62872db57ba29c2f2a342b7f06b37585f7a1fdfad107783d2f982b9b96e91a56 [INFO] running `Command { std: "docker" "start" "-a" "62872db57ba29c2f2a342b7f06b37585f7a1fdfad107783d2f982b9b96e91a56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62872db57ba29c2f2a342b7f06b37585f7a1fdfad107783d2f982b9b96e91a56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62872db57ba29c2f2a342b7f06b37585f7a1fdfad107783d2f982b9b96e91a56", kill_on_drop: false }` [INFO] [stdout] 62872db57ba29c2f2a342b7f06b37585f7a1fdfad107783d2f982b9b96e91a56 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b34a22ac367e41ed2875493d374aee63857dc23c0fe00a9d05c3f5a6b81bc52a [INFO] running `Command { std: "docker" "start" "-a" "b34a22ac367e41ed2875493d374aee63857dc23c0fe00a9d05c3f5a6b81bc52a", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking jobsys v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/queues.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | let mut access = queue.guarded_data.get_mut().unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 168 | let mut data_vec: ThreadDataList = Vec::with_capacity(actual_thread_count); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | data_vec.resize_with(actual_thread_count, || ThreadData::new(final_job_capacity)); [INFO] [stdout] 170 | let thread_data = Arc::new(data_vec); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let mut threads = Vec::with_capacity(thread_count); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 182 | | thread_data: thread_data.clone(), [INFO] [stdout] 183 | | threads, [INFO] [stdout] 184 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 269 | pub unsafe fn create(&self, job: T) -> Result, Error> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | tls_job_pool.with(|tls| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 278 | | if let Some(pool) = tls.borrow_mut().as_mut() { [INFO] [stdout] 279 | | let (job_instance, handle) = pool.allocate(); [INFO] [stdout] 280 | | job_instance.store(job); [INFO] [stdout] ... | [INFO] [stdout] 287 | | Err(Error::InvalidThread) [INFO] [stdout] 288 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:315:27 [INFO] [stdout] | [INFO] [stdout] 306 | job: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | tls_job_pool.with(|tls| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 316 | | if let Some(pool) = tls.borrow_mut().as_mut() { [INFO] [stdout] 317 | | if let Some(parent_job) = pool.get_mut_ptr(parent.h) { [INFO] [stdout] 318 | | let (job_instance, handle) = pool.allocate(); [INFO] [stdout] ... | [INFO] [stdout] 329 | | Err(Error::InvalidThread) [INFO] [stdout] 330 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/thread.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 45 | debug_assert!(it.borrow().get() == usize::MAX); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Cell` does not implement `Borrow`, so calling `borrow` on `&Cell` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 45 - debug_assert!(it.borrow().get() == usize::MAX); [INFO] [stdout] 45 + debug_assert!(it.get() == usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:90:26 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn tls_set_thread_data(data: Arc>) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | TLS_THREAD_DATA.with(|tls| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 91 | | let mut thread_data = tls.borrow_mut(); [INFO] [stdout] 92 | | debug_assert!(thread_data.is_none()); [INFO] [stdout] 93 | | *thread_data = Some(data) [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 121 | pub(crate) fn new(data: std::sync::Arc>, index: usize) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | thread_handle: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:185:40 [INFO] [stdout] | [INFO] [stdout] 185 | TLS_RANDOM_GEN.with(|rand| rand.borrow_mut().gen::() % list.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jobsys` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 168 | let mut data_vec: ThreadDataList = Vec::with_capacity(actual_thread_count); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | data_vec.resize_with(actual_thread_count, || ThreadData::new(final_job_capacity)); [INFO] [stdout] 170 | let thread_data = Arc::new(data_vec); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let mut threads = Vec::with_capacity(thread_count); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 182 | | thread_data: thread_data.clone(), [INFO] [stdout] 183 | | threads, [INFO] [stdout] 184 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 269 | pub unsafe fn create(&self, job: T) -> Result, Error> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | tls_job_pool.with(|tls| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 278 | | if let Some(pool) = tls.borrow_mut().as_mut() { [INFO] [stdout] 279 | | let (job_instance, handle) = pool.allocate(); [INFO] [stdout] 280 | | job_instance.store(job); [INFO] [stdout] ... | [INFO] [stdout] 287 | | Err(Error::InvalidThread) [INFO] [stdout] 288 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:315:27 [INFO] [stdout] | [INFO] [stdout] 306 | job: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | tls_job_pool.with(|tls| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 316 | | if let Some(pool) = tls.borrow_mut().as_mut() { [INFO] [stdout] 317 | | if let Some(parent_job) = pool.get_mut_ptr(parent.h) { [INFO] [stdout] 318 | | let (job_instance, handle) = pool.allocate(); [INFO] [stdout] ... | [INFO] [stdout] 329 | | Err(Error::InvalidThread) [INFO] [stdout] 330 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/thread.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 45 | debug_assert!(it.borrow().get() == usize::MAX); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Cell` does not implement `Borrow`, so calling `borrow` on `&Cell` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 45 - debug_assert!(it.borrow().get() == usize::MAX); [INFO] [stdout] 45 + debug_assert!(it.get() == usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:90:26 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn tls_set_thread_data(data: Arc>) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | TLS_THREAD_DATA.with(|tls| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 91 | | let mut thread_data = tls.borrow_mut(); [INFO] [stdout] 92 | | debug_assert!(thread_data.is_none()); [INFO] [stdout] 93 | | *thread_data = Some(data) [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 121 | pub(crate) fn new(data: std::sync::Arc>, index: usize) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | thread_handle: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:185:40 [INFO] [stdout] | [INFO] [stdout] 185 | TLS_RANDOM_GEN.with(|rand| rand.borrow_mut().gen::() % list.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jobsys` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b34a22ac367e41ed2875493d374aee63857dc23c0fe00a9d05c3f5a6b81bc52a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b34a22ac367e41ed2875493d374aee63857dc23c0fe00a9d05c3f5a6b81bc52a", kill_on_drop: false }` [INFO] [stdout] b34a22ac367e41ed2875493d374aee63857dc23c0fe00a9d05c3f5a6b81bc52a