[INFO] fetching crate jobslot 0.2.19... [INFO] checking jobslot-0.2.19 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jobslot 0.2.19 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate jobslot 0.2.19 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jobslot 0.2.19 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate jobslot 0.2.19 [INFO] tweaked toml for crates.io crate jobslot 0.2.19 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7dcfbb3638d249958dd004fe48bffaed01952fa1363e4028df3dfc55d3fe2e5a [INFO] running `Command { std: "docker" "start" "-a" "7dcfbb3638d249958dd004fe48bffaed01952fa1363e4028df3dfc55d3fe2e5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7dcfbb3638d249958dd004fe48bffaed01952fa1363e4028df3dfc55d3fe2e5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dcfbb3638d249958dd004fe48bffaed01952fa1363e4028df3dfc55d3fe2e5a", kill_on_drop: false }` [INFO] [stdout] 7dcfbb3638d249958dd004fe48bffaed01952fa1363e4028df3dfc55d3fe2e5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37f0b5fd81daa400ad551dcca86c46caf16ac949b4700f6956e907d50a6d7f8f [INFO] running `Command { std: "docker" "start" "-a" "37f0b5fd81daa400ad551dcca86c46caf16ac949b4700f6956e907d50a6d7f8f", kill_on_drop: false }` [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling derive_destructure2 v0.1.3 [INFO] [stderr] Checking jobslot v0.2.19 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:713:13 [INFO] [stdout] | [INFO] [stdout] 713 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:713:13 [INFO] [stdout] | [INFO] [stdout] 704 | Self::IncompatibleWithOlderMake(_) => f.write_str( [INFO] [stdout] | ---------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 711 | Self::IoError(io_error) => write!(f, "io error: {}", io_error), [INFO] [stdout] | ----------------------- matches some of the same values [INFO] [stdout] 712 | [INFO] [stdout] 713 | _ => unreachable!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:341:14 [INFO] [stdout] | [INFO] [stdout] 340 | fn new_inner(inner: imp::Client) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | Self(Arc::new(ClientInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 342 | | inner, [INFO] [stdout] 343 | | #[cfg(unix)] [INFO] [stdout] 344 | | acitve_try_acquire_client_count: Mutex::default(), [INFO] [stdout] 345 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 443 | Ok(Acquired::new(self, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:785:12 [INFO] [stdout] | [INFO] [stdout] 781 | pub fn into_inner(self) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 785 | Ok(self.destructure().0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jobslot` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "37f0b5fd81daa400ad551dcca86c46caf16ac949b4700f6956e907d50a6d7f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37f0b5fd81daa400ad551dcca86c46caf16ac949b4700f6956e907d50a6d7f8f", kill_on_drop: false }` [INFO] [stdout] 37f0b5fd81daa400ad551dcca86c46caf16ac949b4700f6956e907d50a6d7f8f