[INFO] fetching crate joat-repo 0.0.12... [INFO] checking joat-repo-0.0.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate joat-repo 0.0.12 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate joat-repo 0.0.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate joat-repo 0.0.12 [INFO] finished tweaking crates.io crate joat-repo 0.0.12 [INFO] tweaked toml for crates.io crate joat-repo 0.0.12 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate joat-repo 0.0.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a6f4dbf6825c706d1b3a4d525cde24bdd5abb305292dfc8c1844930f38e49c99 [INFO] running `Command { std: "docker" "start" "-a" "a6f4dbf6825c706d1b3a4d525cde24bdd5abb305292dfc8c1844930f38e49c99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a6f4dbf6825c706d1b3a4d525cde24bdd5abb305292dfc8c1844930f38e49c99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6f4dbf6825c706d1b3a4d525cde24bdd5abb305292dfc8c1844930f38e49c99", kill_on_drop: false }` [INFO] [stdout] a6f4dbf6825c706d1b3a4d525cde24bdd5abb305292dfc8c1844930f38e49c99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8358c8e2c2bfa7a5be89b67ba1ef7daf9045b4b6e32d8a85761d1befda8a068e [INFO] running `Command { std: "docker" "start" "-a" "8358c8e2c2bfa7a5be89b67ba1ef7daf9045b4b6e32d8a85761d1befda8a068e", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking fslock v0.2.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking serde_yaml v0.9.33 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking toml_edit v0.22.9 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking joatmon v0.0.34 [INFO] [stderr] Checking joat-repo v0.0.12 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 201 | pub(crate) fn other(e: E) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Self(RepoErrorImpl::Other(AnyhowError::new(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut lock_file = LockFile::open(&config.lock_path) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | / if lock_file [INFO] [stdout] 54 | | .try_lock_with_pid() [INFO] [stdout] 55 | | .map_err(|_e| RepoError::could_not_lock(&config.lock_path))? [INFO] [stdout] 56 | | { [INFO] [stdout] ... | [INFO] [stdout] 62 | | None [INFO] [stdout] 63 | | }, [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | Ok(match read_text_file(&p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `joat-repo` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 201 | pub(crate) fn other(e: E) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Self(RepoErrorImpl::Other(AnyhowError::new(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut lock_file = LockFile::open(&config.lock_path) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | / if lock_file [INFO] [stdout] 54 | | .try_lock_with_pid() [INFO] [stdout] 55 | | .map_err(|_e| RepoError::could_not_lock(&config.lock_path))? [INFO] [stdout] 56 | | { [INFO] [stdout] ... | [INFO] [stdout] 62 | | None [INFO] [stdout] 63 | | }, [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | Ok(match read_text_file(&p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `joat-repo` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8358c8e2c2bfa7a5be89b67ba1ef7daf9045b4b6e32d8a85761d1befda8a068e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8358c8e2c2bfa7a5be89b67ba1ef7daf9045b4b6e32d8a85761d1befda8a068e", kill_on_drop: false }` [INFO] [stdout] 8358c8e2c2bfa7a5be89b67ba1ef7daf9045b4b6e32d8a85761d1befda8a068e