[INFO] fetching crate jippigy 1.0.1... [INFO] checking jippigy-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jippigy 1.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate jippigy 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jippigy 1.0.1 [INFO] finished tweaking crates.io crate jippigy 1.0.1 [INFO] tweaked toml for crates.io crate jippigy 1.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate jippigy 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83c682f92c3aa384f24a9ecd35e015370c2ba88554de5b7b09e7f9e82ff349b2 [INFO] running `Command { std: "docker" "start" "-a" "83c682f92c3aa384f24a9ecd35e015370c2ba88554de5b7b09e7f9e82ff349b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83c682f92c3aa384f24a9ecd35e015370c2ba88554de5b7b09e7f9e82ff349b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83c682f92c3aa384f24a9ecd35e015370c2ba88554de5b7b09e7f9e82ff349b2", kill_on_drop: false }` [INFO] [stdout] 83c682f92c3aa384f24a9ecd35e015370c2ba88554de5b7b09e7f9e82ff349b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c276a8fb37aa7603b05b19290330ede071dc5b785fb2602631cc99a05153cee6 [INFO] running `Command { std: "docker" "start" "-a" "c276a8fb37aa7603b05b19290330ede071dc5b785fb2602631cc99a05153cee6", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Compiling turbojpeg-sys v1.0.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking img-parts v0.3.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking image-compare v0.3.1 [INFO] [stderr] Checking turbojpeg v1.1.0 [INFO] [stderr] Checking jippigy v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 58 | let original_img_parts = match Jpeg::from_bytes(self.original_bytes.into()) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Err(e) => return Err(error::Error::ImgPartError(e.to_string())), [INFO] [stdout] 60 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | }; [INFO] [stdout] 62 | let exif = match original_img_parts.exif().ok_or(error::Error::ImgPartError( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | }; [INFO] [stdout] 71 | let icc_profile = match original_img_parts [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | }; [INFO] [stdout] 82 | let mut compressed_img_part = match Jpeg::from_bytes(self.compressed_bytes.into()) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Err(e) => return Err(error::Error::ImgPartError(e.to_string())), [INFO] [stdout] 84 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | with_exif_preserved: compressed_img_part.encoder().bytes().to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jippigy` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 58 | let original_img_parts = match Jpeg::from_bytes(self.original_bytes.into()) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Err(e) => return Err(error::Error::ImgPartError(e.to_string())), [INFO] [stdout] 60 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | }; [INFO] [stdout] 62 | let exif = match original_img_parts.exif().ok_or(error::Error::ImgPartError( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | }; [INFO] [stdout] 71 | let icc_profile = match original_img_parts [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | }; [INFO] [stdout] 82 | let mut compressed_img_part = match Jpeg::from_bytes(self.compressed_bytes.into()) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Err(e) => return Err(error::Error::ImgPartError(e.to_string())), [INFO] [stdout] 84 | Ok(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | with_exif_preserved: compressed_img_part.encoder().bytes().to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jippigy` (lib) due to 2 previous errors [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "c276a8fb37aa7603b05b19290330ede071dc5b785fb2602631cc99a05153cee6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c276a8fb37aa7603b05b19290330ede071dc5b785fb2602631cc99a05153cee6", kill_on_drop: false }` [INFO] [stdout] c276a8fb37aa7603b05b19290330ede071dc5b785fb2602631cc99a05153cee6