[INFO] fetching crate jay-config 1.3.0... [INFO] checking jay-config-1.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jay-config 1.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate jay-config 1.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jay-config 1.3.0 [INFO] finished tweaking crates.io crate jay-config 1.3.0 [INFO] tweaked toml for crates.io crate jay-config 1.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 663c14fe39735dc49a2c3ae527533bee9bb09f6f0537af3bd9b3b496beb25a37 [INFO] running `Command { std: "docker" "start" "-a" "663c14fe39735dc49a2c3ae527533bee9bb09f6f0537af3bd9b3b496beb25a37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "663c14fe39735dc49a2c3ae527533bee9bb09f6f0537af3bd9b3b496beb25a37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "663c14fe39735dc49a2c3ae527533bee9bb09f6f0537af3bd9b3b496beb25a37", kill_on_drop: false }` [INFO] [stdout] 663c14fe39735dc49a2c3ae527533bee9bb09f6f0537af3bd9b3b496beb25a37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c224fc2eb0c0de72cb9a8bf23be13771896ac3e9e75749f0b0e9586cbbaa2747 [INFO] running `Command { std: "docker" "start" "-a" "c224fc2eb0c0de72cb9a8bf23be13771896ac3e9e75749f0b0e9586cbbaa2747", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling uapi v0.2.13 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking error_reporter v1.0.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling uapi-proc v0.0.5 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking jay-config v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 57 | fn cb(f: F) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Rc::new(RefCell::new(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 61 | fn run_cb(name: &str, cb: &Callback, t: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | match cb.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 156 | unsafe fn with_client T>(data: *const u8, f: F) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | CLIENT.with(|cell| { [INFO] [stdout] | _________________^ [INFO] [stdout] 167 | | let client = data as *const Client; [INFO] [stdout] 168 | | Rc::increment_strong_count(client); [INFO] [stdout] 169 | | let client = Rc::from_raw(client); [INFO] [stdout] ... | [INFO] [stdout] 172 | | f(&client) [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 348 | fn with_response(&self, f: F) -> Response { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 349 | f(); [INFO] [stdout] 350 | self.response.borrow_mut().pop().unwrap_or(Response::None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:1227:18 [INFO] [stdout] | [INFO] [stdout] 1222 | let cb = if kh.cb_mask & unmasked_mods == mods { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1227 | (mem::take(&mut kh.latched), cb) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(t: T) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Ok(Self::new_(t)?) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 68 | fn new_(t: T) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | id: PollableIdWrapper { id }, [INFO] [stdout] 79 | | t: Some(t), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:71:44 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|e| AsyncError::GetFl(io::Error::from_raw_os_error(e.0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:73:44 [INFO] [stdout] | [INFO] [stdout] 73 | .map_err(|e| AsyncError::SetFl(io::Error::from_raw_os_error(e.0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 57 | fn cb(f: F) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Rc::new(RefCell::new(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 61 | fn run_cb(name: &str, cb: &Callback, t: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | match cb.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 156 | unsafe fn with_client T>(data: *const u8, f: F) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | CLIENT.with(|cell| { [INFO] [stdout] | _________________^ [INFO] [stdout] 167 | | let client = data as *const Client; [INFO] [stdout] 168 | | Rc::increment_strong_count(client); [INFO] [stdout] 169 | | let client = Rc::from_raw(client); [INFO] [stdout] ... | [INFO] [stdout] 172 | | f(&client) [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 348 | fn with_response(&self, f: F) -> Response { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 349 | f(); [INFO] [stdout] 350 | self.response.borrow_mut().pop().unwrap_or(Response::None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/_private/client.rs:1227:18 [INFO] [stdout] | [INFO] [stdout] 1222 | let cb = if kh.cb_mask & unmasked_mods == mods { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1227 | (mem::take(&mut kh.latched), cb) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(t: T) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Ok(Self::new_(t)?) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 68 | fn new_(t: T) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | id: PollableIdWrapper { id }, [INFO] [stdout] 79 | | t: Some(t), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:71:44 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|e| AsyncError::GetFl(io::Error::from_raw_os_error(e.0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:73:44 [INFO] [stdout] | [INFO] [stdout] 73 | .map_err(|e| AsyncError::SetFl(io::Error::from_raw_os_error(e.0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jay-config` (lib test) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jay-config` (lib) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "c224fc2eb0c0de72cb9a8bf23be13771896ac3e9e75749f0b0e9586cbbaa2747", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c224fc2eb0c0de72cb9a8bf23be13771896ac3e9e75749f0b0e9586cbbaa2747", kill_on_drop: false }` [INFO] [stdout] c224fc2eb0c0de72cb9a8bf23be13771896ac3e9e75749f0b0e9586cbbaa2747