[INFO] fetching crate java-signatures 0.1.0... [INFO] checking java-signatures-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate java-signatures 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate java-signatures 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate java-signatures 0.1.0 [INFO] finished tweaking crates.io crate java-signatures 0.1.0 [INFO] tweaked toml for crates.io crate java-signatures 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34604eb01e355544212545fce84673ddb54e0bf3b84fdf2f8bd6b839741b8233 [INFO] running `Command { std: "docker" "start" "-a" "34604eb01e355544212545fce84673ddb54e0bf3b84fdf2f8bd6b839741b8233", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34604eb01e355544212545fce84673ddb54e0bf3b84fdf2f8bd6b839741b8233", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34604eb01e355544212545fce84673ddb54e0bf3b84fdf2f8bd6b839741b8233", kill_on_drop: false }` [INFO] [stdout] 34604eb01e355544212545fce84673ddb54e0bf3b84fdf2f8bd6b839741b8233 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4217d0807bbd6292627ee86fa169d66c35d5d94b4d01e29101c2d7a0012d08c [INFO] running `Command { std: "docker" "start" "-a" "a4217d0807bbd6292627ee86fa169d66c35d5d94b4d01e29101c2d7a0012d08c", kill_on_drop: false }` [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking java-signatures v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking cafebabe v0.7.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:24 [INFO] [stdout] | [INFO] [stdout] 142 | fn from_internal(s: &'a str, internal: internal::SimpleClassType) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | type_args: internal [INFO] [stdout] | ________________________^ [INFO] [stdout] 146 | | .1 [INFO] [stdout] 147 | | .into_iter() [INFO] [stdout] 148 | | .map(|ta| match ta { [INFO] [stdout] ... | [INFO] [stdout] 159 | | }) [INFO] [stdout] 160 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:186:19 [INFO] [stdout] | [INFO] [stdout] 184 | fn from_internal(s: &'a str, internal: internal::ClassType) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Self { [INFO] [stdout] 186 | base: SimpleClassType::from_internal(s, internal.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 184 | fn from_internal(s: &'a str, internal: internal::ClassType) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | nested: internal [INFO] [stdout] | _____________________^ [INFO] [stdout] 188 | | .1 [INFO] [stdout] 189 | | .into_iter() [INFO] [stdout] 190 | | .map(|ty| SimpleClassType::from_internal(s, ty)) [INFO] [stdout] 191 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:26 [INFO] [stdout] | [INFO] [stdout] 247 | fn from_internal(s: &'a str, internal: internal::TypeParameter) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | class_bound: internal [INFO] [stdout] | __________________________^ [INFO] [stdout] 251 | | .class_bound [INFO] [stdout] 252 | | .map(|bound| ReferenceType::from_internal(s, bound)), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:253:27 [INFO] [stdout] | [INFO] [stdout] 247 | fn from_internal(s: &'a str, internal: internal::TypeParameter) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | iface_bounds: internal [INFO] [stdout] | ___________________________^ [INFO] [stdout] 254 | | .iface_bounds [INFO] [stdout] 255 | | .into_iter() [INFO] [stdout] 256 | | .map(|bound| ReferenceType::from_internal(s, bound)) [INFO] [stdout] 257 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:372:30 [INFO] [stdout] | [INFO] [stdout] 372 | .map(|ty| FieldSignature(ReferenceType::from_internal(s, ty))) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:394:22 [INFO] [stdout] | [INFO] [stdout] 393 | .map(|parsed| ClassSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | type_params: parsed [INFO] [stdout] | ______________________^ [INFO] [stdout] 395 | | .type_params [INFO] [stdout] 396 | | .into_iter() [INFO] [stdout] 397 | | .map(|p| TypeParameter::from_internal(s, p)) [INFO] [stdout] 398 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:399:22 [INFO] [stdout] | [INFO] [stdout] 393 | .map(|parsed| ClassSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | super_class: ClassType::from_internal(s, parsed.super_class), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:400:23 [INFO] [stdout] | [INFO] [stdout] 393 | .map(|parsed| ClassSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | super_ifaces: parsed [INFO] [stdout] | _______________________^ [INFO] [stdout] 401 | | .super_ifaces [INFO] [stdout] 402 | | .into_iter() [INFO] [stdout] 403 | | .map(|ty| ClassType::from_internal(s, ty)) [INFO] [stdout] 404 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:425:22 [INFO] [stdout] | [INFO] [stdout] 424 | .map(|parsed| MethodSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | type_params: parsed [INFO] [stdout] | ______________________^ [INFO] [stdout] 426 | | .type_params [INFO] [stdout] 427 | | .into_iter() [INFO] [stdout] 428 | | .map(|p| TypeParameter::from_internal(s, p)) [INFO] [stdout] 429 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:430:21 [INFO] [stdout] | [INFO] [stdout] 424 | .map(|parsed| MethodSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | parameters: parsed [INFO] [stdout] | _____________________^ [INFO] [stdout] 431 | | .parameters [INFO] [stdout] 432 | | .into_iter() [INFO] [stdout] 433 | | .map(|p| JavaType::from_internal(s, p)) [INFO] [stdout] 434 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:435:17 [INFO] [stdout] | [INFO] [stdout] 424 | .map(|parsed| MethodSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | result: ResultType::from_internal(s, parsed.result), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:436:17 [INFO] [stdout] | [INFO] [stdout] 424 | .map(|parsed| MethodSignature { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | throws: parsed [INFO] [stdout] | _________________^ [INFO] [stdout] 437 | | .throws [INFO] [stdout] 438 | | .into_iter() [INFO] [stdout] 439 | | .map(|ty| ThrowsType::from_internal(s, ty)) [INFO] [stdout] 440 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:315:57 [INFO] [stdout] | [INFO] [stdout] 315 | .map(|ty| maybe_as_array(dimension, ReferenceType::Class(ty))); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:548:8 [INFO] [stdout] | [INFO] [stdout] 539 | let (type_params, next) = consume_type_parameters(chars)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 540 | consume_next_expected("MethodSignature", next, '(')?; [INFO] [stdout] 541 | let (parameters, next) = consume_method_parameters(chars)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | let result = match next { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | let throws = consume_throws_signature(chars)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | Ok(MethodSignature { [INFO] [stdout] | ________^ [INFO] [stdout] 549 | | type_params, [INFO] [stdout] 550 | | parameters, [INFO] [stdout] 551 | | result, [INFO] [stdout] 552 | | throws, [INFO] [stdout] 553 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `java-signatures` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a4217d0807bbd6292627ee86fa169d66c35d5d94b4d01e29101c2d7a0012d08c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4217d0807bbd6292627ee86fa169d66c35d5d94b4d01e29101c2d7a0012d08c", kill_on_drop: false }` [INFO] [stdout] a4217d0807bbd6292627ee86fa169d66c35d5d94b4d01e29101c2d7a0012d08c