[INFO] fetching crate java-properties 2.0.0... [INFO] checking java-properties-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate java-properties 2.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate java-properties 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate java-properties 2.0.0 [INFO] finished tweaking crates.io crate java-properties 2.0.0 [INFO] tweaked toml for crates.io crate java-properties 2.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03bdaf71237de321ebbef2a5908ffb7050227805a926d30cd978962a13e35f4e [INFO] running `Command { std: "docker" "start" "-a" "03bdaf71237de321ebbef2a5908ffb7050227805a926d30cd978962a13e35f4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03bdaf71237de321ebbef2a5908ffb7050227805a926d30cd978962a13e35f4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03bdaf71237de321ebbef2a5908ffb7050227805a926d30cd978962a13e35f4e", kill_on_drop: false }` [INFO] [stdout] 03bdaf71237de321ebbef2a5908ffb7050227805a926d30cd978962a13e35f4e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6992fe27fd5a7a0309d4ba56c51bdd018b459a5f0a88d9264aef29018cf29e12 [INFO] running `Command { std: "docker" "start" "-a" "6992fe27fd5a7a0309d4ba56c51bdd018b459a5f0a88d9264aef29018cf29e12", kill_on_drop: false }` [INFO] [stderr] Checking java-properties v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 133 | fn from(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | PropertiesError::new("I/O error", Some(Box::new(e)), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:20 [INFO] [stdout] | [INFO] [stdout] 227 | fn new(reader: R, encoding: &'static Encoding) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | NaturalLines { [INFO] [stdout] 229 | chars: DecodeIter::new(reader, encoding).peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:580:20 [INFO] [stdout] | [INFO] [stdout] 578 | pub fn new_with_encoding(input: R, encoding: &'static Encoding) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | PropertiesIter { [INFO] [stdout] 580 | lines: LogicalLines::new(NaturalLines::new(input, encoding)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:719:47 [INFO] [stdout] | [INFO] [stdout] 718 | self.writer.write_all(&self.buffer).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 719 | PropertiesError::new("I/O error", Some(Box::new(e)), Some(self.lines_written)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:781:21 [INFO] [stdout] | [INFO] [stdout] 776 | pub fn new_with_encoding(writer: W, encoding: &'static Encoding) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 781 | writer: EncodingWriter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 782 | | writer, [INFO] [stdout] 783 | | lines_written: 0, [INFO] [stdout] 784 | | encoder: encoding.new_encoder(), [INFO] [stdout] 785 | | // It's important that we start with a non-zero capacity, since we double it as needed. [INFO] [stdout] 786 | | buffer: Vec::with_capacity(256), [INFO] [stdout] 787 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `java-properties` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 133 | fn from(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | PropertiesError::new("I/O error", Some(Box::new(e)), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:20 [INFO] [stdout] | [INFO] [stdout] 227 | fn new(reader: R, encoding: &'static Encoding) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | NaturalLines { [INFO] [stdout] 229 | chars: DecodeIter::new(reader, encoding).peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:580:20 [INFO] [stdout] | [INFO] [stdout] 578 | pub fn new_with_encoding(input: R, encoding: &'static Encoding) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | PropertiesIter { [INFO] [stdout] 580 | lines: LogicalLines::new(NaturalLines::new(input, encoding)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:719:47 [INFO] [stdout] | [INFO] [stdout] 718 | self.writer.write_all(&self.buffer).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 719 | PropertiesError::new("I/O error", Some(Box::new(e)), Some(self.lines_written)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:781:21 [INFO] [stdout] | [INFO] [stdout] 776 | pub fn new_with_encoding(writer: W, encoding: &'static Encoding) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 781 | writer: EncodingWriter { [INFO] [stdout] | _____________________^ [INFO] [stdout] 782 | | writer, [INFO] [stdout] 783 | | lines_written: 0, [INFO] [stdout] 784 | | encoder: encoding.new_encoder(), [INFO] [stdout] 785 | | // It's important that we start with a non-zero capacity, since we double it as needed. [INFO] [stdout] 786 | | buffer: Vec::with_capacity(256), [INFO] [stdout] 787 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `java-properties` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "6992fe27fd5a7a0309d4ba56c51bdd018b459a5f0a88d9264aef29018cf29e12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6992fe27fd5a7a0309d4ba56c51bdd018b459a5f0a88d9264aef29018cf29e12", kill_on_drop: false }` [INFO] [stdout] 6992fe27fd5a7a0309d4ba56c51bdd018b459a5f0a88d9264aef29018cf29e12