[INFO] fetching crate jact 0.4.2... [INFO] checking jact-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jact 0.4.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate jact 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jact 0.4.2 [INFO] finished tweaking crates.io crate jact 0.4.2 [INFO] tweaked toml for crates.io crate jact 0.4.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate jact 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a82f933dccac396001affa6389e1c5ba80ef7e32fbf255618d1509f1ee16737 [INFO] running `Command { std: "docker" "start" "-a" "1a82f933dccac396001affa6389e1c5ba80ef7e32fbf255618d1509f1ee16737", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a82f933dccac396001affa6389e1c5ba80ef7e32fbf255618d1509f1ee16737", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a82f933dccac396001affa6389e1c5ba80ef7e32fbf255618d1509f1ee16737", kill_on_drop: false }` [INFO] [stdout] 1a82f933dccac396001affa6389e1c5ba80ef7e32fbf255618d1509f1ee16737 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5436748c85cd1250cddf4bc9cb1b6303a1ca8a3599dc2576698a94572152f34 [INFO] running `Command { std: "docker" "start" "-a" "c5436748c85cd1250cddf4bc9cb1b6303a1ca8a3599dc2576698a94572152f34", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking cron v0.12.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking jact v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `stop` is never used [INFO] [stdout] --> src/job.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 107 | pub trait Job { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 110 | async fn stop(&mut self) -> (); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:154:56 [INFO] [stdout] | [INFO] [stdout] 154 | async fn run(&mut self, jobs: JobsSchedulerLocked) { [INFO] [stdout] | _____________________________-------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | | let job_copy = self.clone(); [INFO] [stdout] 156 | | //let job_scheduler_copy = jobs.clone(); [INFO] [stdout] 157 | | tokio::task::spawn(async move { [INFO] [stdout] ... | [INFO] [stdout] 232 | | }); [INFO] [stdout] 233 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 263 | fn make_new_cron_job(schedule: &str, run: T) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(Arc::new(RwLock::new(JobType::CronJob(JobHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 271 | | schedule: Some(schedule), [INFO] [stdout] 272 | | run_async: Arc::new(Mutex::new(run)), [INFO] [stdout] 273 | | time_til_next: None, [INFO] [stdout] 274 | | job_id: Uuid::new_v4(), [INFO] [stdout] 275 | | stopped: false })))) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 302 | fn make_one_shot_job(duration: Duration, run_async: Arc>) -> Result [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | Ok(Arc::new(RwLock::new(JobType::OneShot(JobHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 308 | | schedule: None, [INFO] [stdout] 309 | | run_async, [INFO] [stdout] 310 | | time_til_next: Some(duration), [INFO] [stdout] 311 | | job_id: Uuid::new_v4(), [INFO] [stdout] 312 | | stopped: false })))) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:332:48 [INFO] [stdout] | [INFO] [stdout] 326 | fn new_one_shot(duration: Duration, run: T) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | JobLocked::make_one_shot_job(duration, Arc::new(Mutex::new(run))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 335 | fn make_new_one_shot_at_an_instant(instant: std::time::Instant, run_async: Arc>) -> Result [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | Ok(Arc::new(RwLock::new(JobType::OneShot(JobHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 346 | | schedule: None, [INFO] [stdout] 347 | | run_async, [INFO] [stdout] 348 | | time_til_next: Some(job_duration), [INFO] [stdout] 349 | | job_id: Uuid::new_v4(), [INFO] [stdout] 350 | | stopped: false })))) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:369:61 [INFO] [stdout] | [INFO] [stdout] 363 | fn new_one_shot_at_instant(instant: std::time::Instant, run: T) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | JobLocked::make_new_one_shot_at_an_instant(instant, Arc::new(Mutex::new(run))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 372 | fn make_new_repeated(duration: Duration, run_async: Arc>) -> Result [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | let job = JobHandle { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | Ok(Arc::new(RwLock::new(JobType::Repeated(job)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:405:48 [INFO] [stdout] | [INFO] [stdout] 399 | fn new_repeated(duration: Duration, run: T) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | JobLocked::make_new_repeated(duration, Arc::new(Mutex::new(run))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job_scheduler.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 80 | let r = JobScheduler { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Arc::new(RwLock::new(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job_scheduler.rs:95:69 [INFO] [stdout] | [INFO] [stdout] 95 | async fn add(&mut self, job: JobLocked) -> Result<(), JobError> { [INFO] [stdout] | _____________________________--------------__________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | | { [INFO] [stdout] 97 | | let mut self_w = self.write().await; [INFO] [stdout] 98 | | let uuid; [INFO] [stdout] ... | [INFO] [stdout] 115 | | Ok(()) [INFO] [stdout] 116 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jact` (lib) due to 11 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c5436748c85cd1250cddf4bc9cb1b6303a1ca8a3599dc2576698a94572152f34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5436748c85cd1250cddf4bc9cb1b6303a1ca8a3599dc2576698a94572152f34", kill_on_drop: false }` [INFO] [stdout] c5436748c85cd1250cddf4bc9cb1b6303a1ca8a3599dc2576698a94572152f34