[INFO] fetching crate jack 0.11.4... [INFO] checking jack-0.11.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate jack 0.11.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate jack 0.11.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jack 0.11.4 [INFO] finished tweaking crates.io crate jack 0.11.4 [INFO] tweaked toml for crates.io crate jack 0.11.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate jack 0.11.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8a9260b8c4455d6a637bde8bc56b60e0fcdd4733472f5f91c13cd0c58b7585d [INFO] running `Command { std: "docker" "start" "-a" "f8a9260b8c4455d6a637bde8bc56b60e0fcdd4733472f5f91c13cd0c58b7585d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8a9260b8c4455d6a637bde8bc56b60e0fcdd4733472f5f91c13cd0c58b7585d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8a9260b8c4455d6a637bde8bc56b60e0fcdd4733472f5f91c13cd0c58b7585d", kill_on_drop: false }` [INFO] [stdout] f8a9260b8c4455d6a637bde8bc56b60e0fcdd4733472f5f91c13cd0c58b7585d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0fd8f6a0616ec31d6624695310572f491a2fd87e5198bdcc64f636da48627f40 [INFO] running `Command { std: "docker" "start" "-a" "0fd8f6a0616ec31d6624695310572f491a2fd87e5198bdcc64f636da48627f40", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Compiling jack v0.11.4 (/opt/rustwide/workdir) [INFO] [stderr] Compiling jack-sys v0.5.1 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stdout] warning: field `2` is never read [INFO] [stdout] --> src/client/client_impl.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct Client( [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 36 | Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/async_client.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 108 | let _m = CREATE_OR_DESTROY_CLIENT_MUTEX.lock().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(*Box::from_raw(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jack` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `2` is never read [INFO] [stdout] --> src/client/client_impl.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct Client( [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 36 | Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `process_return_val` is never read [INFO] [stdout] --> src/client/test_callback.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Counter { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 9 | pub process_return_val: Control, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Counter` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/async_client.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 108 | let _m = CREATE_OR_DESTROY_CLIENT_MUTEX.lock().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(*Box::from_raw(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/test_callback.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 77 | let c = open_test_client(name); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | c.activate_async(Counter::default(), Counter::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/port/midi.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 273 | fn new(client: &Client, stream: Vec, collector: F) -> IterTest { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | midi_in: client.register_port("in", MidiIn::default()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/port/midi.rs:279:27 [INFO] [stdout] | [INFO] [stdout] 273 | fn new(client: &Client, stream: Vec, collector: F) -> IterTest { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | midi_out: client.register_port("out", MidiOut::default()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jack` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0fd8f6a0616ec31d6624695310572f491a2fd87e5198bdcc64f636da48627f40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fd8f6a0616ec31d6624695310572f491a2fd87e5198bdcc64f636da48627f40", kill_on_drop: false }` [INFO] [stdout] 0fd8f6a0616ec31d6624695310572f491a2fd87e5198bdcc64f636da48627f40