[INFO] fetching crate j-pls 0.4.2... [INFO] checking j-pls-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate j-pls 0.4.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate j-pls 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate j-pls 0.4.2 [INFO] finished tweaking crates.io crate j-pls 0.4.2 [INFO] tweaked toml for crates.io crate j-pls 0.4.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate j-pls 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be52c74efe3bdda4e0934a5eed59a49e3847fb0be5149a603909d4c9571332fb [INFO] running `Command { std: "docker" "start" "-a" "be52c74efe3bdda4e0934a5eed59a49e3847fb0be5149a603909d4c9571332fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be52c74efe3bdda4e0934a5eed59a49e3847fb0be5149a603909d4c9571332fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be52c74efe3bdda4e0934a5eed59a49e3847fb0be5149a603909d4c9571332fb", kill_on_drop: false }` [INFO] [stdout] be52c74efe3bdda4e0934a5eed59a49e3847fb0be5149a603909d4c9571332fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a3b17105fbaf49058f72d49b1af4bcb729dc84fa1a2767116530a9186ed81fa [INFO] running `Command { std: "docker" "start" "-a" "7a3b17105fbaf49058f72d49b1af4bcb729dc84fa1a2767116530a9186ed81fa", kill_on_drop: false }` [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking global-static v0.1.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking j-pls v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `marker::PhantomData` and `process::Termination` [INFO] [stdout] --> src/main.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{env, marker::PhantomData, process::Termination}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `marker::PhantomData` and `process::Termination` [INFO] [stdout] --> src/main.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{env, marker::PhantomData, process::Termination}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Debug` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fmt::Debug; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Chars` and `error::Error` [INFO] [stdout] --> src/parse.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{str::{Chars, Lines}, fmt::Display, iter::Peekable, error::Error, io::Write}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Chars` and `error::Error` [INFO] [stdout] --> src/parse.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{str::{Chars, Lines}, fmt::Display, iter::Peekable, error::Error, io::Write}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RunError` [INFO] [stdout] --> src/parse.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::cmd::{Rule, RunError}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RunError` [INFO] [stdout] --> src/parse.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::cmd::{Rule, RunError}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Write` [INFO] [stdout] --> src/parse.rs:1:76 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{str::{Chars, Lines}, fmt::Display, iter::Peekable, error::Error, io::Write}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `global` [INFO] [stdout] --> src/parse.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn rule1line(str: &str, global: bool) -> Result { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_global` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Write` [INFO] [stdout] --> src/parse.rs:1:76 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{str::{Chars, Lines}, fmt::Display, iter::Peekable, error::Error, io::Write}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `global` [INFO] [stdout] --> src/parse.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn rule1line(str: &str, global: bool) -> Result { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_global` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `NoRule` and `MissingRuleFile` are never constructed [INFO] [stdout] --> src/cmd.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 143 | pub enum RunError { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 146 | NoRule, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 147 | DuplicateRule(String), [INFO] [stdout] 148 | MissingRuleFile(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RunError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | Err(RunError::UnknownRule(cmd.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `NoRule` and `MissingRuleFile` are never constructed [INFO] [stdout] --> src/cmd.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 143 | pub enum RunError { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 146 | NoRule, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 147 | DuplicateRule(String), [INFO] [stdout] 148 | MissingRuleFile(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RunError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | Err(RunError::UnknownRule(cmd.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `j-pls` (bin "pls" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `j-pls` (bin "pls") due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7a3b17105fbaf49058f72d49b1af4bcb729dc84fa1a2767116530a9186ed81fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a3b17105fbaf49058f72d49b1af4bcb729dc84fa1a2767116530a9186ed81fa", kill_on_drop: false }` [INFO] [stdout] 7a3b17105fbaf49058f72d49b1af4bcb729dc84fa1a2767116530a9186ed81fa