[INFO] fetching crate itconfig 1.1.1... [INFO] checking itconfig-1.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate itconfig 1.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate itconfig 1.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate itconfig 1.1.1 [INFO] finished tweaking crates.io crate itconfig 1.1.1 [INFO] tweaked toml for crates.io crate itconfig 1.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6452051993bd4ad8e2e2a768d41a112df87dc555eddfc0e79ec1886c555106bc [INFO] running `Command { std: "docker" "start" "-a" "6452051993bd4ad8e2e2a768d41a112df87dc555eddfc0e79ec1886c555106bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6452051993bd4ad8e2e2a768d41a112df87dc555eddfc0e79ec1886c555106bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6452051993bd4ad8e2e2a768d41a112df87dc555eddfc0e79ec1886c555106bc", kill_on_drop: false }` [INFO] [stdout] 6452051993bd4ad8e2e2a768d41a112df87dc555eddfc0e79ec1886c555106bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41e226cf99ef0168f4542bc4e2847719fce6be3c5ddf3fb6ee7f72a90c5fe1a5 [INFO] running `Command { std: "docker" "start" "-a" "41e226cf99ef0168f4542bc4e2847719fce6be3c5ddf3fb6ee7f72a90c5fe1a5", kill_on_drop: false }` [INFO] [stderr] Checking itconfig v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_env.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn get_env_or_default(env_name: &str, default: D) -> T [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | get_env_or(env_name, |_| Ok(default.to_env_string())).unwrap_or_else(make_panic) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_env.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn get_env_or_set_default(env_name: &str, default: D) -> T [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | / get_env_or(env_name, |_| { [INFO] [stdout] 136 | | let val = default.to_env_string(); [INFO] [stdout] 137 | | env::set_var(env_name, val.as_str()); [INFO] [stdout] 138 | | Ok(val) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_vec_env.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn get_vec_env_or_default(env_name: &str, sep: &str, default: Vec) -> Vec [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | get_vec_env_or(env_name, sep, |_| Ok(vec_to_env_strings(default))).unwrap_or_else(make_panic) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_vec_env.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn get_vec_env_or_set_default(env_name: &str, sep: &str, default: Vec) -> Vec [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | / get_vec_env_or(env_name, sep, |_| { [INFO] [stdout] 157 | | let default_env_strings = vec_to_env_strings(default); [INFO] [stdout] 158 | | let env_val = join(&default_env_strings, sep); [INFO] [stdout] 159 | | env::set_var(env_name, env_val.as_str()); [INFO] [stdout] 160 | | Ok(default_env_strings) [INFO] [stdout] 161 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn vec_to_env_strings(values: Vec) -> Vec [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | values.into_iter().map(EnvString::from).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `itconfig` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_env.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn get_env_or_default(env_name: &str, default: D) -> T [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | get_env_or(env_name, |_| Ok(default.to_env_string())).unwrap_or_else(make_panic) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_env.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn get_env_or_set_default(env_name: &str, default: D) -> T [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | / get_env_or(env_name, |_| { [INFO] [stdout] 136 | | let val = default.to_env_string(); [INFO] [stdout] 137 | | env::set_var(env_name, val.as_str()); [INFO] [stdout] 138 | | Ok(val) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_vec_env.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn get_vec_env_or_default(env_name: &str, sep: &str, default: Vec) -> Vec [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | get_vec_env_or(env_name, sep, |_| Ok(vec_to_env_strings(default))).unwrap_or_else(make_panic) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get_vec_env.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn get_vec_env_or_set_default(env_name: &str, sep: &str, default: Vec) -> Vec [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | / get_vec_env_or(env_name, sep, |_| { [INFO] [stdout] 157 | | let default_env_strings = vec_to_env_strings(default); [INFO] [stdout] 158 | | let env_val = join(&default_env_strings, sep); [INFO] [stdout] 159 | | env::set_var(env_name, env_val.as_str()); [INFO] [stdout] 160 | | Ok(default_env_strings) [INFO] [stdout] 161 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub(crate) fn vec_to_env_strings(values: Vec) -> Vec [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | values.into_iter().map(EnvString::from).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `itconfig` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "41e226cf99ef0168f4542bc4e2847719fce6be3c5ddf3fb6ee7f72a90c5fe1a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41e226cf99ef0168f4542bc4e2847719fce6be3c5ddf3fb6ee7f72a90c5fe1a5", kill_on_drop: false }` [INFO] [stdout] 41e226cf99ef0168f4542bc4e2847719fce6be3c5ddf3fb6ee7f72a90c5fe1a5