[INFO] fetching crate isolated 0.2.0... [INFO] checking isolated-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate isolated 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate isolated 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config [INFO] started tweaking crates.io crate isolated 0.2.0 [INFO] finished tweaking crates.io crate isolated 0.2.0 [INFO] tweaked toml for crates.io crate isolated 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate isolated 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e439755a7aa6b25f1f0aa0e1b83a00e29a45a278ff9dd708810c04ed2d09623 [INFO] running `Command { std: "docker" "start" "-a" "3e439755a7aa6b25f1f0aa0e1b83a00e29a45a278ff9dd708810c04ed2d09623", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e439755a7aa6b25f1f0aa0e1b83a00e29a45a278ff9dd708810c04ed2d09623", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e439755a7aa6b25f1f0aa0e1b83a00e29a45a278ff9dd708810c04ed2d09623", kill_on_drop: false }` [INFO] [stdout] 3e439755a7aa6b25f1f0aa0e1b83a00e29a45a278ff9dd708810c04ed2d09623 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9725cc3122e50c6207a057c053cf20413156bf980a905f646f3319ee86c0ceb6 [INFO] running `Command { std: "docker" "start" "-a" "9725cc3122e50c6207a057c053cf20413156bf980a905f646f3319ee86c0ceb6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Checking rustc-demangle v0.1.19 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking object v0.25.3 [INFO] [stderr] Compiling backtrace v0.3.60 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking nix v0.21.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking addr2line v0.15.2 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking isolated v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn spawn(command: Command) -> nix::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let tmp = tempdir().expect("tempdir creation failed"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let old_hook = std::panic::take_hook(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let path = command.path; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let args = command.args; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Ok(Process { [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | id, [INFO] [stdout] 216 | | status: None, [INFO] [stdout] 217 | | resources: HeldResources { tmp }, [INFO] [stdout] 218 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new>(root_fs: P, path: &str) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let path = CString::new(path.as_bytes().to_vec()).expect("Nul byte in target path"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | path: path.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new>(root_fs: P, path: &str) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let path = CString::new(path.as_bytes().to_vec()).expect("Nul byte in target path"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | pre_pivot: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new>(root_fs: P, path: &str) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let path = CString::new(path.as_bytes().to_vec()).expect("Nul byte in target path"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | pre_exec: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isolated` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn spawn(command: Command) -> nix::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let tmp = tempdir().expect("tempdir creation failed"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let old_hook = std::panic::take_hook(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let path = command.path; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let args = command.args; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Ok(Process { [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | id, [INFO] [stdout] 216 | | status: None, [INFO] [stdout] 217 | | resources: HeldResources { tmp }, [INFO] [stdout] 218 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new>(root_fs: P, path: &str) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let path = CString::new(path.as_bytes().to_vec()).expect("Nul byte in target path"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self { [INFO] [stdout] 43 | path: path.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new>(root_fs: P, path: &str) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let path = CString::new(path.as_bytes().to_vec()).expect("Nul byte in target path"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | pre_pivot: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new>(root_fs: P, path: &str) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let path = CString::new(path.as_bytes().to_vec()).expect("Nul byte in target path"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | pre_exec: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isolated` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "9725cc3122e50c6207a057c053cf20413156bf980a905f646f3319ee86c0ceb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9725cc3122e50c6207a057c053cf20413156bf980a905f646f3319ee86c0ceb6", kill_on_drop: false }` [INFO] [stdout] 9725cc3122e50c6207a057c053cf20413156bf980a905f646f3319ee86c0ceb6