[INFO] fetching crate iso8583_rs 0.1.10... [INFO] checking iso8583_rs-0.1.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iso8583_rs 0.1.10 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate iso8583_rs 0.1.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iso8583_rs 0.1.10 [INFO] finished tweaking crates.io crate iso8583_rs 0.1.10 [INFO] tweaked toml for crates.io crate iso8583_rs 0.1.10 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-cipher v0.7.1 (latest: v0.99.99) [INFO] [stderr] Adding block-modes v0.5.0 (latest: v0.9.1) [INFO] [stderr] Adding block-padding v0.1.5 (latest: v0.3.3) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding des v0.4.0 (latest: v0.8.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hex-literal v0.2.2 (latest: v0.4.1) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding parking_lot v0.10.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.7.3 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding serde-value v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding simplelog v0.8.0 (latest: v0.12.2) [INFO] [stderr] Adding termcolor v1.1.3 (latest: v1.4.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding witchcraft-metrics v0.1.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c11fdb796f9ddbf3372c9c2fd3248d1bc5c6dfb0bd87e559a5a329be680818b5 [INFO] running `Command { std: "docker" "start" "-a" "c11fdb796f9ddbf3372c9c2fd3248d1bc5c6dfb0bd87e559a5a329be680818b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c11fdb796f9ddbf3372c9c2fd3248d1bc5c6dfb0bd87e559a5a329be680818b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c11fdb796f9ddbf3372c9c2fd3248d1bc5c6dfb0bd87e559a5a329be680818b5", kill_on_drop: false }` [INFO] [stdout] c11fdb796f9ddbf3372c9c2fd3248d1bc5c6dfb0bd87e559a5a329be680818b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e481a61d297b691f23502ac367fd0c67e6f1e4df8620169b2ad20a0598bd4625 [INFO] running `Command { std: "docker" "start" "-a" "e481a61d297b691f23502ac367fd0c67e6f1e4df8620169b2ad20a0598bd4625", kill_on_drop: false }` [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking rawslice v0.1.1 [INFO] [stderr] Checking hexdump v0.1.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking encoding8 v0.3.2 [INFO] [stderr] Checking serde-value v0.6.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking odds v0.4.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking block-cipher v0.7.1 [INFO] [stderr] Checking des v0.4.0 [INFO] [stderr] Checking block-modes v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Compiling hex-literal-impl v0.2.3 [INFO] [stderr] Checking hex-literal v0.2.2 [INFO] [stderr] Checking exponential-decay-histogram v0.1.11 [INFO] [stderr] Checking simplelog v0.8.0 [INFO] [stderr] Checking witchcraft-metrics v0.1.1 [INFO] [stderr] Checking iso8583_rs v0.1.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `log` [INFO] [stdout] --> src/iso8583/test.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | use log; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:102:81 [INFO] [stdout] | [INFO] [stdout] 102 | let actual_pin = b1.get(2 as usize..(2 + pin_len) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:115:88 [INFO] [stdout] | [INFO] [stdout] 115 | let actual_pin = b1.get(2 as usize..(2 + (pin_len - 16)) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:127:88 [INFO] [stdout] | [INFO] [stdout] 127 | let actual_pin = b1.get(2 as usize..(2 + (pin_len - 32)) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:142:88 [INFO] [stdout] | [INFO] [stdout] 142 | let actual_pin = b1.get(2 as usize..(2 + (pin_len - 48)) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iso8583/client.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 23 | let mli: Box; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | _tcp_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/iso8583/iso_spec.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 35 | Err(e)=> panic!(e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 35 | Err(e)=> panic!("{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iso8583/server.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new<'a>(host_port: String, spec: &'static Spec, mli_type: MLIType, msg_processor: Box) -> Result>; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match host_port.to_socket_addrs() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iso8583/server.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 91 | let server = ISOServer { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | std::thread::spawn(move || { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 101 | | let listener = std::net::TcpListener::bind(server.sock_addr.as_slice()).unwrap(); [INFO] [stdout] 102 | | [INFO] [stdout] 103 | | for stream in listener.incoming() { [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/iso8583/yaml_de.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | / &ychildren.iter().for_each(|f| { [INFO] [stdout] 50 | | children.push(Into::>::into(f)); [INFO] [stdout] 51 | | }); [INFO] [stdout] | |______________________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 49 | let _ = &ychildren.iter().for_each(|f| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iso8583_rs` (lib) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:142:32 [INFO] [stdout] | [INFO] [stdout] 142 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 142 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:157:32 [INFO] [stdout] | [INFO] [stdout] 157 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 157 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:173:32 [INFO] [stdout] | [INFO] [stdout] 173 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 173 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 188 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 188 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:204:32 [INFO] [stdout] | [INFO] [stdout] 204 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 204 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:219:32 [INFO] [stdout] | [INFO] [stdout] 219 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 219 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/mac.rs:234:32 [INFO] [stdout] | [INFO] [stdout] 234 | assert!(false, e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 234 | assert!(false, "{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:102:81 [INFO] [stdout] | [INFO] [stdout] 102 | let actual_pin = b1.get(2 as usize..(2 + pin_len) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:115:88 [INFO] [stdout] | [INFO] [stdout] 115 | let actual_pin = b1.get(2 as usize..(2 + (pin_len - 16)) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:127:88 [INFO] [stdout] | [INFO] [stdout] 127 | let actual_pin = b1.get(2 as usize..(2 + (pin_len - 32)) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/crypto/pin.rs:142:88 [INFO] [stdout] | [INFO] [stdout] 142 | let actual_pin = b1.get(2 as usize..(2 + (pin_len - 48)) as usize).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `KEY` should have a snake case name [INFO] [stdout] --> src/crypto/pin.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | let KEY: &Vec = &hex::decode(&KEY_STR).unwrap(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:204:40 [INFO] [stdout] | [INFO] [stdout] 204 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 204 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:209:32 [INFO] [stdout] | [INFO] [stdout] 209 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 209 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:220:40 [INFO] [stdout] | [INFO] [stdout] 220 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 220 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:225:32 [INFO] [stdout] | [INFO] [stdout] 225 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 225 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `KEY` should have a snake case name [INFO] [stdout] --> src/crypto/pin.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | let KEY: &Vec = &hex::decode(&KEY_STR).unwrap(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:240:40 [INFO] [stdout] | [INFO] [stdout] 240 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 240 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:245:32 [INFO] [stdout] | [INFO] [stdout] 245 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 245 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `KEY` should have a snake case name [INFO] [stdout] --> src/crypto/pin.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | let KEY: &Vec = &hex::decode(KEY_STR).unwrap(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:263:40 [INFO] [stdout] | [INFO] [stdout] 263 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 263 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:268:32 [INFO] [stdout] | [INFO] [stdout] 268 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 268 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `KEY` should have a snake case name [INFO] [stdout] --> src/crypto/pin.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | let KEY: &Vec = &hex::decode(KEY_STR).unwrap(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:283:40 [INFO] [stdout] | [INFO] [stdout] 283 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 283 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:288:32 [INFO] [stdout] | [INFO] [stdout] 288 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 288 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:299:40 [INFO] [stdout] | [INFO] [stdout] 299 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 299 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/crypto/pin.rs:304:32 [INFO] [stdout] | [INFO] [stdout] 304 | assert!(false, e.msg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 304 | assert!(false, "{}", e.msg.to_string()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iso8583/client.rs:36:26 [INFO] [stdout] | [INFO] [stdout] 23 | let mli: Box; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | _tcp_stream: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/iso8583/iso_spec.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 35 | Err(e)=> panic!(e.msg) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 35 | Err(e)=> panic!("{}", e.msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iso8583/server.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new<'a>(host_port: String, spec: &'static Spec, mli_type: MLIType, msg_processor: Box) -> Result>; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match host_port.to_socket_addrs() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iso8583/server.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 91 | let server = ISOServer { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | std::thread::spawn(move || { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 101 | | let listener = std::net::TcpListener::bind(server.sock_addr.as_slice()).unwrap(); [INFO] [stdout] 102 | | [INFO] [stdout] 103 | | for stream in listener.incoming() { [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/iso8583/test.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | iso_msg.set_mac(&cfg); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = iso_msg.set_mac(&cfg); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/iso8583/yaml_de.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | / &ychildren.iter().for_each(|f| { [INFO] [stdout] 50 | | children.push(Into::>::into(f)); [INFO] [stdout] 51 | | }); [INFO] [stdout] | |______________________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 49 | let _ = &ychildren.iter().for_each(|f| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/iso8583/yaml_de.rs:148:38 [INFO] [stdout] | [INFO] [stdout] 148 | Err(e) => assert!(false, e) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{:?}" format string to use the `Debug` implementation of `IsoError` [INFO] [stdout] | [INFO] [stdout] 148 | Err(e) => assert!(false, "{:?}", e) [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/iso8583/mli.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | data.write_u16::(msg.len() as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 194 | let _ = data.write_u16::(msg.len() as u16); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/iso8583/mli.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | data.write_u16::((msg.len() + 2) as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 207 | let _ = data.write_u16::((msg.len() + 2) as u16); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/iso8583/mli.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | data.write_u32::(msg.len() as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 223 | let _ = data.write_u32::(msg.len() as u32); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/iso8583/mli.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | data.write_u32::((msg.len() + 4) as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 239 | let _ = data.write_u32::((msg.len() + 4) as u32); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iso8583_rs` (lib test) due to 4 previous errors; 36 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e481a61d297b691f23502ac367fd0c67e6f1e4df8620169b2ad20a0598bd4625", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e481a61d297b691f23502ac367fd0c67e6f1e4df8620169b2ad20a0598bd4625", kill_on_drop: false }` [INFO] [stdout] e481a61d297b691f23502ac367fd0c67e6f1e4df8620169b2ad20a0598bd4625