[INFO] fetching crate irust 1.71.23... [INFO] checking irust-1.71.23 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate irust 1.71.23 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate irust 1.71.23 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate irust 1.71.23 [INFO] finished tweaking crates.io crate irust 1.71.23 [INFO] tweaked toml for crates.io crate irust 1.71.23 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate irust 1.71.23 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c94666711ef62d50ee98cf9c6ffdb98f17cd6fa1b2d9fb14897f66783354d8da [INFO] running `Command { std: "docker" "start" "-a" "c94666711ef62d50ee98cf9c6ffdb98f17cd6fa1b2d9fb14897f66783354d8da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c94666711ef62d50ee98cf9c6ffdb98f17cd6fa1b2d9fb14897f66783354d8da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c94666711ef62d50ee98cf9c6ffdb98f17cd6fa1b2d9fb14897f66783354d8da", kill_on_drop: false }` [INFO] [stdout] c94666711ef62d50ee98cf9c6ffdb98f17cd6fa1b2d9fb14897f66783354d8da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a275c419826ed96af36ad446fc6ffde153b04665a921b0b77cd009bf17904250 [INFO] running `Command { std: "docker" "start" "-a" "a275c419826ed96af36ad446fc6ffde153b04665a921b0b77cd009bf17904250", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking rustc-ap-rustc_lexer v727.0.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking irust_repl v0.24.6 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking rscript v0.17.0 [INFO] [stderr] Checking irust_api v0.31.8 [INFO] [stderr] Checking printer v0.7.2 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking irust v1.71.23 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/art.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn wait_add(&mut self, mut add_cmd: std::process::Child, msg: &str) -> Result<()> { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | match self.wait_add_inner(&mut add_cmd, msg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/format.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | let go_to_end = |output: Box>| -> String { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | / if show_warnings { [INFO] [stdout] 43 | | output [INFO] [stdout] 44 | | } else { [INFO] [stdout] 45 | | Box::new(output.take_while(|line| { [INFO] [stdout] ... | [INFO] [stdout] 51 | | })) [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/ra.rs:69:14 [INFO] [stdout] | [INFO] [stdout] 33 | let rust_analyzer = RustAnalyzer::start(irust_dir, main_file, repl_body).ok()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Some(Completer { [INFO] [stdout] | ______________^ [INFO] [stdout] 70 | | cursor, [INFO] [stdout] 71 | | suggestions: vec![], [INFO] [stdout] 72 | | suggestion_idx: 0, [INFO] [stdout] ... | [INFO] [stdout] 76 | | rust_analyzer, [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/ra/rust_analyzer.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut process = Command::new("rust-analyzer") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut stdin = process.stdin.take().expect("piped"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut stdout = BufReader::new(process.stdout.take().expect("piped")); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(RustAnalyzer { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | _process: process, [INFO] [stdout] 97 | | stdin, [INFO] [stdout] 98 | | stdout, [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/script/mod.rs:112:50 [INFO] [stdout] | [INFO] [stdout] 112 | ScriptManager::new().map(|script_mg| Box::new(script_mg) as Box) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/script/script_manager.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 22 | let mut sm = rscript::ScriptManager::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut startup_cmds = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Some(ScriptManager { sm, startup_cmds }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irust` (bin "irust" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/art.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn wait_add(&mut self, mut add_cmd: std::process::Child, msg: &str) -> Result<()> { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | match self.wait_add_inner(&mut add_cmd, msg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/format.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | let go_to_end = |output: Box>| -> String { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | / if show_warnings { [INFO] [stdout] 43 | | output [INFO] [stdout] 44 | | } else { [INFO] [stdout] 45 | | Box::new(output.take_while(|line| { [INFO] [stdout] ... | [INFO] [stdout] 51 | | })) [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/ra.rs:69:14 [INFO] [stdout] | [INFO] [stdout] 33 | let rust_analyzer = RustAnalyzer::start(irust_dir, main_file, repl_body).ok()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Some(Completer { [INFO] [stdout] | ______________^ [INFO] [stdout] 70 | | cursor, [INFO] [stdout] 71 | | suggestions: vec![], [INFO] [stdout] 72 | | suggestion_idx: 0, [INFO] [stdout] ... | [INFO] [stdout] 76 | | rust_analyzer, [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/ra/rust_analyzer.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut process = Command::new("rust-analyzer") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut stdin = process.stdin.take().expect("piped"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut stdout = BufReader::new(process.stdout.take().expect("piped")); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(RustAnalyzer { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | _process: process, [INFO] [stdout] 97 | | stdin, [INFO] [stdout] 98 | | stdout, [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/script/mod.rs:112:50 [INFO] [stdout] | [INFO] [stdout] 112 | ScriptManager::new().map(|script_mg| Box::new(script_mg) as Box) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/irust/script/script_manager.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 22 | let mut sm = rscript::ScriptManager::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut startup_cmds = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Some(ScriptManager { sm, startup_cmds }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irust` (bin "irust") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "a275c419826ed96af36ad446fc6ffde153b04665a921b0b77cd009bf17904250", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a275c419826ed96af36ad446fc6ffde153b04665a921b0b77cd009bf17904250", kill_on_drop: false }` [INFO] [stdout] a275c419826ed96af36ad446fc6ffde153b04665a921b0b77cd009bf17904250