[INFO] fetching crate irox-networking 0.4.3... [INFO] checking irox-networking-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate irox-networking 0.4.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate irox-networking 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate irox-networking 0.4.3 [INFO] finished tweaking crates.io crate irox-networking 0.4.3 [INFO] tweaked toml for crates.io crate irox-networking 0.4.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate irox-networking 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6244f89da36286a2b26f1f166e4e25e94a7f56b21375acf6d3b1879ab3c518a7 [INFO] running `Command { std: "docker" "start" "-a" "6244f89da36286a2b26f1f166e4e25e94a7f56b21375acf6d3b1879ab3c518a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6244f89da36286a2b26f1f166e4e25e94a7f56b21375acf6d3b1879ab3c518a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6244f89da36286a2b26f1f166e4e25e94a7f56b21375acf6d3b1879ab3c518a7", kill_on_drop: false }` [INFO] [stdout] 6244f89da36286a2b26f1f166e4e25e94a7f56b21375acf6d3b1879ab3c518a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87785158dbcbe064938be398d57a3cccb4290fcb5527506297a1fdbd72a95072 [INFO] running `Command { std: "docker" "start" "-a" "87785158dbcbe064938be398d57a3cccb4290fcb5527506297a1fdbd72a95072", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Checking irox-bits v0.1.1 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling irox-tools v0.8.1 [INFO] [stderr] Checking irox-units v0.4.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Compiling irox-enums_derive v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling irox-enums v0.2.2 [INFO] [stderr] Compiling irox-types v0.4.1 [INFO] [stderr] Checking irox-time v0.4.2 [INFO] [stderr] Compiling irox-structs_derive v0.3.1 [INFO] [stderr] Checking irox-log v0.2.0 [INFO] [stderr] Checking irox-structs v0.5.1 [INFO] [stderr] Checking irox-networking v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `websockets` [INFO] [stdout] --> src/lib.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg(feature = "websockets")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `serde` [INFO] [stdout] = help: consider adding `websockets` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/headers.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn create_from(input: T) -> Result, std::io::Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let mut headers = HttpHeaders::new_empty(); [INFO] [stdout] 83 | let mut scanner = Scanner::new_crlf(input); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(HeaderResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | headers, [INFO] [stdout] 104 | | remaining: scanner.take_back(), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/response.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn create_from(input: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut bufread = BufReader::new(input); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | mut remaining, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let body = if content_length == 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(HttpResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | version, [INFO] [stdout] 52 | | code, [INFO] [stdout] 53 | | status, [INFO] [stdout] 54 | | headers, [INFO] [stdout] 55 | | body, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 24 | addr: A, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | close: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(a) => a.collect(), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let sock = match TcpListener::bind(addr) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let active_connections = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | let conns = active_connections.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(TCPConnectionManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | active_connections, [INFO] [stdout] 70 | | running_thread: handle, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irox-networking` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "87785158dbcbe064938be398d57a3cccb4290fcb5527506297a1fdbd72a95072", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87785158dbcbe064938be398d57a3cccb4290fcb5527506297a1fdbd72a95072", kill_on_drop: false }` [INFO] [stdout] 87785158dbcbe064938be398d57a3cccb4290fcb5527506297a1fdbd72a95072