[INFO] fetching crate irondash_texture 0.5.0... [INFO] checking irondash_texture-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate irondash_texture 0.5.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate irondash_texture 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate irondash_texture 0.5.0 [INFO] finished tweaking crates.io crate irondash_texture 0.5.0 [INFO] tweaked toml for crates.io crate irondash_texture 0.5.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding android_log-sys v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding android_logger v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding block2 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding cfg-expr v0.15.8 (latest: v0.16.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding glib-sys v0.16.3 (latest: v0.20.2) [INFO] [stderr] Adding gobject-sys v0.16.3 (latest: v0.20.1) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding ndk-sys v0.4.1+23.1.7779620 (latest: v0.6.0+11769913) [INFO] [stderr] Adding system-deps v6.2.2 (latest: v7.0.2) [INFO] [stderr] Adding windows-sys v0.45.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1100e736e1eb674fbed7ab4f2a415a4d59aa542a0d6704233e069fb56e0b0cd [INFO] running `Command { std: "docker" "start" "-a" "e1100e736e1eb674fbed7ab4f2a415a4d59aa542a0d6704233e069fb56e0b0cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1100e736e1eb674fbed7ab4f2a415a4d59aa542a0d6704233e069fb56e0b0cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1100e736e1eb674fbed7ab4f2a415a4d59aa542a0d6704233e069fb56e0b0cd", kill_on_drop: false }` [INFO] [stdout] e1100e736e1eb674fbed7ab4f2a415a4d59aa542a0d6704233e069fb56e0b0cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 810af06e074c8c7e10aad38cbf2d8ac453f2b345c80b90ab657279c0125faefe [INFO] running `Command { std: "docker" "start" "-a" "810af06e074c8c7e10aad38cbf2d8ac453f2b345c80b90ab657279c0125faefe", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking irondash_engine_context v0.5.0 [INFO] [stderr] Compiling cstr v0.2.12 [INFO] [stderr] Checking glib-sys v0.16.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking gobject-sys v0.16.3 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking irondash_run_loop v0.5.0 [INFO] [stderr] Checking irondash_texture v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `FlTextureRegistrarClass` is never constructed [INFO] [stdout] --> src/platform/linux/sys.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct FlTextureRegistrarClass { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FlTextureRegistrarClass` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fl_texture_get_type` is never read [INFO] [stdout] --> src/platform/linux/sys.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct Functions { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 75 | pub fl_texture_get_type: unsafe extern "C" fn() -> GType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn into_sendable_texture(self) -> Arc> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Arc::new(SendableTexture { [INFO] [stdout] | __________________^ [INFO] [stdout] 45 | | sender: RunLoop::current().new_sender(), [INFO] [stdout] 46 | | texture: Mutex::new(Capsule::new(self)), [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 82 | payload_provider: Arc>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result { [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | platform_texture: Type::create_texture(engine_handle, payload_provider)?, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(provider: Arc>) -> Arc> { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Arc::new(Mutex::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 41 | | provider, [INFO] [stdout] 42 | | current_value: None, [INFO] [stdout] 43 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 54 | fn new(engine_handle: i64, texture: GObjectWrapper) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let id = Self::register(engine_handle, &texture)?; [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | id, [INFO] [stdout] 58 | | engine_handle, [INFO] [stdout] 59 | | texture, [INFO] [stdout] 60 | | _phantom_data: PhantomData {}, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FlTextureRegistrarClass` is never constructed [INFO] [stdout] --> src/platform/linux/sys.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct FlTextureRegistrarClass { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FlTextureRegistrarClass` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:101:34 [INFO] [stdout] | [INFO] [stdout] 100 | fn create_pixel_buffer_texture(texture: Arc>>) -> GObjectWrapper { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | new_pixel_buffer_texture(move || { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 102 | | let mut texture = texture.lock().unwrap(); [INFO] [stdout] 103 | | let pixel_data = texture.provider.get_payload(); [INFO] [stdout] 104 | | let buffer = pixel_data.get(); [INFO] [stdout] ... | [INFO] [stdout] 111 | | res [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fl_texture_get_type` is never read [INFO] [stdout] --> src/platform/linux/sys.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct Functions { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 75 | pub fl_texture_get_type: unsafe extern "C" fn() -> GType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn into_sendable_texture(self) -> Arc> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Arc::new(SendableTexture { [INFO] [stdout] | __________________^ [INFO] [stdout] 45 | | sender: RunLoop::current().new_sender(), [INFO] [stdout] 46 | | texture: Mutex::new(Capsule::new(self)), [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 115 | fn create_gl_texture(texture: Arc>>) -> GObjectWrapper { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | new_texture_gl(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 117 | | let mut texture = texture.lock().unwrap(); [INFO] [stdout] 118 | | let gl_texture = texture.provider.get_payload(); [INFO] [stdout] 119 | | let values = gl_texture.get(); [INFO] [stdout] ... | [INFO] [stdout] 127 | | res [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 82 | payload_provider: Arc>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result { [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | platform_texture: Type::create_texture(engine_handle, payload_provider)?, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(provider: Arc>) -> Arc> { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Arc::new(Mutex::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 41 | | provider, [INFO] [stdout] 42 | | current_value: None, [INFO] [stdout] 43 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 54 | fn new(engine_handle: i64, texture: GObjectWrapper) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let id = Self::register(engine_handle, &texture)?; [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | id, [INFO] [stdout] 58 | | engine_handle, [INFO] [stdout] 59 | | texture, [INFO] [stdout] 60 | | _phantom_data: PhantomData {}, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:101:34 [INFO] [stdout] | [INFO] [stdout] 100 | fn create_pixel_buffer_texture(texture: Arc>>) -> GObjectWrapper { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | new_pixel_buffer_texture(move || { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 102 | | let mut texture = texture.lock().unwrap(); [INFO] [stdout] 103 | | let pixel_data = texture.provider.get_payload(); [INFO] [stdout] 104 | | let buffer = pixel_data.get(); [INFO] [stdout] ... | [INFO] [stdout] 111 | | res [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux/mod.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 115 | fn create_gl_texture(texture: Arc>>) -> GObjectWrapper { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | new_texture_gl(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 117 | | let mut texture = texture.lock().unwrap(); [INFO] [stdout] 118 | | let gl_texture = texture.provider.get_payload(); [INFO] [stdout] 119 | | let values = gl_texture.get(); [INFO] [stdout] ... | [INFO] [stdout] 127 | | res [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irondash_texture` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `irondash_texture` (lib) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "810af06e074c8c7e10aad38cbf2d8ac453f2b345c80b90ab657279c0125faefe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "810af06e074c8c7e10aad38cbf2d8ac453f2b345c80b90ab657279c0125faefe", kill_on_drop: false }` [INFO] [stdout] 810af06e074c8c7e10aad38cbf2d8ac453f2b345c80b90ab657279c0125faefe