[INFO] fetching crate irondash_message_channel 0.7.0... [INFO] checking irondash_message_channel-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate irondash_message_channel 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate irondash_message_channel 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate irondash_message_channel 0.7.0 [INFO] finished tweaking crates.io crate irondash_message_channel 0.7.0 [INFO] tweaked toml for crates.io crate irondash_message_channel 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding android_log-sys v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding android_logger v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding block2 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.45.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b221952b0fa694599a015c288a83b1fb122928a316a127fe6120fc7260671061 [INFO] running `Command { std: "docker" "start" "-a" "b221952b0fa694599a015c288a83b1fb122928a316a127fe6120fc7260671061", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b221952b0fa694599a015c288a83b1fb122928a316a127fe6120fc7260671061", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b221952b0fa694599a015c288a83b1fb122928a316a127fe6120fc7260671061", kill_on_drop: false }` [INFO] [stdout] b221952b0fa694599a015c288a83b1fb122928a316a127fe6120fc7260671061 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 823fcf490f74900f124a1aebee46711f0f906d986da3196ee77cfc947d00c586 [INFO] running `Command { std: "docker" "start" "-a" "823fcf490f74900f124a1aebee46711f0f906d986da3196ee77cfc947d00c586", kill_on_drop: false }` [INFO] [stderr] Checking irondash_engine_context v0.5.0 [INFO] [stderr] Checking irondash_dart_ffi v0.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking irondash_run_loop v0.5.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking irondash_message_channel v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_method_handler.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | fn into_platform_result(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | self.map(|v| v.into()).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_method_handler.rs:158:32 [INFO] [stdout] | [INFO] [stdout] 157 | fn new(channel: &str, handler: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | Self::new_ref(channel, Rc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_channel.rs:24:67 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn post_message>(&self, message: V) -> Result<(), PostMessageError> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let channel = MessageChannel::get(); [INFO] [stdout] 24 | channel.post_message(self.isolate_id, &self.channel_name, message.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_channel.rs:52:32 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(channel: &str, handler: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self::new_ref(channel, Rc::new(RefCell::new(handler))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_channel.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new_ref(channel: &str, handler: Rc>) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | _internal: EventChannelInternal { [INFO] [stdout] | ________________________^ [INFO] [stdout] 62 | | handler: handler.clone(), [INFO] [stdout] 63 | | channel_name: channel.into(), [INFO] [stdout] 64 | | inner: RefCell::new(Inner { [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | .register(channel), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalizable_handle.rs:145:57 [INFO] [stdout] | [INFO] [stdout] 145 | let state = FUNCTIONS.get_or_init(|| Mutex::new(FinalizableHandleState::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalizable_handle.rs:168:17 [INFO] [stdout] | [INFO] [stdout] 167 | .filter_map(|mut f| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | / f.finalizer [INFO] [stdout] 169 | | .take() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalizable_handle.rs:170:50 [INFO] [stdout] | [INFO] [stdout] 170 | .map(|finalizer| (finalizer, f.run_loop_sender.clone())) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 97 | message: Value, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | reply: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | / self.inner [INFO] [stdout] 103 | | .lock() [INFO] [stdout] 104 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 112 | message: Value, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | ) -> Result<(), PostMessageError> { [INFO] [stdout] 114 | / self.inner [INFO] [stdout] 115 | | .lock() [INFO] [stdout] 116 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn register_delegate(&self, channel: &str, delegate: Rc) [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / self.inner [INFO] [stdout] 125 | | .lock() [INFO] [stdout] 126 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/method_handler.rs:181:32 [INFO] [stdout] | [INFO] [stdout] 180 | fn new(channel: &str, handler: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Self::new_ref(channel, Rc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/method_handler.rs:270:10 [INFO] [stdout] | [INFO] [stdout] 267 | pub(crate) fn unpack_method_call(value: Value, isolate: IsolateId) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let vec: Vec = value.try_into().ok()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let mut iter = vec.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | Some(MethodCall { [INFO] [stdout] | __________^ [INFO] [stdout] 271 | | method: iter.next()?.try_into().ok()?, [INFO] [stdout] 272 | | args: iter.next()?, [INFO] [stdout] 273 | | isolate, [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 66 | fn from(v: $for_type) -> Value { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | $variant(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | impl_from!(Value::Map, Vec<(Value, Value)>); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_from` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 66 | fn from(v: $for_type) -> Value { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | $variant(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | impl_from!(Value::FinalizableHandle, Arc); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_from` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 138 | fn from(map: HashMap) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let values: Vec<(Value, Value)> = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | map.into_iter().map(|(k, v)| (k.into(), v.into())).collect(); [INFO] [stdout] 141 | Value::Map(values.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:140:43 [INFO] [stdout] | [INFO] [stdout] 140 | map.into_iter().map(|(k, v)| (k.into(), v.into())).collect(); [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:140:53 [INFO] [stdout] | [INFO] [stdout] 140 | map.into_iter().map(|(k, v)| (k.into(), v.into())).collect(); [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:279:24 [INFO] [stdout] | [INFO] [stdout] 278 | .map(|(k, v)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | Ok(( [INFO] [stdout] | ________________________^ [INFO] [stdout] 280 | | k.try_into().map_err(|e: E1| e.into())?, [INFO] [stdout] 281 | | v.try_into().map_err(|e: E2| e.into())?, [INFO] [stdout] 282 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:305:26 [INFO] [stdout] | [INFO] [stdout] 305 | .map(|v| v.try_into().map_err(|e: E| e.into())) [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 415 | fn from(value: ValueTupleList) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | value.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_method_handler.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | fn into_platform_result(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | self.map(|v| v.into()).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_method_handler.rs:158:32 [INFO] [stdout] | [INFO] [stdout] 157 | fn new(channel: &str, handler: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | Self::new_ref(channel, Rc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_channel.rs:24:67 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn post_message>(&self, message: V) -> Result<(), PostMessageError> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let channel = MessageChannel::get(); [INFO] [stdout] 24 | channel.post_message(self.isolate_id, &self.channel_name, message.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_channel.rs:52:32 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(channel: &str, handler: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self::new_ref(channel, Rc::new(RefCell::new(handler))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_channel.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new_ref(channel: &str, handler: Rc>) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | _internal: EventChannelInternal { [INFO] [stdout] | ________________________^ [INFO] [stdout] 62 | | handler: handler.clone(), [INFO] [stdout] 63 | | channel_name: channel.into(), [INFO] [stdout] 64 | | inner: RefCell::new(Inner { [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | .register(channel), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalizable_handle.rs:145:57 [INFO] [stdout] | [INFO] [stdout] 145 | let state = FUNCTIONS.get_or_init(|| Mutex::new(FinalizableHandleState::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalizable_handle.rs:168:17 [INFO] [stdout] | [INFO] [stdout] 167 | .filter_map(|mut f| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | / f.finalizer [INFO] [stdout] 169 | | .take() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalizable_handle.rs:170:50 [INFO] [stdout] | [INFO] [stdout] 170 | .map(|finalizer| (finalizer, f.run_loop_sender.clone())) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 97 | message: Value, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | reply: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | / self.inner [INFO] [stdout] 103 | | .lock() [INFO] [stdout] 104 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 112 | message: Value, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | ) -> Result<(), PostMessageError> { [INFO] [stdout] 114 | / self.inner [INFO] [stdout] 115 | | .lock() [INFO] [stdout] 116 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn register_delegate(&self, channel: &str, delegate: Rc) [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / self.inner [INFO] [stdout] 125 | | .lock() [INFO] [stdout] 126 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/method_handler.rs:181:32 [INFO] [stdout] | [INFO] [stdout] 180 | fn new(channel: &str, handler: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Self::new_ref(channel, Rc::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/method_handler.rs:270:10 [INFO] [stdout] | [INFO] [stdout] 267 | pub(crate) fn unpack_method_call(value: Value, isolate: IsolateId) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let vec: Vec = value.try_into().ok()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let mut iter = vec.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | Some(MethodCall { [INFO] [stdout] | __________^ [INFO] [stdout] 271 | | method: iter.next()?.try_into().ok()?, [INFO] [stdout] 272 | | args: iter.next()?, [INFO] [stdout] 273 | | isolate, [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 66 | fn from(v: $for_type) -> Value { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | $variant(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 85 | impl_from!(Value::Map, Vec<(Value, Value)>); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_from` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 66 | fn from(v: $for_type) -> Value { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | $variant(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | impl_from!(Value::FinalizableHandle, Arc); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_from` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 138 | fn from(map: HashMap) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let values: Vec<(Value, Value)> = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | map.into_iter().map(|(k, v)| (k.into(), v.into())).collect(); [INFO] [stdout] 141 | Value::Map(values.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:140:43 [INFO] [stdout] | [INFO] [stdout] 140 | map.into_iter().map(|(k, v)| (k.into(), v.into())).collect(); [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:140:53 [INFO] [stdout] | [INFO] [stdout] 140 | map.into_iter().map(|(k, v)| (k.into(), v.into())).collect(); [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:279:24 [INFO] [stdout] | [INFO] [stdout] 278 | .map(|(k, v)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | Ok(( [INFO] [stdout] | ________________________^ [INFO] [stdout] 280 | | k.try_into().map_err(|e: E1| e.into())?, [INFO] [stdout] 281 | | v.try_into().map_err(|e: E2| e.into())?, [INFO] [stdout] 282 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:305:26 [INFO] [stdout] | [INFO] [stdout] 305 | .map(|v| v.try_into().map_err(|e: E| e.into())) [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irondash_message_channel` (lib) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 415 | fn from(value: ValueTupleList) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | value.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irondash_message_channel` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "823fcf490f74900f124a1aebee46711f0f906d986da3196ee77cfc947d00c586", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "823fcf490f74900f124a1aebee46711f0f906d986da3196ee77cfc947d00c586", kill_on_drop: false }` [INFO] [stdout] 823fcf490f74900f124a1aebee46711f0f906d986da3196ee77cfc947d00c586