[INFO] fetching crate ironcladserver 0.1.0... [INFO] checking ironcladserver-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ironcladserver 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ironcladserver 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ironcladserver 0.1.0 [INFO] finished tweaking crates.io crate ironcladserver 0.1.0 [INFO] tweaked toml for crates.io crate ironcladserver 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate ironcladserver 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bc7d356611a3371609a283a385062ae7a8d1c356e60cb2397ac66a43683b13e [INFO] running `Command { std: "docker" "start" "-a" "4bc7d356611a3371609a283a385062ae7a8d1c356e60cb2397ac66a43683b13e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bc7d356611a3371609a283a385062ae7a8d1c356e60cb2397ac66a43683b13e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bc7d356611a3371609a283a385062ae7a8d1c356e60cb2397ac66a43683b13e", kill_on_drop: false }` [INFO] [stdout] 4bc7d356611a3371609a283a385062ae7a8d1c356e60cb2397ac66a43683b13e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f0d54bada3aa0d14630b084e928f5ddf8a383055c203c125eeb9b4557218db8 [INFO] running `Command { std: "docker" "start" "-a" "8f0d54bada3aa0d14630b084e928f5ddf8a383055c203c125eeb9b4557218db8", kill_on_drop: false }` [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking value-bag v1.4.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking parking v2.1.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking async-lock v2.7.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling quote v1.0.31 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking concurrent-queue v2.2.0 [INFO] [stderr] Checking async-task v4.4.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling syn v2.0.26 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking atomic-waker v1.1.1 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking blocking v1.3.1 [INFO] [stderr] Checking async-executor v1.5.1 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking ironcladserver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 42 | let (concurrency, workers_pool) = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | ip_port, [INFO] [stdout] 58 | | concurrency, [INFO] [stdout] 59 | | workers_pool, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:11 [INFO] [stdout] | [INFO] [stdout] 137 | fn handle_connection_tp(mut stream: TcpStream) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut buffer = [0; 1024]; [INFO] [stdout] 139 | match stream.read(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 217 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | [INFO] [stdout] 219 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | [INFO] [stdout] 221 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(ThreadPool { [INFO] [stdout] | ____________^ [INFO] [stdout] 228 | | workers, [INFO] [stdout] 229 | | sender: Some(sender), [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 263 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 42 | let (concurrency, workers_pool) = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | ip_port, [INFO] [stdout] 58 | | concurrency, [INFO] [stdout] 59 | | workers_pool, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:11 [INFO] [stdout] | [INFO] [stdout] 137 | fn handle_connection_tp(mut stream: TcpStream) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut buffer = [0; 1024]; [INFO] [stdout] 139 | match stream.read(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 217 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | [INFO] [stdout] 219 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | [INFO] [stdout] 221 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(ThreadPool { [INFO] [stdout] | ____________^ [INFO] [stdout] 228 | | workers, [INFO] [stdout] 229 | | sender: Some(sender), [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 263 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ironcladserver` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ironcladserver` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "8f0d54bada3aa0d14630b084e928f5ddf8a383055c203c125eeb9b4557218db8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f0d54bada3aa0d14630b084e928f5ddf8a383055c203c125eeb9b4557218db8", kill_on_drop: false }` [INFO] [stdout] 8f0d54bada3aa0d14630b084e928f5ddf8a383055c203c125eeb9b4557218db8