[INFO] fetching crate iron-os-packages-api 0.1.0... [INFO] checking iron-os-packages-api-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iron-os-packages-api 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate iron-os-packages-api 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iron-os-packages-api 0.1.0 [INFO] finished tweaking crates.io crate iron-os-packages-api 0.1.0 [INFO] tweaked toml for crates.io crate iron-os-packages-api 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 97 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding proc-macro-crate v2.0.2 (latest: v3.2.0) [INFO] [stderr] Adding toml_datetime v0.6.3 (latest: v0.6.8) [INFO] [stderr] Adding toml_edit v0.20.2 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 834453c29cad30abba149401f89421549e62204e861c49cf985faa1a87cc4754 [INFO] running `Command { std: "docker" "start" "-a" "834453c29cad30abba149401f89421549e62204e861c49cf985faa1a87cc4754", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "834453c29cad30abba149401f89421549e62204e861c49cf985faa1a87cc4754", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "834453c29cad30abba149401f89421549e62204e861c49cf985faa1a87cc4754", kill_on_drop: false }` [INFO] [stdout] 834453c29cad30abba149401f89421549e62204e861c49cf985faa1a87cc4754 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e131fd1d065aed59fef8496c8eda63a915bd6b9a0466cc2c251f616cc26f20e [INFO] running `Command { std: "docker" "start" "-a" "2e131fd1d065aed59fef8496c8eda63a915bd6b9a0466cc2c251f616cc26f20e", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking simple-bytes v0.2.14 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling fire-stream-api-codegen v0.1.6 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking fire-crypto v0.4.3 [INFO] [stderr] Checking fire-stream v0.4.3 [INFO] [stderr] Checking fire-stream-api v0.3.4 [INFO] [stderr] Checking iron-os-packages-api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new_testing(priv_key: Keypair) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Self { [INFO] [stdout] 77 | inner: StreamServer::new_encrypted(PanicListener::new(), Config { [INFO] [stdout] | ____________________^ [INFO] [stdout] 78 | | timeout: TIMEOUT, [INFO] [stdout] 79 | | body_limit: BODY_LIMIT [INFO] [stdout] 80 | | }, priv_key) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:86:11 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn build(self) -> TestingServer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | TestingServer { [INFO] [stdout] 86 | inner: self.inner.build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn build(self) -> TestingServer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | session: Arc::new(Session::new( [INFO] [stdout] | ______________________^ [INFO] [stdout] 88 | | SocketAddr::V4("127.0.0.1:8080".parse().unwrap()) [INFO] [stdout] 89 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:205:6 [INFO] [stdout] | [INFO] [stdout] 204 | fn from_message(msg: Message) -> StdResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | Ok(Self { inner: msg }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:279:6 [INFO] [stdout] | [INFO] [stdout] 271 | fn new(msg: Message) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(Self { inner: msg }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:350:3 [INFO] [stdout] | [INFO] [stdout] 349 | fn from_message(msg: Message) -> StdResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | Self::new(msg).map_err(|e| MessageError::Other(e.to_string().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:508:6 [INFO] [stdout] | [INFO] [stdout] 499 | fn from_message(msg: Message) -> StdResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 509 | | signature: sign, [INFO] [stdout] 510 | | message: msg [INFO] [stdout] 511 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iron-os-packages-api` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new_testing(priv_key: Keypair) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Self { [INFO] [stdout] 77 | inner: StreamServer::new_encrypted(PanicListener::new(), Config { [INFO] [stdout] | ____________________^ [INFO] [stdout] 78 | | timeout: TIMEOUT, [INFO] [stdout] 79 | | body_limit: BODY_LIMIT [INFO] [stdout] 80 | | }, priv_key) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:86:11 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn build(self) -> TestingServer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | TestingServer { [INFO] [stdout] 86 | inner: self.inner.build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn build(self) -> TestingServer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | session: Arc::new(Session::new( [INFO] [stdout] | ______________________^ [INFO] [stdout] 88 | | SocketAddr::V4("127.0.0.1:8080".parse().unwrap()) [INFO] [stdout] 89 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:205:6 [INFO] [stdout] | [INFO] [stdout] 204 | fn from_message(msg: Message) -> StdResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | Ok(Self { inner: msg }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:279:6 [INFO] [stdout] | [INFO] [stdout] 271 | fn new(msg: Message) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(Self { inner: msg }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:350:3 [INFO] [stdout] | [INFO] [stdout] 349 | fn from_message(msg: Message) -> StdResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | Self::new(msg).map_err(|e| MessageError::Other(e.to_string().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:508:6 [INFO] [stdout] | [INFO] [stdout] 499 | fn from_message(msg: Message) -> StdResult { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 509 | | signature: sign, [INFO] [stdout] 510 | | message: msg [INFO] [stdout] 511 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iron-os-packages-api` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "2e131fd1d065aed59fef8496c8eda63a915bd6b9a0466cc2c251f616cc26f20e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e131fd1d065aed59fef8496c8eda63a915bd6b9a0466cc2c251f616cc26f20e", kill_on_drop: false }` [INFO] [stdout] 2e131fd1d065aed59fef8496c8eda63a915bd6b9a0466cc2c251f616cc26f20e