[INFO] fetching crate iroh-metrics 0.23.0... [INFO] checking iroh-metrics-0.23.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iroh-metrics 0.23.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate iroh-metrics 0.23.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iroh-metrics 0.23.0 [INFO] finished tweaking crates.io crate iroh-metrics 0.23.0 [INFO] tweaked toml for crates.io crate iroh-metrics 0.23.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 141 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding erased-serde v0.3.31 (latest: v0.4.5) [INFO] [stderr] Adding erased_set v0.7.0 (latest: v0.8.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69a5e2b1ee057f9df11a4fcbe656a919d2371708af801bc6c67227f5a3df0835 [INFO] running `Command { std: "docker" "start" "-a" "69a5e2b1ee057f9df11a4fcbe656a919d2371708af801bc6c67227f5a3df0835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69a5e2b1ee057f9df11a4fcbe656a919d2371708af801bc6c67227f5a3df0835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69a5e2b1ee057f9df11a4fcbe656a919d2371708af801bc6c67227f5a3df0835", kill_on_drop: false }` [INFO] [stdout] 69a5e2b1ee057f9df11a4fcbe656a919d2371708af801bc6c67227f5a3df0835 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb4a2c00b0860e45a2452cc3cd7d190b827313c20b190cd15adbff0f73548c6b [INFO] running `Command { std: "docker" "start" "-a" "bb4a2c00b0860e45a2452cc3cd7d190b827313c20b190cd15adbff0f73548c6b", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling struct_iterable_internal v0.1.1 [INFO] [stderr] Compiling prometheus-client v0.22.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking erased_set v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling erased-serde v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Compiling struct_iterable_derive v0.1.0 [INFO] [stderr] Checking struct_iterable v0.1.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking iroh-metrics v0.23.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn try_init(f: F) -> std::io::Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let mut registry = Registry::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut metrics_map = ErasedSyncSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | / CORE.set(Core { [INFO] [stdout] 161 | | metrics_map, [INFO] [stdout] 162 | | #[cfg(feature = "metrics")] [INFO] [stdout] 163 | | registry, [INFO] [stdout] 164 | | #[cfg(feature = "metrics")] [INFO] [stdout] 165 | | usage_reporter, [INFO] [stdout] 166 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:50:31 [INFO] [stdout] | [INFO] [stdout] 49 | fn body_full(content: impl Into) -> BytesBody { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | http_body_util::Full::new(content.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iroh-metrics` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn try_init(f: F) -> std::io::Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let mut registry = Registry::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut metrics_map = ErasedSyncSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | / CORE.set(Core { [INFO] [stdout] 161 | | metrics_map, [INFO] [stdout] 162 | | #[cfg(feature = "metrics")] [INFO] [stdout] 163 | | registry, [INFO] [stdout] 164 | | #[cfg(feature = "metrics")] [INFO] [stdout] 165 | | usage_reporter, [INFO] [stdout] 166 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:50:31 [INFO] [stdout] | [INFO] [stdout] 49 | fn body_full(content: impl Into) -> BytesBody { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | http_body_util::Full::new(content.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iroh-metrics` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "bb4a2c00b0860e45a2452cc3cd7d190b827313c20b190cd15adbff0f73548c6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4a2c00b0860e45a2452cc3cd7d190b827313c20b190cd15adbff0f73548c6b", kill_on_drop: false }` [INFO] [stdout] bb4a2c00b0860e45a2452cc3cd7d190b827313c20b190cd15adbff0f73548c6b