[INFO] fetching crate irclap 0.1.0... [INFO] checking irclap-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate irclap 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate irclap 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate irclap 0.1.0 [INFO] finished tweaking crates.io crate irclap 0.1.0 [INFO] tweaked toml for crates.io crate irclap 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 150 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding irc v0.13.6 (latest: v1.0.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scoped-tls v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding slab v0.3.0 (latest: v0.4.9) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-timer v0.1.2 (latest: v0.2.13) [INFO] [stderr] Adding tokio-tls v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yaml-rust v0.3.5 (latest: v0.4.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09a5a1417eeea0fbc8445ba0f2556458d86bb1859651c22df1da3188d72895e4 [INFO] running `Command { std: "docker" "start" "-a" "09a5a1417eeea0fbc8445ba0f2556458d86bb1859651c22df1da3188d72895e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09a5a1417eeea0fbc8445ba0f2556458d86bb1859651c22df1da3188d72895e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09a5a1417eeea0fbc8445ba0f2556458d86bb1859651c22df1da3188d72895e4", kill_on_drop: false }` [INFO] [stdout] 09a5a1417eeea0fbc8445ba0f2556458d86bb1859651c22df1da3188d72895e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05bcad649b9d3a7120bcdc0b6d2d8dccab318fe42bdf08359ad6a4d741e30d26 [INFO] running `Command { std: "docker" "start" "-a" "05bcad649b9d3a7120bcdc0b6d2d8dccab318fe42bdf08359ad6a4d741e30d26", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking irc v0.13.6 [INFO] [stderr] Checking irclap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:91:86 [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:91:86 [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:94:45 [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:94:45 [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 162 | while let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 162 | if let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 219 | app: clap::App<'a, 'a>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | context: IrclapProcessor, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | client: ircp::IrcClient) [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | / client [INFO] [stdout] 226 | | .stream() [INFO] [stdout] 227 | | .filter(|m| {println!("{:?}", m); m.response_target().is_some()}) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:228:19 [INFO] [stdout] | [INFO] [stdout] 219 | app: clap::App<'a, 'a>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | context: IrclapProcessor, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | client: ircp::IrcClient) [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | .for_each(move |msg| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 229 | | process_single_message(app.clone(), &context, &client, msg); [INFO] [stdout] 230 | | Ok(()) [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 162 | while let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 162 | if let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:5 [INFO] [stdout] | [INFO] [stdout] 219 | app: clap::App<'a, 'a>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | context: IrclapProcessor, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | client: ircp::IrcClient) [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | / client [INFO] [stdout] 226 | | .stream() [INFO] [stdout] 227 | | .filter(|m| {println!("{:?}", m); m.response_target().is_some()}) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:228:19 [INFO] [stdout] | [INFO] [stdout] 219 | app: clap::App<'a, 'a>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | context: IrclapProcessor, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | client: ircp::IrcClient) [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | .for_each(move |msg| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 229 | | process_single_message(app.clone(), &context, &client, msg); [INFO] [stdout] 230 | | Ok(()) [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 260 | handle: Handle, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | cfg: &'a ircp::Config, [INFO] [stdout] 262 | app: clap::App<'a, 'a>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | mapper: CM, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | processor: CP) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | let ctxt = IrclapProcessor::new(mapper, processor); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | let irc_client_creator = ircp::IrcClient::new_future(handle, cfg).unwrap(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let complete_app = app.setting(clap::AppSettings::NoBinaryName); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | [INFO] [stdout] 275 | / irc_client_creator [INFO] [stdout] 276 | | //item 0 is the actual irc client [INFO] [stdout] 277 | | .and_then(|packed_client| packed_client.0.identify().map(|_| packed_client)) [INFO] [stdout] 278 | | .and_then(move |PackedIrcClient(client, future)| { [INFO] [stdout] 279 | | //drive both sends (future) and processing (the process_message_streams result) [INFO] [stdout] 280 | | future.join(process_message_streams(complete_app, ctxt, client)) [INFO] [stdout] 281 | | }).map(|_| ()) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:35 [INFO] [stdout] | [INFO] [stdout] 277 | .and_then(|packed_client| packed_client.0.identify().map(|_| packed_client)) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:66 [INFO] [stdout] | [INFO] [stdout] 277 | .and_then(|packed_client| packed_client.0.identify().map(|_| packed_client)) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 268 | let ctxt = IrclapProcessor::new(mapper, processor); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | let complete_app = app.setting(clap::AppSettings::NoBinaryName); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | .and_then(move |PackedIrcClient(client, future)| { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | //drive both sends (future) and processing (the process_message_streams result) [INFO] [stdout] 280 | future.join(process_message_streams(complete_app, ctxt, client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 260 | handle: Handle, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | cfg: &'a ircp::Config, [INFO] [stdout] 262 | app: clap::App<'a, 'a>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | mapper: CM, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | processor: CP) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | let ctxt = IrclapProcessor::new(mapper, processor); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | let irc_client_creator = ircp::IrcClient::new_future(handle, cfg).unwrap(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let complete_app = app.setting(clap::AppSettings::NoBinaryName); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | [INFO] [stdout] 275 | / irc_client_creator [INFO] [stdout] 276 | | //item 0 is the actual irc client [INFO] [stdout] 277 | | .and_then(|packed_client| packed_client.0.identify().map(|_| packed_client)) [INFO] [stdout] 278 | | .and_then(move |PackedIrcClient(client, future)| { [INFO] [stdout] 279 | | //drive both sends (future) and processing (the process_message_streams result) [INFO] [stdout] 280 | | future.join(process_message_streams(complete_app, ctxt, client)) [INFO] [stdout] 281 | | }).map(|_| ()) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:35 [INFO] [stdout] | [INFO] [stdout] 277 | .and_then(|packed_client| packed_client.0.identify().map(|_| packed_client)) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:277:66 [INFO] [stdout] | [INFO] [stdout] 277 | .and_then(|packed_client| packed_client.0.identify().map(|_| packed_client)) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 268 | let ctxt = IrclapProcessor::new(mapper, processor); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | let complete_app = app.setting(clap::AppSettings::NoBinaryName); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | .and_then(move |PackedIrcClient(client, future)| { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | //drive both sends (future) and processing (the process_message_streams result) [INFO] [stdout] 280 | future.join(process_message_streams(complete_app, ctxt, client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irclap` (lib) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `irclap` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "05bcad649b9d3a7120bcdc0b6d2d8dccab318fe42bdf08359ad6a4d741e30d26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05bcad649b9d3a7120bcdc0b6d2d8dccab318fe42bdf08359ad6a4d741e30d26", kill_on_drop: false }` [INFO] [stdout] 05bcad649b9d3a7120bcdc0b6d2d8dccab318fe42bdf08359ad6a4d741e30d26