[INFO] fetching crate irapt 0.2.0... [INFO] checking irapt-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate irapt 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate irapt 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate irapt 0.2.0 [INFO] finished tweaking crates.io crate irapt 0.2.0 [INFO] tweaked toml for crates.io crate irapt 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 819502cdba1e87943edc537b7ec99464ee81dc70b16d54fa0e4004d41a8dd5de [INFO] running `Command { std: "docker" "start" "-a" "819502cdba1e87943edc537b7ec99464ee81dc70b16d54fa0e4004d41a8dd5de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "819502cdba1e87943edc537b7ec99464ee81dc70b16d54fa0e4004d41a8dd5de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "819502cdba1e87943edc537b7ec99464ee81dc70b16d54fa0e4004d41a8dd5de", kill_on_drop: false }` [INFO] [stdout] 819502cdba1e87943edc537b7ec99464ee81dc70b16d54fa0e4004d41a8dd5de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e46ab3d587d2426531d7af6f8b9634c4162db709cc874ea0f2846245d1a6aa52 [INFO] running `Command { std: "docker" "start" "-a" "e46ab3d587d2426531d7af6f8b9634c4162db709cc874ea0f2846245d1a6aa52", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling rustfft v6.2.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking irapt v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | use itertools::{chain, zip}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | let weighted_candidates = zip(candidates, &*self.weights).map(|(candidate, weight)| candidate * weight); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 81 | let min_costs = zip(last_step_min_costs, weighted_candidates) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | zip(&mut *new_step.min_indices, &mut *self.min_costs_buffer).set_from(min_costs); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/harmonics.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use itertools::zip; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/harmonics.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | let harmonics = zip(head_filter_merged, last_filter_merged).map(move |(head, last)| HarmonicParameter { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/interpolate.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | use itertools::{zip, Itertools}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/interpolate.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | zip(self.window.iter().rev(), &*self.filter).map(|(x, y)| x * y).sum() [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/polyphase_filter.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::{chain, repeat_n, zip}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/polyphase_filter.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | let filtered_samples = zip(samples, filter).map(|(sample, filter)| sample * filter); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/polyphase_filter.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | zip(channels_cells.iter().cycle().copied_cell(), filtered_samples).map(|(channel, filtered_sample)| channel + filtered_sample); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | use itertools::{chain, zip}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | let weighted_candidates = zip(candidates, &*self.weights).map(|(candidate, weight)| candidate * weight); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 81 | let min_costs = zip(last_step_min_costs, weighted_candidates) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/candidates/selection.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | zip(&mut *new_step.min_indices, &mut *self.min_costs_buffer).set_from(min_costs); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/harmonics.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use itertools::zip; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/harmonics.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | let harmonics = zip(head_filter_merged, last_filter_merged).map(move |(head, last)| HarmonicParameter { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/interpolate.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | use itertools::{zip, Itertools}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/interpolate.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | zip(self.window.iter().rev(), &*self.filter).map(|(x, y)| x * y).sum() [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/polyphase_filter.rs:5:34 [INFO] [stdout] | [INFO] [stdout] 5 | use itertools::{chain, repeat_n, zip}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/polyphase_filter.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | let filtered_samples = zip(samples, filter).map(|(sample, filter)| sample * filter); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `itertools::zip`: Use [std::iter::zip](https://doc.rust-lang.org/std/iter/fn.zip.html) instead [INFO] [stdout] --> src/polyphase_filter.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | zip(channels_cells.iter().cycle().copied_cell(), filtered_samples).map(|(channel, filtered_sample)| channel + filtered_sample); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 218 | let estimator = HarmonicParametersEstimator::new(parameters.harmonics_window_len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | [INFO] [stdout] 220 | let candidate_generator = CandidateGenerator::new( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let candidate_selector = CandidateSelector::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | parameters, [INFO] [stdout] 234 | | estimator, [INFO] [stdout] 235 | | candidate_generator, [INFO] [stdout] 236 | | candidate_selector, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/generation.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 48 | let ifft = FftPlanner::new().plan_fft_inverse(fft_len); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let ifft_buffer = vec![<_>::default(); ifft.len()].into(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let ifft_scratch = vec![<_>::default(); ifft.get_inplace_scratch_len()].into(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let interpolator = InterpolationFilter::new(half_interpolation_window_len, interpolation_factor); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let window_len = (max_pitch_index - min_pitch_index) * usize::from(interpolation_factor) + 1; [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | ifft, [INFO] [stdout] 55 | | ifft_buffer, [INFO] [stdout] 56 | | ifft_scratch, [INFO] [stdout] ... | [INFO] [stdout] 59 | | window_len, [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 37 | normalized_candidate_frequencies: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let weights = normalized_candidate_frequencies [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | steps: VecDeque::with_capacity(steps_per_window), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 37 | normalized_candidate_frequencies: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let weights = normalized_candidate_frequencies [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | last_step_min_costs: vec![0.0; candidates_per_step].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 37 | normalized_candidate_frequencies: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let weights = normalized_candidate_frequencies [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | min_costs_buffer: vec![0.0; candidates_per_step].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 148 | fn min_candidate_cost<'a, I: IntoIterator>(candidate_costs: I) -> Option<(usize, f64)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / candidate_costs [INFO] [stdout] 150 | | .into_iter() [INFO] [stdout] 151 | | .cloned() [INFO] [stdout] 152 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/harmonics.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 26 | let channel_buffer = vec![Complex::new(0.0, 0.0); window_len as usize + 44].into_boxed_slice(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let filter = PolyphaseFilter::new(window_len, channel_buffer.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | channel_buffers: (channel_buffer.clone(), channel_buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irapt` (lib) due to 8 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 218 | let estimator = HarmonicParametersEstimator::new(parameters.harmonics_window_len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | [INFO] [stdout] 220 | let candidate_generator = CandidateGenerator::new( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let candidate_selector = CandidateSelector::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | parameters, [INFO] [stdout] 234 | | estimator, [INFO] [stdout] 235 | | candidate_generator, [INFO] [stdout] 236 | | candidate_selector, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/test.rs:9:33 [INFO] [stdout] | [INFO] [stdout] 7 | let expected_rows = expected.map(|expected| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let expected = expected.unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | (0..expected.len()).map(move |index| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 10 | | let expected_str = expected.get(index).unwrap(); [INFO] [stdout] 11 | | expected_str.parse::().unwrap_or_else(|_| panic!("unparsable csv test data")) [INFO] [stdout] 12 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/test.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 8 | let expected = expected.unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | expected_str.parse::().unwrap_or_else(|_| panic!("unparsable csv test data")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/generation.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 48 | let ifft = FftPlanner::new().plan_fft_inverse(fft_len); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let ifft_buffer = vec![<_>::default(); ifft.len()].into(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let ifft_scratch = vec![<_>::default(); ifft.get_inplace_scratch_len()].into(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let interpolator = InterpolationFilter::new(half_interpolation_window_len, interpolation_factor); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let window_len = (max_pitch_index - min_pitch_index) * usize::from(interpolation_factor) + 1; [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | ifft, [INFO] [stdout] 55 | | ifft_buffer, [INFO] [stdout] 56 | | ifft_scratch, [INFO] [stdout] ... | [INFO] [stdout] 59 | | window_len, [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 37 | normalized_candidate_frequencies: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let weights = normalized_candidate_frequencies [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | steps: VecDeque::with_capacity(steps_per_window), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 37 | normalized_candidate_frequencies: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let weights = normalized_candidate_frequencies [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | last_step_min_costs: vec![0.0; candidates_per_step].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 37 | normalized_candidate_frequencies: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let weights = normalized_candidate_frequencies [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | min_costs_buffer: vec![0.0; candidates_per_step].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidates/selection.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 148 | fn min_candidate_cost<'a, I: IntoIterator>(candidate_costs: I) -> Option<(usize, f64)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / candidate_costs [INFO] [stdout] 150 | | .into_iter() [INFO] [stdout] 151 | | .cloned() [INFO] [stdout] 152 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/harmonics.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 26 | let channel_buffer = vec![Complex::new(0.0, 0.0); window_len as usize + 44].into_boxed_slice(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let filter = PolyphaseFilter::new(window_len, channel_buffer.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | channel_buffers: (channel_buffer.clone(), channel_buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/harmonics/test.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | let expected_steps = zip_eq(expected_step_amplitudes, expected_step_frequencies).map(|(amplitudes, frequencies)| { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | zip_eq(amplitudes, frequencies).map(|(amplitude, frequency)| HarmonicParameter { amplitude, frequency }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `irapt` (lib test) due to 11 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e46ab3d587d2426531d7af6f8b9634c4162db709cc874ea0f2846245d1a6aa52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e46ab3d587d2426531d7af6f8b9634c4162db709cc874ea0f2846245d1a6aa52", kill_on_drop: false }` [INFO] [stdout] e46ab3d587d2426531d7af6f8b9634c4162db709cc874ea0f2846245d1a6aa52